pandory500/SDL-mirror
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed bug 3852 - SDL_FreeSurface deallocates surface->map even if the surface is not yet freed

Browse source 
Evgeny Kapun

Commit 52dcef74bdc5 [1], which was a fix for bug #3790, introduced a new bug: now, calling SDL_FreeSurface(surface) deallocates surface->map even if there are other references to the surface. This is bad, because some functions (such as SDL_ConvertSurface) assume that surface->map is not NULL.
This commit is contained in:
Sam Lantinga 2017-09-29 07:44:30 -07:00
parent 157ff58212
commit 1b2b7b2bfe
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/video/SDL_surface.c
View file

@ -1198,10 +1198,8 @@ SDL_FreeSurface(SDL_Surface * surface)
if (surface->flags & SDL_DONTFREE) {
return;
}
if (surface->map != NULL) {
SDL_FreeBlitMap(surface->map);
surface->map = NULL;
}
SDL_InvalidateMap(surface->map);
if (--surface->refcount > 0) {
return;
}