pandory500/SDL-mirror
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

glX HasExtension(): check for NULL ext string first.

Browse source 
It's slightly faster than failing later, after a strchr() call, since this
will get called multiple times with a NULL string if the system totally
fails elsewhere.

--HG--
extra : rebase_source : 72564776aed4ab255a65880e979f8dba4df4a527
This commit is contained in:
Ryan C. Gordon 2015-02-17 22:59:56 -05:00
parent 6c134a60d0
commit 21282ee01f
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/video/x11/SDL_x11opengl.c
View file

@ -279,14 +279,14 @@ HasExtension(const char *extension, const char *extensions)
const char *start; const char *start;
const char *where, *terminator; const char *where, *terminator;
if (!extensions)
return SDL_FALSE;
/* Extension names should not have spaces. */ /* Extension names should not have spaces. */
where = SDL_strchr(extension, ' '); where = SDL_strchr(extension, ' ');
if (where || *extension == '\0') if (where || *extension == '\0')
return SDL_FALSE; return SDL_FALSE;
if (!extensions)
return SDL_FALSE;
/* It takes a bit of care to be fool-proof about parsing the /* It takes a bit of care to be fool-proof about parsing the
* OpenGL extensions string. Don't be fooled by sub-strings, * OpenGL extensions string. Don't be fooled by sub-strings,
* etc. */ * etc. */