pandory500/SDL-mirror
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed bug 3992 - SDL_GetColorKey doesn't set error message

Browse source 
Luke A. Guest

SDL_GetColorKey does not set an error message on failure. The current source just returns -1.

The documentation https://wiki.libsdl.org/SDL_GetColorKey?highlight=%28%5CbCategoryAPI%5Cb%29%7C%28SDLFunctionTemplate%29 says to call SDL_GetError but that is useless in this case.
This commit is contained in:
Sam Lantinga 2017-12-12 16:37:23 -08:00
parent 35623271c9
commit 44e7397995
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/video/SDL_surface.c
View file

@ -296,11 +296,11 @@ int
SDL_GetColorKey(SDL_Surface * surface, Uint32 * key) SDL_GetColorKey(SDL_Surface * surface, Uint32 * key)
{ {
if (!surface) { if (!surface) {
return -1; return SDL_InvalidParamError("surface");
} }
if (!(surface->map->info.flags & SDL_COPY_COLORKEY)) { if (!(surface->map->info.flags & SDL_COPY_COLORKEY)) {
return -1; return SDL_SetError("Surface doesn't have a colorkey");
} }
if (key) { if (key) {