From 467c8a81ddd8215e5c959add50119a85bcb2127a Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Tue, 16 May 2006 03:58:08 +0000 Subject: [PATCH] Date: Mon, 15 May 2006 17:18:34 +0300 From: Vassilis Virvilis Subject: Re: [SDL] SDL + fbcon = weird colors (resolved) > I am getting weird colors in 16/32 bpp in an VIA custom > board with savagefb and in qemu (cirrusfb). Ok looks that nowadays if you follow compiler warnings closely all bugs will be resolved by you. This one was that a non void function (do_mmap) was not returning anything. I also silenced a warning since I was in janitor mode. --HG-- extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401798 --- src/video/fbcon/SDL_fbvideo.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/video/fbcon/SDL_fbvideo.c b/src/video/fbcon/SDL_fbvideo.c index 2f2aac493..2d97bcbeb 100644 --- a/src/video/fbcon/SDL_fbvideo.c +++ b/src/video/fbcon/SDL_fbvideo.c @@ -160,13 +160,14 @@ static void *do_mmap(void *start, size_t length, int prot, int flags, int fd, of ret = mmap(start, length, prot, (flags & ~MAP_SHARED) | MAP_PRIVATE, fd, offset); } + return ret; } /* FB driver bootstrap functions */ static int FB_Available(void) { - int console; + int console = -1; /* Added check for /fb/0 (devfs) */ /* but - use environment variable first... if it fails, still check defaults */ int idx = 0;