pandory500/SDL-mirror
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed bug 2132 - Tests may use invalid SDL_window pointers when windows are closed

Browse source 
norfanin

Some of the tests keep using the pointers of a destroyed SDL_Window when the common event handling handled the close event. The event handler itself does not NULL the pointer after the destruction.

The attached patch adds a loop in the handler that will assign NULL to the destroyed window. It also adds checks to some of the tests so they skip those windows by checking for NULL.
This commit is contained in:
Sam Lantinga 2013-10-05 19:09:03 -07:00
parent 20b394d072
commit 583198f72e
11 changed files with 26 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/test/SDL_test_common.c
View file

@ -1200,6 +1200,12 @@ SDLTest_CommonEvent(SDLTest_CommonState * state, SDL_Event * event, int *done)
SDL_Window *window = SDL_GetWindowFromID(event->window.windowID);
if (window) {
SDL_DestroyWindow(window);
for (i = 0; i < state->num_windows; ++i) {
if (window == state->windows[i]) {
state->windows[i] = NULL;
break;
}
}
}
}
break;