pandory500/SDL-mirror
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ALSA was testing if (format) was set to zero as an error condition, but

Browse source 
SND_PCM_FORMAT_S8 is zero, so you could never open ALSA for AUDIO_S8 data
 before.

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%402056
This commit is contained in:
Ryan C. Gordon 2006-09-01 17:49:27 +00:00
parent 176414e7a2
commit 59f531f6dd
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/audio/alsa/SDL_alsa_audio.c
View file

@ -523,6 +523,7 @@ ALSA_OpenAudio(_THIS, SDL_AudioSpec * spec)
status = -1;
for (test_format = SDL_FirstAudioFormat(spec->format);
test_format && (status < 0);) {
status = 0; /* if we can't support a format, it'll become -1. */
switch (test_format) {
case AUDIO_U8:
format = SND_PCM_FORMAT_U8;
@ -555,10 +556,10 @@ ALSA_OpenAudio(_THIS, SDL_AudioSpec * spec)
format = SND_PCM_FORMAT_FLOAT_BE;
break;
default:
format = 0;
status = -1;
break;
}
if (format != 0) {
if (status >= 0) {
status =
SDL_NAME(snd_pcm_hw_params_set_format) (pcm_handle,
hwparams, format);