pandory500/SDL-mirror
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Windows should use _beginthreadex() instead of CreateThread(), to avoid a

Browse source 
memory leak on each joined thread.

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401228
This commit is contained in:
Ryan C. Gordon 2006-01-04 21:01:49 +00:00
parent 4b43b304ab
commit 72c870cf14
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/thread/win32/SDL_systhread.c
View file

@ -30,13 +30,14 @@ static char rcsid =
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <windows.h> #include <windows.h>
#include <process.h>
#include "SDL_error.h" #include "SDL_error.h"
#include "SDL_thread.h" #include "SDL_thread.h"
#include "SDL_systhread.h" #include "SDL_systhread.h"
static DWORD WINAPI RunThread(LPVOID data) static unsigned __stdcall RunThread(void *data)
{ {
SDL_RunThread(data); SDL_RunThread(data);
return(0); return(0);
@ -44,9 +45,17 @@ static DWORD WINAPI RunThread(LPVOID data)
int SDL_SYS_CreateThread(SDL_Thread *thread, void *args) int SDL_SYS_CreateThread(SDL_Thread *thread, void *args)
{ {
DWORD threadnum; unsigned threadid;
thread->handle = CreateThread(NULL, 0, RunThread, args, 0, &threadnum); /*
* Avoid CreateThread: https://bugzilla.libsdl.org/show_bug.cgi?id=22
*
* have to use _beginthreadex if we want the returned handle
* to be accessible after the thread exits
* threads created with _beginthread auto-close the handle
*/
thread->handle = (SYS_ThreadHandle) _beginthreadex(NULL, 0, RunThread,
args, 0, &threadid);
if (thread->handle == NULL) { if (thread->handle == NULL) {
SDL_SetError("Not enough resources to create thread"); SDL_SetError("Not enough resources to create thread");
return(-1); return(-1);