Removed atexit() from most of the test programs; atexit(SDL_Quit) isn't safe

if SDL is built with a non-cdecl calling convention, and it's just generally
 bad practice anyhow.

Now programs explicitly call SDL_Quit() where appropriate, wrap SDL_Quit() in
 a cdecl function where it can't be avoided, and rely on the parachute where
 a crash might have hit the atexit() before (these ARE test programs, after
 all!).

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%401154
This commit is contained in:
Ryan C. Gordon 2005-09-28 11:36:20 +00:00
parent 004ec06058
commit 91121c3104
20 changed files with 272 additions and 129 deletions

View file

@ -13,6 +13,13 @@
static SDL_sem *sem;
int alive = 1;
/* Call this instead of exit(), so we can clean up SDL: atexit() is evil. */
static void quit(int rc)
{
SDL_Quit();
exit(rc);
}
int ThreadFunc(void *data)
{
while ( alive ) {
@ -39,15 +46,14 @@ int main(int argc, char **argv)
if(argc < 2) {
fprintf(stderr,"Usage: %s init_value\n", argv[0]);
exit(1);
return(1);
}
/* Load the SDL library */
if ( SDL_Init(0) < 0 ) {
fprintf(stderr, "Couldn't initialize SDL: %s\n",SDL_GetError());
exit(1);
return(1);
}
atexit(SDL_Quit);
signal(SIGTERM, killed);
signal(SIGINT, killed);
@ -72,5 +78,6 @@ int main(int argc, char **argv)
printf("Finished waiting for threads\n");
SDL_DestroySemaphore(sem);
SDL_Quit();
return(0);
}