pandory500/SDL-mirror
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed bug #570

Browse source 
SDL_SemWaitTimeout in src/thread/generic/SDL_syssem.c line 179 (SVN trunk):

--sem->count;

should be

if (retval == 0) {
    --sem->count;
}

Without this, sem->count will underflow on timeout effectively breaking the
semaphore. It appears that the implementation has been wrong since the initial
revision.

--HG--
extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%403844
This commit is contained in:
Sam Lantinga 2009-09-21 07:35:06 +00:00
parent d4c2904707
commit be2cfc6afd
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/thread/generic/SDL_syssem.c
View file

@ -176,7 +176,9 @@ SDL_SemWaitTimeout(SDL_sem * sem, Uint32 timeout)
sem->count_lock, timeout); sem->count_lock, timeout);
} }
--sem->waiters_count; --sem->waiters_count;
--sem->count; if (retval == 0) {
--sem->count;
}
SDL_UnlockMutex(sem->count_lock); SDL_UnlockMutex(sem->count_lock);
return retval; return retval;