pandory500/SDL-mirror
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed typo in mask comparison

Browse source 
Bl0ckeduser

I downloaded the SDL 1.2.15 prerelease and compiled it (under Mac OS
Classic). All the tests worked without issues, but the compiler gave
this warning [formatting edited for email format]:

    } else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {

":src:video:SDL_video.c"; line 990 #Warning 2: possible unintended assignment

I discussed this with another programmer and we came to the conclusion
that this is probably a typo.

I have checked the latest mercurial sources, and the possible typo is
still there.

Bl0ckeduser

--HG--
branch : SDL-1.2
This commit is contained in:
Sam Lantinga 2012-01-10 22:52:17 -05:00
parent f2adec4ba6
commit c5dfc3ea64
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/video/SDL_video.c
View file

@ -987,7 +987,7 @@ SDL_Surface *SDL_DisplayFormatAlpha(SDL_Surface *surface)
if ( (vf->Rmask == 0xff) && (vf->Bmask == 0xff0000) ) {
rmask = 0xff;
bmask = 0xff0000;
} else if ( vf->Rmask == 0xFF00 && (vf->Bmask = 0xFF000000) ) {
} else if ( vf->Rmask == 0xFF00 && (vf->Bmask == 0xFF000000) ) {
amask = 0x000000FF;
rmask = 0x0000FF00;
gmask = 0x00FF0000;