From de93e295ce5f26af731828b6cfb0703430be828d Mon Sep 17 00:00:00 2001 From: Sam Lantinga Date: Sat, 7 Jan 2012 01:21:50 -0500 Subject: [PATCH] Fixed bug 1239 - Crash in iPad with iOS 3.2 because of missing contentScaleFactor support MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Joseba García Echebarria 2011-06-30 19:03:56 PDT I just found that SDL is crashing in the iPad simulator for iOS 3.2 but not for iOS 4.2 or over when compiling with Xcode 4.0.2. The Xcode debugger points to line 127 in video/uikit/SDL_uikitopenglview.m as the line that triggers the crash. On those lines one can find: /* Use the main screen scale (for retina display support) */ if ([[UIScreen mainScreen] respondsToSelector:@selector(scale)]) self.contentScaleFactor = [UIScreen mainScreen].scale; I believe the problem to be that the "scale" selector is supported in iOS 3.2 in the iPad, but contentScaleFactor is not. I'm no expert in Objective-C, but I believe the following code to be more correct (it doesn't crash for me): /* Use the main screen scale (for retina display support) */ if ([[UIScreen mainScreen] respondsToSelector:@selector(scale)] && [self respondsToSelector:@selector(contentScaleFactor)]) self.contentScaleFactor = [UIScreen mainScreen].scale; The same check is being performed in line 155 so I imagine it will crash there, too. Vittorio Giovara 2011-08-22 17:58:20 PDT yeah, -scale was introduced in 3.2 but made available only in 4.0, weird anyways we just need to check against contentScaleFactor as we can be sure that both are availble starting from 4.0 the attached patch addresses this --- src/video/uikit/SDL_uikitopenglview.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/video/uikit/SDL_uikitopenglview.m b/src/video/uikit/SDL_uikitopenglview.m index 28411a9e2..e34330ca1 100755 --- a/src/video/uikit/SDL_uikitopenglview.m +++ b/src/video/uikit/SDL_uikitopenglview.m @@ -80,7 +80,7 @@ // !!! FIXME: use the screen this is on! /* Use the main screen scale (for retina display support) */ - if ([[UIScreen mainScreen] respondsToSelector:@selector(scale)]) + if ([self respondsToSelector:@selector(contentScaleFactor)]) self.contentScaleFactor = [UIScreen mainScreen].scale; /* create the buffers */