No description
605f1db186
From: John Bartholomew Subject: [SDL] SDL Semaphore implementation broken on Windows? Hi, Over the past couple of days, I've been battling with SDL, SDL_Mixer and SMPEG to try to find an audio hang bug. I believe I've found the problem, which I think is a race condition inside SDL's semaphore implementation (at least the Windows implementation). The semaphore code uses Windows' built in semaphore functions, but it also maintains a separate count value. This count value is updated with bare increment and decrement operations in SemPost and SemWaitTimeout - no locking primitives to protect them. In tracking down the apparent audio bug, I found that at some point a semaphore's count value was being decremented to -1, which is clearly not a valid value for it to take. I'm still not certain exactly what sequence of operations is occuring for this to happen, but I believe that overall it's a race condition between a thread calling SemPost (which increments the count) and the thread on the other end calling SemWait (which decrements it). I will try to make a test case to verify this, but I'm not sure if I'll be able to (threading errors being difficult to reproduce even in the best circumstances). However, assuming this is the cause of my problems, there is a very simple fix: Windows provides InterlockedIncrement() and InterlockedDecrement() functions to perform increments and decrements which are guaranteed to be atomic. So the fix is in thread/win32/SDL_syssem.c: replace occurrences of --sem->count with InterlockedDecrement(&sem->count); and replace occurrences of ++sem->count with InterlockedIncrement(&sem->count); This is using SDL v1.2.12, built with VC++ 2008 Express, running on a Core 2 duo processor. --HG-- extra : convert_revision : svn%3Ac70aab31-4412-0410-b14c-859654838e24/trunk%403535 |
||
|---|---|---|
| build-scripts | ||
| docs | ||
| include | ||
| src | ||
| test | ||
| VisualC | ||
| VisualCE | ||
| Xcode | ||
| XCodeiPhoneOS | ||
| .indent.pro | ||
| acinclude.m4 | ||
| autogen.sh | ||
| Borland.html | ||
| Borland.zip | ||
| BUGS | ||
| configure.in | ||
| COPYING | ||
| CREDITS | ||
| docs.html | ||
| INSTALL | ||
| Makefile.dc | ||
| Makefile.ds | ||
| Makefile.in | ||
| Makefile.minimal | ||
| NOTES | ||
| README | ||
| README-SDL.txt | ||
| README.BeOS | ||
| README.CVS | ||
| README.DC | ||
| README.DirectFB | ||
| README.iphoneos | ||
| README.MacOSX | ||
| README.MiNT | ||
| README.NanoX | ||
| README.OS2 | ||
| README.Porting | ||
| README.QNX | ||
| README.RISCOS | ||
| README.SVN | ||
| README.Watcom | ||
| README.WinCE | ||
| README.wscons | ||
| sdl-config.in | ||
| sdl.m4 | ||
| sdl.pc.in | ||
| SDL.qpg.in | ||
| SDL.spec.in | ||
| TODO | ||
| UNDER_CONSTRUCTION.txt | ||
| VisualC.html | ||
| Watcom-OS2.zip | ||
| Watcom-Win32.zip | ||
| WhatsNew | ||
Simple DirectMedia Layer
(SDL)
Version 1.2
---
http://www.libsdl.org/
This is the Simple DirectMedia Layer, a general API that provides low
level access to audio, keyboard, mouse, joystick, 3D hardware via OpenGL,
and 2D framebuffer across multiple platforms.
The current version supports Linux, Windows, Windows CE, BeOS, MacOS,
Mac OS X, FreeBSD, NetBSD, OpenBSD, BSD/OS, Solaris, IRIX, and QNX.
The code contains support for Dreamcast, Atari, AIX, OSF/Tru64,
RISC OS, SymbianOS, and OS/2, but these are not officially supported.
SDL is written in C, but works with C++ natively, and has bindings to
several other languages, including Ada, C#, Eiffel, Erlang, Euphoria,
Guile, Haskell, Java, Lisp, Lua, ML, Objective C, Pascal, Perl, PHP,
Pike, Pliant, Python, Ruby, and Smalltalk.
This library is distributed under GNU LGPL version 2, which can be
found in the file "COPYING". This license allows you to use SDL
freely in commercial programs as long as you link with the dynamic
library.
The best way to learn how to use SDL is to check out the header files in
the "include" subdirectory and the programs in the "test" subdirectory.
The header files and test programs are well commented and always up to date.
More documentation is available in HTML format in "docs/index.html", and
a documentation wiki is available online at:
http://www.libsdl.org/cgi/docwiki.cgi
The test programs in the "test" subdirectory are in the public domain.
Frequently asked questions are answered online:
http://www.libsdl.org/faq.php
If you need help with the library, or just want to discuss SDL related
issues, you can join the developers mailing list:
http://www.libsdl.org/mailing-list.php
Enjoy!
Sam Lantinga (slouken@libsdl.org)