SDL-mirror/src
Sam Lantinga a63126c72b Fixed bug 4184 - jack audio driver fails in presence of midi ports
Martin Širokov

Launching an SDL application with SDL_AUDIODRIVER=jack, and then calling SDL_OpenAudioDevice() with whatever parameters fails with an error like this one:

SDL_OpenAudioDevice: Couldn't connect JACK ports: SDL:sdl_jack_output_0 => system:midi_playback_1

This happens because JACK_OpenDevice in src/audio/jack/SDL_jackaudio.c blindly tries to connect to all input ports without checking whether they are for audio or midi.

The fix is to check port types and ignore all non audio ports. Also I removed devports field from struct SDL_PrivateAudioData, because it's never really used and removing unused ports from it would be PITA.
2018-06-01 19:43:53 -07:00
..
atomic Updated copyright for 2018 2018-01-03 10:03:25 -08:00
audio Fixed bug 4184 - jack audio driver fails in presence of midi ports 2018-06-01 19:43:53 -07:00
core Reimplemented Android cursor API support using reflection so it builds with older SDKs 2018-03-16 11:08:53 -07:00
cpuinfo cpuinfo: Added SDL_HasAVX512F(). 2018-05-21 11:35:42 -04:00
dynapi cpuinfo: Added SDL_HasAVX512F(). 2018-05-21 11:35:42 -04:00
events Fixed building on platforms without __sighandler_t 2018-01-30 18:12:25 -08:00
file Updated copyright for 2018 2018-01-03 10:03:25 -08:00
filesystem revert the recent typecast assignment changes (see bug #4079) 2018-02-12 17:00:00 +03:00
haptic Updated copyright for 2018 2018-01-03 10:03:25 -08:00
joystick Added a new GUID for DS3 controller connected over bluetooth, for both Sony and Shanwan (thanks William!) 2018-05-29 08:03:44 -07:00
libm Fixed misleading indentation 2018-01-30 16:53:24 -08:00
loadso Updated copyright for 2018 2018-01-03 10:03:25 -08:00
main Fixed bug 4073 - Unquoted Unicode argument parsing broken on Windows due to incorrect usage of SDL_isspace() 2018-02-10 12:43:11 -08:00
power Handle NULL return from SDL_DBus_GetContext() 2018-04-23 20:24:12 -07:00
render do the direct3d tap dance for overscan hint only if SDL_VIDEO_RENDER_D3D == 1 2018-05-10 08:25:23 +03:00
stdlib make sure SDL_vsnprintf() nul terminates if it is using _vsnprintf 2018-05-10 09:02:39 +03:00
test SDL_test_fuzzer.c: fix strict aliasing warnings by using a union. 2018-02-25 10:15:00 +03:00
thread thread: fixed compiler warnings on non-Linux systems that use pthread. 2018-05-21 12:00:21 -04:00
timer Updated copyright for 2018 2018-01-03 10:03:25 -08:00
video metal: contrary to documentation, we need to set the drawableSize explicitly. 2018-05-27 20:30:03 -04:00
SDL.c Fixed bug 4034 - Don't include _DllMainCRTStartup() if SDL_STATIC_LIB is defined. 2018-02-21 09:40:47 -08:00
SDL_assert.c Progress fixing bug 4100 - errors and warnings after changeset 11917 2018-03-02 22:53:25 -08:00
SDL_assert_c.h Updated copyright for 2018 2018-01-03 10:03:25 -08:00
SDL_dataqueue.c Updated copyright for 2018 2018-01-03 10:03:25 -08:00
SDL_dataqueue.h Updated copyright for 2018 2018-01-03 10:03:25 -08:00
SDL_error.c Updated copyright for 2018 2018-01-03 10:03:25 -08:00
SDL_error_c.h Updated copyright for 2018 2018-01-03 10:03:25 -08:00
SDL_hints.c Updated copyright for 2018 2018-01-03 10:03:25 -08:00
SDL_internal.h Updated copyright for 2018 2018-01-03 10:03:25 -08:00
SDL_log.c Updated copyright for 2018 2018-01-03 10:03:25 -08:00