No description
The patch Mark attached looks good and valgrind gives it a clean bill of health: Mark.Howson@ntu.ac.uk 2010-12-15 07:45:25 PST Reproducible here under Windows and Linux. Looking at the code for SDL_Upsample_S16LSB_2c: const int dstsize = (int) (((double)cvt->len_cvt) * cvt->rate_incr); Sint16 *dst = ((Sint16 *) (cvt->buf + dstsize)) - 2; const Sint16 *target = ((const Sint16 *) cvt->buf) - 2; while (dst > target) { dst[1] = ((Sint16) SDL_SwapLE16(sample1)); dst[0] = ((Sint16) SDL_SwapLE16(sample0)); dst -= 2; ... if dstsize is odd (and therefore dst), it'll write to target[1] which is one byte before the allocated buf. The attached patch to sdlgenaudiocvt.pl changes dst > target to dst >= target, and removes the - $channels for the upsample case. The patch is not fully tested, but seems to work here. |
||
---|---|---|
acinclude | ||
android-project | ||
build-scripts | ||
include | ||
src | ||
test | ||
VisualC | ||
Xcode | ||
Xcode-iOS | ||
.DISABLED-hgeol | ||
.hgignore | ||
.hgtags | ||
.indent.pro | ||
aclocal.m4 | ||
Android.mk | ||
autogen.sh | ||
Borland.html | ||
Borland.zip | ||
BUGS | ||
configure | ||
configure.in | ||
COPYING | ||
CREDITS | ||
INSTALL | ||
Makefile.ds | ||
Makefile.in | ||
Makefile.minimal | ||
Makefile.pandora | ||
Makefile.wiz | ||
NOTES | ||
README | ||
README-SDL.txt | ||
README.android | ||
README.BeOS | ||
README.DirectFB | ||
README.ds | ||
README.gesture | ||
README.HG | ||
README.iOS | ||
README.MacOSX | ||
README.pandora | ||
README.Platforms | ||
README.Porting | ||
README.touch | ||
README.Watcom | ||
README.WinCE | ||
sdl-config.in | ||
sdl.m4 | ||
sdl.pc.in | ||
SDL.spec.in | ||
TODO | ||
UNDER_CONSTRUCTION.txt | ||
VisualC.html | ||
Watcom-Win32.zip | ||
WhatsNew |
Simple DirectMedia Layer (SDL) Version 1.3 --- http://www.libsdl.org/ This is the Simple DirectMedia Layer, a general API that provides low level access to audio, keyboard, mouse, joystick, 3D hardware via OpenGL, and 2D framebuffer across multiple platforms. The current version supports Windows, Windows CE, Mac OS X, Linux, FreeBSD, NetBSD, OpenBSD, BSD/OS, Solaris, iOS, and Android. The code contains support for other operating systems but those are not officially supported. SDL is written in C, but works with C++ natively, and has bindings to several other languages, including Ada, C#, Eiffel, Erlang, Euphoria, Go, Guile, Haskell, Java, Lisp, Lua, ML, Objective C, Pascal, Perl, PHP, Pike, Pliant, Python, Ruby, and Smalltalk. This library is distributed under the zlib license, which can be found in the file "COPYING". The best way to learn how to use SDL is to check out the header files in the "include" subdirectory and the programs in the "test" subdirectory. The header files and test programs are well commented and always up to date. More documentation is available in HTML format in "docs/index.html", and a documentation wiki is available online at: http://www.libsdl.org/cgi/docwiki.cgi The test programs in the "test" subdirectory are in the public domain. Frequently asked questions are answered online: http://www.libsdl.org/faq.php If you need help with the library, or just want to discuss SDL related issues, you can join the developers mailing list: http://www.libsdl.org/mailing-list.php Enjoy! Sam Lantinga (slouken@libsdl.org)