Increase path/file related buffers to system limits instead of hardcoded values (#85)

src/include/gui.h

@@ -65,7 +65,7 @@ struct gui_info
 	int fps, idle;
 	int fps_color;
 	int sndbuf, sndbuf_status;
-	TCHAR df[4][256];		    /* inserted image */
+	TCHAR df[4][MAX_PATH];		    /* inserted image */
 	uae_u32 crc32[4];		    /* crc32 of image */
 };
 #define NUM_LEDS (LED_MAX)

src/include/uae.h

@@ -41,7 +41,7 @@ extern uae_u32 getlocaltime (void);
 
 extern int quit_program;
 
-extern TCHAR start_path_data[256];
+extern TCHAR start_path_data[MAX_DPATH];
 
 /* This structure is used to define menus. The val field can hold key
  * shortcuts, or one of these special codes:

src/main.cpp

@@ -68,7 +68,7 @@ struct gui_info gui_data;
 
 TCHAR warning_buffer[256];
 
-TCHAR optionsfile[256];
+TCHAR optionsfile[MAX_PATH];
 
 static uae_u32 randseed;
 static int oldhcounter;

src/osdep/amiberry_gfx.cpp

@@ -31,7 +31,7 @@ struct MultiDisplay Displays[MAX_DISPLAYS];
 int screen_is_picasso = 0;
 
 static SDL_Surface* current_screenshot = nullptr;
-static char screenshot_filename_default[255] =
+static char screenshot_filename_default[MAX_PATH] =
 {
 	'/', 't', 'm', 'p', '/', 'n', 'u', 'l', 'l', '.', 'p', 'n', 'g', '\0'
 };

src/osdep/gui/PanelConfig.cpp

@@ -169,7 +169,7 @@ public:
 			//-----------------------------------------------
 			// Delete selected config
 			//-----------------------------------------------
-			char msg[256];
+			char msg[MAX_PATH];
 			i = lstConfigs->getSelected();
 			if (i >= 0 && ConfigFilesList[i]->BuiltInID == BUILTINID_NONE && strcmp(ConfigFilesList[i]->Name, OPTIONSFILENAME))
 			{

src/osdep/gui/SelectFile.cpp

@@ -162,7 +162,7 @@ public:
 	void action(const gcn::ActionEvent& actionEvent) override
 	{
 		int selected_item;
-		char foldername[256] = "";
+		char foldername[MAX_PATH] = "";
 
 		selected_item = lstFiles->getSelected();
 		strcpy(foldername, workingDir);

src/osdep/gui/SelectFolder.cpp

@@ -103,7 +103,7 @@ public:
 	void action(const gcn::ActionEvent& actionEvent) override
 	{
 		int selected_item;
-		char foldername[256] = "";
+		char foldername[MAX_PATH] = "";
 
 		selected_item = lstFolders->getSelected();
 		strcpy(foldername, workingDir);

src/osdep/menu/menu_config.cpp

@@ -125,7 +125,7 @@ int loadconfig_old(struct uae_prefs* p, const char* orgpath)
 	default_prefs(p, 0);
 	SetDefaultMenuSettings(p);
 
-	char filebuffer[256];
+	char filebuffer[MAX_PATH];
 	int dummy;
 
 	fscanf(f, "kickstart=%d\n", &kickstart);

src/osdep/sysconfig.h

@@ -1,6 +1,14 @@
 
+#pragma once
 #define SUPPORT_THREADS
-#define MAX_DPATH 256
+
+#define MAX_DPATH 1000
+
+#include <limits.h>
+
+#ifndef MAX_PATH
+#define MAX_PATH PATH_MAX
+#endif
 
 /* #define DRIVESOUND */
 /* #define GFXFILTER */
@@ -455,10 +463,6 @@
 #define A_DMS
 #define A_WRP
 
-#ifndef MAX_PATH
-#define MAX_PATH 256
-#endif
-
 #define WORDS_BIGENDIAN 1
 
 #define M68K_SPEED_7MHZ_CYCLES 0