From 5042b7bae4d4822a895ea9d27b44d24ab2bebe51 Mon Sep 17 00:00:00 2001 From: Dimitris Panokostas Date: Thu, 21 Sep 2017 17:48:13 +0200 Subject: [PATCH] Fix potential overflow when reading very long Controller ID string --- src/osdep/pandora_input.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/osdep/pandora_input.cpp b/src/osdep/pandora_input.cpp index d6d2e2ac..47bd446d 100644 --- a/src/osdep/pandora_input.cpp +++ b/src/osdep/pandora_input.cpp @@ -296,7 +296,7 @@ static int init_joystick(void) for (int cpt; cpt < nr_joysticks; cpt++) { Joysticktable[cpt] = SDL_JoystickOpen(cpt); - strncpy(JoystickName[cpt], SDL_JoystickName(cpt), 80); + strncpy(JoystickName[cpt], SDL_JoystickName(cpt), sizeof JoystickName[cpt]); printf("Joystick %i : %s\n", cpt, JoystickName[cpt]); printf(" Buttons: %i Axis: %i Hats: %i\n", SDL_JoystickNumButtons(Joysticktable[cpt]), SDL_JoystickNumAxes(Joysticktable[cpt]), SDL_JoystickNumHats(Joysticktable[cpt]));