pandory500/redquark-amiberry-rb
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix more potential buffer overflows in paths #92

Browse source
This commit is contained in:
Dimitris Panokostas 2017-04-21 22:27:47 +02:00
parent 91e2dac3d9
commit a853165ca8
16 changed files with 128 additions and 128 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/osdep/gui/PanelHD.cpp
View file

@ -240,13 +240,13 @@ public:
char tmp[MAX_DPATH];
if (strlen(changed_prefs.cdslots[0].name) > 0)
strncpy(tmp, changed_prefs.cdslots[0].name, MAX_DPATH);
strncpy(tmp, changed_prefs.cdslots[0].name, sizeof tmp);
else
strncpy(tmp, currentDir, MAX_DPATH);
strncpy(tmp, currentDir, sizeof tmp);
if (SelectFile("Select CD image file", tmp, cdfile_filter))
{
if (strncmp(changed_prefs.cdslots[0].name, tmp, MAX_DPATH))
if (strncmp(changed_prefs.cdslots[0].name, tmp, sizeof changed_prefs.cdslots[0].name))
{
strncpy(changed_prefs.cdslots[0].name, tmp, sizeof(changed_prefs.cdslots[0].name));
changed_prefs.cdslots[0].inuse = true;