thirdparty/dosbox-staging
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2
dosbox-staging/meson.build

503 lines
16 KiB
Meson
Raw Normal View History

Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
project('dosbox-staging', 'c', 'cpp',
Bump v0.78.0 version strings to v0.79.0
2021-12-25 09:08:39 -08:00
version : '0.79.0',
Use conservative FluidSynth build defaults This commit uses 32-bit float and avoids internally threading FluidSynth voices (and using openMP), as 64-bit samples and voice-threading and voice-threading are simply unecessary for performance and the precision demands of 24 parallel mixed voices of General MIDI. DOSBox Staging already threads FluidSynth as as whole, and performance is acceptable on decade-old hardware such as a core2duo and Pi2. (Context: 64-bit and OpenMP /are/ useful when mixing demands climb into the hundreds or thousands of parallel voices, but this isn't General MIDI, which limited to 24 voices).
2021-12-12 10:58:28 -08:00
license : 'GPL-2.0-or-later',
meson_version : '>= 0.54.2',
default_options : [
'cpp_std=c++17',
'warning_level=3',
'b_ndebug=if-release',
'b_staticpic=false',
'fluidsynth:enable-floats=true',
'fluidsynth:openmp=disabled',
'fluidsynth:enable-threads=false',
'fluidsynth:try-static-deps=false',
'fluidsynth:warning_level=0',
'glib:glib_assert=false',
'glib:glib_checks=false',
'glib:glib_debug=disabled',
'glib:libmount=disabled',
Hide brew's dynamic libintl from glib on macOS
2021-12-14 18:09:46 -08:00
'glib:libelf=disabled',
Use conservative FluidSynth build defaults This commit uses 32-bit float and avoids internally threading FluidSynth voices (and using openMP), as 64-bit samples and voice-threading and voice-threading are simply unecessary for performance and the precision demands of 24 parallel mixed voices of General MIDI. DOSBox Staging already threads FluidSynth as as whole, and performance is acceptable on decade-old hardware such as a core2duo and Pi2. (Context: 64-bit and OpenMP /are/ useful when mixing demands climb into the hundreds or thousands of parallel voices, but this isn't General MIDI, which limited to 24 voices).
2021-12-12 10:58:28 -08:00
'glib:nls=disabled',
'glib:tests=false',
'glib:warning_level=0',
'glib:xattr=false',
'gtest:warning_level=0',
'mt32emu:warning_level=0',
'slirp:warning_level=0',
]
)
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
Document list of buildsystem improvements We try to keep the compatibility with older meson versions to have wide support amongst Linux distributions, but it means some improvements need to wait until newer meson is widely available.
2021-02-06 18:06:49 +01:00
# After increasing the minimum-required meson version, make the following
# improvements:
#
Add mt32emu dependency with meson wrap fallback Add new option (use_mt32emu), to allow users to opt-out of this dependency if necessary. Aside of Meson WrapDB fallback, treat it as any other dependency.
2021-02-09 13:42:30 +01:00
# - 0.55.0 - subproject wraps are automatically promoted to fallbacks,
# stop using: "fallback : ['foo', 'foo_dep']" for dependencies
Document list of buildsystem improvements We try to keep the compatibility with older meson versions to have wide support amongst Linux distributions, but it means some improvements need to wait until newer meson is widely available.
2021-02-06 18:06:49 +01:00
# - 0.56.0 - use meson.current_source_dir() in unit tests
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
cc = meson.get_compiler('c')
cxx = meson.get_compiler('cpp')
Apply stdlibs and fPIC flags in meson
2021-12-12 11:27:58 -08:00
prefers_static_libs = (get_option('default_library') == 'static')
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
Use Meson summary function Since we upgraded to meson > 0.53, we can use summary to highlight some information important during build. This is way more readable than using message function for the same purpose.
2021-10-03 22:29:24 +02:00
summary('Build type', get_option('buildtype'), section : 'Build Summary')
summary('Install prefix', get_option('prefix'), section : 'Build Summary')
Add the ghc::filesystem to the build system
2021-12-30 09:30:34 -08:00
# extra compiler flags
Ask compilers to ignore unknown pragmas
2022-05-08 07:08:07 -07:00
extra_flags = ['-Wno-unknown-pragmas']
Add the ghc::filesystem to the build system
2021-12-30 09:30:34 -08:00
# If the compiler provides std::filesystem, then we consider it modern enough
# that we can trust it's extra helpful warnings to let us improve the code quality.
if cxx.has_header('filesystem')
extra_flags += ['-Wmaybe-uninitialized', '-Weffc++', '-Wextra-semi']
else
# Otherwise, it's an old compiler and we're just trying to build, and don't
# care about fixing their warnings (some generate warnings from their own STL).
warning('Compiler lacks the C++17 std::filesystem - try to upgrade your compiler!')
endif
Add '-Wno-pedantic-ms-format' on all supporting windows compilers
2021-12-12 15:37:44 +13:00
if host_machine.system() == 'windows'
extra_flags += '-Wno-pedantic-ms-format'
endif
Apply stdlibs and fPIC flags in meson
2021-12-12 11:27:58 -08:00
if prefers_static_libs
extra_flags += ['-static-libstdc++', '-static-libgcc']
else
extra_flags += ['-shared-libstdc++', '-shared-libgcc', '-fPIC']
endif
Add '-Wno-pedantic-ms-format' on all supporting windows compilers
2021-12-12 15:37:44 +13:00
foreach flag : extra_flags
if cc.has_argument(flag)
add_project_arguments(flag, language : 'c')
endif
if cxx.has_argument(flag)
add_project_arguments(flag, language : 'cpp')
Add uninitialized warnings to meson
2021-11-02 13:17:37 -07:00
endif
endforeach
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
Handle dynrec defines depending on host architecture There are 5 defines directly related to the dynamic core feature: C_TARGETCPU, C_DYNREC, C_DYNAMIC_X86, C_UNALIGNED_MEMORY, and WORDS_BIGENDIAN. This commit coverts the first 4.
2020-12-20 11:38:00 +01:00
# gather data for config file
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
#
Move cpu-related build defines to src/cpu subdir
2021-01-12 20:45:49 +01:00
# Actual config.h file will be generated after all interpreting build files
# for all subdirs.
#
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
conf_data = configuration_data()
conf_data.set('version', meson.project_version())
Port OS defines to meson buildsystem This allows us to finally enable C_DIRECTSERIAL, and even without adding more configuration to the buildsystem.
2021-01-04 23:54:37 +01:00
Simplify mapping of OS names to defines
2021-02-07 22:17:05 +01:00
os_family_name = {
'linux' : 'LINUX',
'windows' : 'WIN32',
'cygwin' : 'WIN32',
'darwin' : 'MACOSX',
'freebsd' : 'BSD',
'netbsd' : 'BSD',
'openbsd' : 'BSD',
'dragonfly' : 'BSD',
}.get(host_machine.system(), 'UNKNOWN_OS')
conf_data.set(os_family_name, 1)
Port OS defines to meson buildsystem This allows us to finally enable C_DIRECTSERIAL, and even without adding more configuration to the buildsystem.
2021-01-04 23:54:37 +01:00
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
conf_data.set10('C_MODEM', get_option('use_sdl2_net'))
conf_data.set10('C_IPX', get_option('use_sdl2_net'))
Address slirp PR review feedback
2021-12-02 12:19:25 -08:00
conf_data.set10('C_SLIRP', get_option('use_slirp'))
conf_data.set10('C_NE2000', get_option('use_slirp'))
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
conf_data.set10('C_OPENGL', get_option('use_opengl'))
conf_data.set10('C_FLUIDSYNTH', get_option('use_fluidsynth'))
Add mt32emu dependency with meson wrap fallback Add new option (use_mt32emu), to allow users to opt-out of this dependency if necessary. Aside of Meson WrapDB fallback, treat it as any other dependency.
2021-02-09 13:42:30 +01:00
conf_data.set10('C_MT32EMU', get_option('use_mt32emu'))
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
conf_data.set10('C_SSHOT', get_option('use_png'))
Move cpu-related build defines to src/cpu subdir
2021-01-12 20:45:49 +01:00
conf_data.set10('C_FPU', true)
Upgrade minimum meson version to 0.49.0 As of early 2021, meson 0.49.x is packaged by Debian Stable and almost all other up-to-date repositories. Notably, it's missing from Ubuntu 18.04 (which uses meson 0.45.2).
2021-02-06 18:58:02 +01:00
conf_data.set10('C_FPU_X86', host_machine.cpu_family() in ['x86', 'x86_64'])
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
Update to use new define names
2021-01-14 21:53:42 +01:00
if get_option('enable_debugger') != 'none'
conf_data.set10('C_DEBUG', true)
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
endif
Update to use new define names
2021-01-14 21:53:42 +01:00
if get_option('enable_debugger') == 'heavy'
conf_data.set10('C_HEAVY_DEBUG', true)
Port C_HAVE_MPROTECT define This define will be removed, once the W^X memory protection will be implemented, but as for now we still need it.
2021-01-12 22:14:51 +01:00
endif
Move C_DIRECTSERIAL check to meson This makes the generated config.h file devoid of any preprocessor logic. We only have defines in there and nothing more.
2021-01-21 16:18:40 +01:00
foreach osdef : ['LINUX', 'WIN32', 'MACOSX', 'BSD']
if conf_data.has(osdef)
conf_data.set10('C_DIRECTSERIAL', true)
endif
endforeach
Update to use new define names
2021-01-14 21:53:42 +01:00
if cc.has_function('clock_gettime', prefix : '#include <time.h>')
conf_data.set10('HAVE_CLOCK_GETTIME', true)
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
endif
Dynamic core support for W^X systems
2021-06-01 09:02:39 -05:00
if cc.has_function('__builtin_available')
conf_data.set10('HAVE_BUILTIN_AVAILABLE', true)
endif
Define and prefer HAVE_BUILTIN_CLEAR_CACHE in meson.build
2021-08-16 12:23:27 -05:00
if cc.has_function('__builtin___clear_cache')
conf_data.set10('HAVE_BUILTIN_CLEAR_CACHE', true)
endif
Update to use new define names
2021-01-14 21:53:42 +01:00
if cc.has_function('mprotect', prefix : '#include <sys/mman.h>')
conf_data.set10('HAVE_MPROTECT', true)
Add debugger feature to meson buildsystem Raise warning limit on Linux, as GCC understands -Wextra-semi now. Add build with debugger enabled on macOS to cover the code with Clang.
2020-12-17 07:15:53 +01:00
endif
Dynamic core support for W^X systems
2021-06-01 09:02:39 -05:00
if cc.has_function('mmap', prefix : '#include <sys/mman.h>')
conf_data.set10('HAVE_MMAP', true)
endif
if cc.has_header_symbol('sys/mman.h', 'MAP_JIT')
conf_data.set10('HAVE_MAP_JIT', true)
endif
if cc.has_function('pthread_jit_write_protect_np', prefix : '#include <pthread.h>')
conf_data.set10('HAVE_PTHREAD_WRITE_PROTECT_NP', true)
endif
if cc.has_function('sys_icache_invalidate', prefix : '#include <libkern/OSCacheControl.h>')
conf_data.set10('HAVE_SYS_ICACHE_INVALIDATE', true)
endif
Add informational-only support for naming std::threads
2021-01-03 22:30:19 -08:00
if cxx.has_function('pthread_setname_np', prefix : '#include <pthread.h>',
dependencies : dependency('threads'))
conf_data.set10('HAVE_PTHREAD_SETNAME_NP', true)
endif
Check for availability of realpath function via meson
2021-01-04 21:32:03 +01:00
if cc.has_function('realpath', prefix : '#include <stdlib.h>')
conf_data.set10('HAVE_REALPATH', true)
endif
Update to use new define names
2021-01-14 21:53:42 +01:00
if cc.has_member('struct dirent', 'd_type', prefix : '#include <dirent.h>')
conf_data.set10('HAVE_STRUCT_DIRENT_D_TYPE', true)
Add debugger feature to meson buildsystem Raise warning limit on Linux, as GCC understands -Wextra-semi now. Add build with debugger enabled on macOS to cover the code with Clang.
2020-12-17 07:15:53 +01:00
endif
Ensure sys/socket.h has necessary functions
2021-12-02 08:26:58 -08:00
foreach header : ['pwd.h', 'strings.h', 'netinet/in.h']
Replace explicit checks for headers with a loop
2021-01-14 22:35:18 +01:00
if cc.has_header(header)
conf_data.set('HAVE_' + header.underscorify().to_upper(), 1)
endif
endforeach
Add meson checks for several headers In C++17 we'll be able to replace these with __has_include, but it's more likely we'll be able to get rid of them altogether - they are mostly used as synonym for "not windows". Several headers are hardcoded to be always available in config template - that's because they were missing in old VS versions, but are available nowadays.
2021-01-04 21:57:58 +01:00
Ensure sys/socket.h has necessary functions
2021-12-02 08:26:58 -08:00
# Check for the actual calls we need in socket.h, because some systems
# have socket.h but are missing some calls.
if cc.has_header('sys/socket.h')
if cc.has_function('getpeername', prefix : '#include <sys/socket.h>') and \
cc.has_function('getsockname', prefix : '#include <sys/socket.h>')
conf_data.set10('HAVE_SYS_SOCKET_H', true)
endif
endif
Port NOMINMAX define to meson To prevent windows.h from introducing min and max macros that break C++ functions std::min, std::max.
2021-01-21 16:33:25 +01:00
# Header windows.h defines old min/max macros, that conflict with C++11
# std::min/std::max. Defining NOMINMAX prevents these macros from appearing.
if cxx.get_id() == 'msvc'
conf_data.set('NOMINMAX', true)
endif
Upgrade minimum meson version to 0.49.0 As of early 2021, meson 0.49.x is packaged by Debian Stable and almost all other up-to-date repositories. Notably, it's missing from Ubuntu 18.04 (which uses meson 0.45.2).
2021-02-06 18:58:02 +01:00
if host_machine.system() in ['windows', 'cygwin']
Enable math constants in math.h header on Windows These are required for constants such as M_PI, M_E, or M_LN10.
2021-01-21 22:49:07 +01:00
conf_data.set('_USE_MATH_DEFINES', true)
endif
Define endianness via meson
2020-12-23 07:51:26 +01:00
if host_machine.endian() == 'big'
conf_data.set('WORDS_BIGENDIAN', 1)
endif
Port PAGESIZE define for PPC64LE to meson
2021-01-12 22:00:50 +01:00
# Non-4K memory page size is supported only for ppc64 at the moment.
Disable PPC and PPC64 dynrec backends for now Upstream SVN r4424 started refactorization of cpu module, and it breaks those backends; to be re-enabled once refactorization is done or when we'll have time to fix it ourselves.
2021-02-16 12:09:11 +01:00
# TODO re-enable ppc dynrec while working on W^X stuff
# disabled because SVN r4424 broke compilation of ppc backends
#if host_machine.cpu_family() in ['ppc64', 'ppc64le']
# conf_data.set('PAGESIZE', 65536)
#endif
Port PAGESIZE define for PPC64LE to meson
2021-01-12 22:00:50 +01:00
Port C_SET_PRIORITY define to meson
2021-01-13 02:04:50 +01:00
set_prio_code = '''
#include <sys/resource.h>
int main() {
return setpriority(PRIO_PROCESS, 0, PRIO_MIN + PRIO_MAX);
}
'''
if cc.compiles(set_prio_code, name : 'test for setpriority support')
conf_data.set('HAVE_SETPRIORITY', 1)
endif
Port C_HAS_BUILTIN_EXPECT compiler check to meson
2021-01-21 15:49:04 +01:00
# New compilers can check for this feature using __has_builtin, but this is
# broken prior to Clang 10 and GCC 10, so we prefer to have this compilation
# check for now:
builtin_expect_code = '''
void fun(bool test) {
// value of 'test' is usually going to be true
if (__builtin_expect(test, true)) {
/* likely branch */
} else {
/* unlikely branch */
}
}
'''
if cxx.compiles(builtin_expect_code, name : 'test for __builtin_expect support')
conf_data.set('C_HAS_BUILTIN_EXPECT', 1)
endif
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
# external dependencies
#
Link SDL2_net statically in macOS release CI job Convert option try_sdl2_static into a new one, where user can select several libraries that will be marked for static linking. Provide short explanation in meson_options.txt file.
2021-02-20 23:08:19 +01:00
static_libs_list = get_option('try_static_libs')
msg = 'You can disable this dependency with: -D@0@=false'
Query macOS for the locale
2021-12-11 19:20:43 -08:00
optional_dep = dependency('', required : false)
dl_dep = cc.find_library('dl', required : false)
atomic_dep = cxx.find_library('atomic', required : false)
stdcppfs_dep = cxx.find_library('stdc++fs', required : false)
opus_dep = dependency('opusfile',
static : ('opusfile' in static_libs_list))
threads_dep = dependency('threads')
sdl2_dep = dependency('sdl2', version : '>= 2.0.5',
static : ('sdl2' in static_libs_list))
Add zlib as a dependency of ZMBV
2022-05-06 18:45:26 -07:00
zlib_dep = dependency('zlib', version : '>= 1.2.11',
static : ('zlib' in static_libs_list))
Add SpeexDSP to a couple more lists
2022-05-19 06:31:45 -07:00
speexdsp_dep = dependency('speexdsp', version : '> 1.1.9',
Replace linear-interpolation resampler with SpeeX
2022-05-17 09:23:01 +10:00
static : ('speexdsp' in static_libs_list))
Query macOS for the locale
2021-12-11 19:20:43 -08:00
sdl2_net_dep = optional_dep
opengl_dep = optional_dep
fluid_dep = optional_dep
Add slirp and glib meson wraps
2021-12-09 15:05:51 -08:00
libslirp_dep = optional_dep
Query macOS for the locale
2021-12-11 19:20:43 -08:00
mt32emu_dep = optional_dep
png_dep = optional_dep
slirp_dep = optional_dep
alsa_dep = optional_dep # Linux-only
coreaudio_dep = optional_dep # macOS-only
corefoundation_dep = optional_dep # macOS-only
coremidi_dep = optional_dep # macOS-only
winsock2_dep = optional_dep # Windows-only
winmm_dep = optional_dep # Windows-only
Rename 'dummy_dep' to 'optional_dep' in meson This name reflects the purpose a bit better. Reorganize code managing dependencies for readability.
2021-01-18 22:56:03 +01:00
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
if get_option('use_sdl2_net')
Move zypper packages list to README.md
2021-02-21 15:06:58 +01:00
sdl2_net_dep = dependency('SDL2_net', version : '>= 2.0.0',
Link SDL2_net statically in macOS release CI job Convert option try_sdl2_static into a new one, where user can select several libraries that will be marked for static linking. Provide short explanation in meson_options.txt file.
2021-02-20 23:08:19 +01:00
static : ('sdl2_net' in static_libs_list),
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
not_found_message : msg.format('use_sdl2_net'))
endif
if get_option('use_opengl')
opengl_dep = dependency('gl', not_found_message : msg.format('use_opengl'))
endif
Add slirp and glib meson wraps
2021-12-09 15:05:51 -08:00
# Use a single static setting for the pool of libraries that use glib
is_glib_realm_static = prefers_static_libs
foreach l : ['fluidsynth', 'slirp']
if l in static_libs_list
is_glib_realm_static = true
endif
endforeach
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
if get_option('use_fluidsynth')
Add slirp and glib meson wraps
2021-12-09 15:05:51 -08:00
fluid_dep = dependency('fluidsynth', version : '>= 2.2.3',
static : is_glib_realm_static,
Add fluidsynth dependency meson wrap fallback
2021-03-11 14:58:07 +01:00
fallback : ['fluidsynth', 'fluidsynth_dep'],
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
not_found_message : msg.format('use_fluidsynth'))
endif
Add slirp and glib meson wraps
2021-12-09 15:05:51 -08:00
if get_option('use_slirp')
libslirp_dep = dependency('slirp', version : '>= 4.6.1',
static : is_glib_realm_static,
fallback : ['slirp', 'libslirp_dep'],
not_found_message : msg.format('use_slirp'))
endif
Add mt32emu dependency with meson wrap fallback Add new option (use_mt32emu), to allow users to opt-out of this dependency if necessary. Aside of Meson WrapDB fallback, treat it as any other dependency.
2021-02-09 13:42:30 +01:00
if get_option('use_mt32emu')
Add slirp and glib meson wraps
2021-12-09 15:05:51 -08:00
mt32emu_dep = dependency('mt32emu', version : '>= 2.5.3',
static : prefers_static_libs or ('mt32emu' in static_libs_list),
Add mt32emu dependency with meson wrap fallback Add new option (use_mt32emu), to allow users to opt-out of this dependency if necessary. Aside of Meson WrapDB fallback, treat it as any other dependency.
2021-02-09 13:42:30 +01:00
fallback : ['mt32emu', 'mt32emu_dep'],
not_found_message : msg.format('use_mt32emu'))
endif
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
if get_option('use_png')
Add slirp and glib meson wraps
2021-12-09 15:05:51 -08:00
png_dep = dependency('libpng',
static : prefers_static_libs or ('png' in static_libs_list),
Link libpng statically in Linux and macOS releases
2021-02-20 23:22:15 +01:00
not_found_message : msg.format('use_png'))
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
endif
Detect CoreAudio, CoreMIDI dependencies on macOS Importantly, linking against Apple Frameworks seems to work only for official Apple compilers (which ATM means only Apple's fork of Clang).
2021-01-18 21:48:12 +01:00
# macOS-only dependencies
#
if host_machine.system() == 'darwin'
Check the usability of Apple's audio headers in Meson Also add ObjectiveC parsing on macOS if possible. Apple sometimes pollutes their headers with non-standard content that only compiles using their modified compiler. Because of this, simply testing for the presence of the CoreMIDI header is insufficient; instead, we need to make sure the compiler can actually process it. This will protect GCC from errors like this: /libmidi.a.p/midi.cpp.o -MF src/midi/libmidi.a.p/midi.cpp.o.d -o src/midi/libmidi.a.p/midi.cpp.o -c ../src/midi/midi.cpp In file included from ../src/midi/midi_coremidi.h:29, from ../src/midi/midi.cpp:84: /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:304:2: error: expected unqualified-id before '^' token 304 | (^MIDINotifyBlock)(const MIDINotification *message); | ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:304:2: error: expected ')' before '^' token 304 | (^MIDINotifyBlock)(const MIDINotification *message); | ~^ ) /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:347:2: error: expected unqualified-id before '^' token 347 | (^MIDIReadBlock)(const MIDIPacketList *pktlist, void * __nullable srcConnRefCon); | ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:347:2: error: expected ')' before '^' token 347 | (^MIDIReadBlock)(const MIDIPacketList *pktlist, void * __nullable srcConnRefCon); | ~^ ) In file included from ../src/midi/midi_coremidi.h:29, from ../src/midi/midi.cpp:84: /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:1190:41: error: 'MIDINotifyBlock' has not been declared 1190 | MIDINotifyBlock __nullable notifyBlock ) API_AVAILABLE(macos(10.11), ios(9.0), tvos(12.0));
2021-11-03 09:41:31 -07:00
# ObjectiveC parsing, if possible
if cxx.has_argument('-lobjc')
add_project_arguments('-lobjc', language : 'cpp')
endif
# Core Audio
Detect CoreAudio, CoreMIDI dependencies on macOS Importantly, linking against Apple Frameworks seems to work only for official Apple compilers (which ATM means only Apple's fork of Clang).
2021-01-18 21:48:12 +01:00
coreaudio_dep = dependency('appleframeworks',
modules : ['CoreAudio', 'AudioUnit', 'AudioToolbox'],
required : false)
if coreaudio_dep.found()
Check the usability of Apple's audio headers in Meson Also add ObjectiveC parsing on macOS if possible. Apple sometimes pollutes their headers with non-standard content that only compiles using their modified compiler. Because of this, simply testing for the presence of the CoreMIDI header is insufficient; instead, we need to make sure the compiler can actually process it. This will protect GCC from errors like this: /libmidi.a.p/midi.cpp.o -MF src/midi/libmidi.a.p/midi.cpp.o.d -o src/midi/libmidi.a.p/midi.cpp.o -c ../src/midi/midi.cpp In file included from ../src/midi/midi_coremidi.h:29, from ../src/midi/midi.cpp:84: /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:304:2: error: expected unqualified-id before '^' token 304 | (^MIDINotifyBlock)(const MIDINotification *message); | ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:304:2: error: expected ')' before '^' token 304 | (^MIDINotifyBlock)(const MIDINotification *message); | ~^ ) /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:347:2: error: expected unqualified-id before '^' token 347 | (^MIDIReadBlock)(const MIDIPacketList *pktlist, void * __nullable srcConnRefCon); | ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:347:2: error: expected ')' before '^' token 347 | (^MIDIReadBlock)(const MIDIPacketList *pktlist, void * __nullable srcConnRefCon); | ~^ ) In file included from ../src/midi/midi_coremidi.h:29, from ../src/midi/midi.cpp:84: /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:1190:41: error: 'MIDINotifyBlock' has not been declared 1190 | MIDINotifyBlock __nullable notifyBlock ) API_AVAILABLE(macos(10.11), ios(9.0), tvos(12.0));
2021-11-03 09:41:31 -07:00
if cxx.check_header('AudioToolbox/AUGraph.h')
conf_data.set('C_COREAUDIO', 1)
else
warning('''Core Audio support disabled: header is unsable''')
endif
Detect CoreAudio, CoreMIDI dependencies on macOS Importantly, linking against Apple Frameworks seems to work only for official Apple compilers (which ATM means only Apple's fork of Clang).
2021-01-18 21:48:12 +01:00
else
warning('''Core Audio support disabled: compiler can't detect/use Apple Frameworks''')
endif
Check the usability of Apple's audio headers in Meson Also add ObjectiveC parsing on macOS if possible. Apple sometimes pollutes their headers with non-standard content that only compiles using their modified compiler. Because of this, simply testing for the presence of the CoreMIDI header is insufficient; instead, we need to make sure the compiler can actually process it. This will protect GCC from errors like this: /libmidi.a.p/midi.cpp.o -MF src/midi/libmidi.a.p/midi.cpp.o.d -o src/midi/libmidi.a.p/midi.cpp.o -c ../src/midi/midi.cpp In file included from ../src/midi/midi_coremidi.h:29, from ../src/midi/midi.cpp:84: /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:304:2: error: expected unqualified-id before '^' token 304 | (^MIDINotifyBlock)(const MIDINotification *message); | ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:304:2: error: expected ')' before '^' token 304 | (^MIDINotifyBlock)(const MIDINotification *message); | ~^ ) /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:347:2: error: expected unqualified-id before '^' token 347 | (^MIDIReadBlock)(const MIDIPacketList *pktlist, void * __nullable srcConnRefCon); | ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:347:2: error: expected ')' before '^' token 347 | (^MIDIReadBlock)(const MIDIPacketList *pktlist, void * __nullable srcConnRefCon); | ~^ ) In file included from ../src/midi/midi_coremidi.h:29, from ../src/midi/midi.cpp:84: /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:1190:41: error: 'MIDINotifyBlock' has not been declared 1190 | MIDINotifyBlock __nullable notifyBlock ) API_AVAILABLE(macos(10.11), ios(9.0), tvos(12.0));
2021-11-03 09:41:31 -07:00
# Core MIDI
Detect CoreAudio, CoreMIDI dependencies on macOS Importantly, linking against Apple Frameworks seems to work only for official Apple compilers (which ATM means only Apple's fork of Clang).
2021-01-18 21:48:12 +01:00
coremidi_dep = dependency('appleframeworks',
modules : ['CoreMIDI', 'CoreFoundation'],
required : false)
if coremidi_dep.found()
Check the usability of Apple's audio headers in Meson Also add ObjectiveC parsing on macOS if possible. Apple sometimes pollutes their headers with non-standard content that only compiles using their modified compiler. Because of this, simply testing for the presence of the CoreMIDI header is insufficient; instead, we need to make sure the compiler can actually process it. This will protect GCC from errors like this: /libmidi.a.p/midi.cpp.o -MF src/midi/libmidi.a.p/midi.cpp.o.d -o src/midi/libmidi.a.p/midi.cpp.o -c ../src/midi/midi.cpp In file included from ../src/midi/midi_coremidi.h:29, from ../src/midi/midi.cpp:84: /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:304:2: error: expected unqualified-id before '^' token 304 | (^MIDINotifyBlock)(const MIDINotification *message); | ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:304:2: error: expected ')' before '^' token 304 | (^MIDINotifyBlock)(const MIDINotification *message); | ~^ ) /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:347:2: error: expected unqualified-id before '^' token 347 | (^MIDIReadBlock)(const MIDIPacketList *pktlist, void * __nullable srcConnRefCon); | ^ /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:347:2: error: expected ')' before '^' token 347 | (^MIDIReadBlock)(const MIDIPacketList *pktlist, void * __nullable srcConnRefCon); | ~^ ) In file included from ../src/midi/midi_coremidi.h:29, from ../src/midi/midi.cpp:84: /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreMIDI.framework/Headers/MIDIServices.h:1190:41: error: 'MIDINotifyBlock' has not been declared 1190 | MIDINotifyBlock __nullable notifyBlock ) API_AVAILABLE(macos(10.11), ios(9.0), tvos(12.0));
2021-11-03 09:41:31 -07:00
if cxx.check_header('CoreMIDI/MIDIServices.h')
conf_data.set('C_COREMIDI', 1)
else
warning('''Core Audio support disabled: header is unsable''')
endif
Detect CoreAudio, CoreMIDI dependencies on macOS Importantly, linking against Apple Frameworks seems to work only for official Apple compilers (which ATM means only Apple's fork of Clang).
2021-01-18 21:48:12 +01:00
else
warning('''Core MIDI support disabled: compiler can't detect/use Apple Frameworks''')
endif
Dynamic core support for W^X systems
2021-06-01 09:02:39 -05:00
Query macOS for the locale
2021-12-11 19:20:43 -08:00
# Locale discovery
corefoundation_dep = dependency('appleframeworks',
Address PR feedback as suggested
2022-02-15 19:37:18 -05:00
modules : ['CoreFoundation'],
Query macOS for the locale
2021-12-11 19:20:43 -08:00
required : false)
if corefoundation_dep.found()
if cxx.check_header('CoreFoundation/CoreFoundation.h')
conf_data.set('C_COREFOUNDATION', 1)
else
warning('''Core Foundation support disabled: header is unsable''')
endif
else
warning('''Core Foundation support disabled: compiler can't detect/use Apple Frameworks''')
endif
Address PR feedback as suggested
2022-02-15 19:37:18 -05:00
# SDL CD dependency
coreservices_dep = dependency('appleframeworks',
modules : ['CoreServices'],
required : false)
if coreservices_dep.found()
if cxx.check_header('CoreServices/CoreServices.h')
conf_data.set('C_CORESERVICES', 1)
else
warning('''Core Services support disabled: header is unsable''')
endif
else
warning('''Core Services support disabled: compiler can't detect/use Apple Frameworks''')
endif
Dynamic core support for W^X systems
2021-06-01 09:02:39 -05:00
# Apple Silicon has 16k pages
pagesize_cmd = run_command('pagesize')
if pagesize_cmd.returncode() != 0
error('''error executing pagesize''')
else
pagesize = pagesize_cmd.stdout().strip().to_int()
if pagesize != 4096
conf_data.set('PAGESIZE', pagesize)
endif
endif
Detect CoreAudio, CoreMIDI dependencies on macOS Importantly, linking against Apple Frameworks seems to work only for official Apple compilers (which ATM means only Apple's fork of Clang).
2021-01-18 21:48:12 +01:00
endif
Detect ALSA dependency using meson Advanced Linux Sound Architecture library is, as the name suggests, Linux-only dependency. Users of other OSes are extremely unlikely to want this feature enabled. We want it mandatory for Linux and not even an option anywhere else. This way FreeBSD or Haiku packagers won't need to explicitly disable the feature. This was the last dependency with pointless description in the INSTALL file; this file is now removed.
2021-01-21 13:44:19 +01:00
# Linux-only dependencies
#
Provide an option for disabling ALSA dependency We found that at least one Linux-like environment (Termux) provides access to ALSA, but is missing ALSA development libraries in the repo.
2021-02-12 16:27:56 +01:00
using_linux = (host_machine.system() == 'linux')
force_alsa = (get_option('use_alsa') == 'true')
if force_alsa or (using_linux and get_option('use_alsa') == 'auto')
Detect ALSA dependency using meson Advanced Linux Sound Architecture library is, as the name suggests, Linux-only dependency. Users of other OSes are extremely unlikely to want this feature enabled. We want it mandatory for Linux and not even an option anywhere else. This way FreeBSD or Haiku packagers won't need to explicitly disable the feature. This was the last dependency with pointless description in the INSTALL file; this file is now removed.
2021-01-21 13:44:19 +01:00
alsa_dep = dependency('alsa')
conf_data.set('C_ALSA', 1)
endif
Add Windows Sockets and Windows Multimedia dependencies Windows Multimedia (winmm) is required for Windows MIDI interface. Windows Sockets (ws2_32) is required for compiling networking features.
2021-01-22 01:36:26 +01:00
# Windows-only dependencies
#
Upgrade minimum meson version to 0.49.0 As of early 2021, meson 0.49.x is packaged by Debian Stable and almost all other up-to-date repositories. Notably, it's missing from Ubuntu 18.04 (which uses meson 0.45.2).
2021-02-06 18:58:02 +01:00
if host_machine.system() in ['windows', 'cygwin']
Add Windows Sockets and Windows Multimedia dependencies Windows Multimedia (winmm) is required for Windows MIDI interface. Windows Sockets (ws2_32) is required for compiling networking features.
2021-01-22 01:36:26 +01:00
winsock2_dep = cxx.find_library('ws2_32', required : true)
winmm_dep = cxx.find_library('winmm', required : true)
endif
Use Meson summary function Since we upgraded to meson > 0.53, we can use summary to highlight some information important during build. This is way more readable than using message function for the same purpose.
2021-10-03 22:29:24 +02:00
summary('OpenGL support', get_option('use_opengl'))
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
# include directories
#
Avoid using libloguru as project include Inject build instructions via dependency, just like other bundled libraries. Also, move dependency declarations of bundled libraries to their respective meson files.
2021-10-04 14:23:26 +02:00
incdir = include_directories('include', '.')
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
Replace logging with loguru
2021-08-24 12:09:11 -05:00
# bundled dependencies, in dependency-order
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
#
Add the ghc::filesystem to the build system
2021-12-30 09:30:34 -08:00
subdir('src/libs/ghc')
Replace logging with loguru
2021-08-24 12:09:11 -05:00
subdir('src/libs/loguru')
Avoid using libloguru as project include Inject build instructions via dependency, just like other bundled libraries. Also, move dependency declarations of bundled libraries to their respective meson files.
2021-10-04 14:23:26 +02:00
subdir('src/libs/decoders')
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
subdir('src/libs/nuked')
subdir('src/libs/ppscale')
Add reSIDfp and Innovation SSI-2001 to the buildsystem
2021-04-14 15:26:08 -07:00
subdir('src/libs/residfp')
Use direct file inclusion for Meson
2022-02-11 16:58:46 -05:00
subdir('src/libs/sdlcd')
Add whereami to the Meson and VS build systems
2021-10-05 07:27:07 -07:00
subdir('src/libs/whereami')
Integrate modified PDCurses for debugger
2022-04-30 20:09:27 -05:00
subdir('src/libs/PDCurses')
Add ir1 to the build system
2022-05-20 17:11:44 +10:00
subdir('src/libs/iir1')
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
# internal libs
#
internal_deps = []
subdir('src/cpu')
subdir('src/debug')
subdir('src/dos')
subdir('src/fpu')
subdir('src/gui')
subdir('src/hardware')
subdir('src/ints')
subdir('src/midi')
subdir('src/misc')
subdir('src/shell')
Move cpu-related build defines to src/cpu subdir
2021-01-12 20:45:49 +01:00
# generate config.h
#
configure_file(input : 'src/config.h.in', output : 'config.h',
configuration : conf_data)
Start migration to meson buildsystem As of right now, new buildsystem is capable of creating clean, featureful builds on Linux x86_64 - but these are not equivalent of all that are exposed via autoconf yet. As new features will be added, it will gradually replace Autotools and build.sh. Preserve our existing structure of building a static library per "module", and then linking them together to create dosbox binary. Unlike automake, we don't need to create a library per subdirectory - it's entirely our pragmatic choice. As a result, we don't have multiple sub-libraries for e.g. hardware module: all files inside are handled by a single meson.build file (we can simplify this even further and make the project structure even flatter or deeper as needed. Create config.h.in template file - meson turns it into our new config.h file, filling it with information detected in meson.build scripts. Create new file for main function - this way it'll be easier to ignore this file for gtest builds (which will have their own main functions). Old main was renamed to sdl_main and is now declared as the very first function in dosbox.h file. Update elementary build documentation in README.md and CONTRIBUTING.md. Remove majority of content in the INSTALL file. Information in that file was either outdated or is now automatically verified by meson.build script.
2020-12-14 04:14:08 +01:00
# dosbox executable
#
Use Git tag description for emulator version This change BREAKS Autoconf-based buildsystem. Only Meson and Visual Studio buildsystems are operational from this point forward. Thanks to this change, it will be easier for developers and testers to communicate/detect the exact version of emulator. Builds created from tarball releases OR builds from Git repo checked out to point to an annotated tag will behave this way: $ dosbox --version dosbox (dosbox-staging), version 0.77.0 ... Development builds from Git repo will behave this way: $ dosbox --version dosbox (dosbox-staging), version 0.77.0-alpha-457-g6d8d10a9 ... Meson handles this "automagically", correctly for us via vcs_tag function. We use it to generate version.cpp file - this way new commits in repo will rebuild only a single file and trigger linker, but will never result in full rebuild. When Meson cannot obtain info version from Git, it automatically falls back to version specified in our project function on top of meson.build file. Leave VERSION macro in place (it originated from Autoconf) in several places - it's being extensively used when communicating e.g. "emulated modem firmware version" and other fake-hardware identification. Any builds created with Visual Studio (Release and Debug builds) will use hardcoded version string for VERSION macro and hardcoded version string DOSBOX_DETAILED_VERSION for all the places where we want more info. This macro defaults to string "git" and is being overriden with output of "git describe" on CI. Also, adjust --version copyright message for readability and to better fit into 80 colums. Fixes: #543
2021-02-13 20:27:48 +01:00
version_file = vcs_tag(input : 'src/version.cpp.in', output : 'version.cpp')
Add Windows resources file compiling to meson This adds an icon and 'Details' to Windows executable.
2021-09-25 14:52:45 +12:00
dosbox_sources = ['src/main.cpp', 'src/dosbox.cpp', version_file]
# Add Windows resources file if building on Windows
if host_machine.system() == 'windows'
winmod = import('windows')
res_file = winmod.compile_resources('src/winres.rc')
dosbox_sources += res_file
endif
executable('dosbox', dosbox_sources,
Workaround GCC 7 and 8 that require experimental::filesystem GCC 7 and 8 were released before the std::filesystem specification was finalized in C++17, and use "experimental/filesystem" as their include file and "std::experimental::filesystem" as the namespace. Newer GCC's and other compilers (Clang, MSVC) are currently modern enough that no workarounds are needed for them. Therefore, this commit uses a temporary "std_filesystem.h" that normalizes these differences and provides a "std_fs" namespace. The std_prefix was selected to explicitly indicate that the file and namespace comes from std::, and not our own creation. Unfortuantely we also cannot use the commonly suggested "fs::" namespace shorthand due to the CPU core using an "fs" enum value. When GCC 7 and 8 are eventually not supported, we can mass replace "std_filesystem.h" and "std_fs::" with their C++17 equivalents, <filesystem> and std::filesystem, respectively.
2021-10-03 21:33:52 -07:00
dependencies : [atomic_dep,
stdcppfs_dep,
sdl2_dep,
threads_dep,
Add ir1 to the build system
2022-05-20 17:11:44 +10:00
libiir1_dep,
Add the ghc::filesystem to the build system
2021-12-30 09:30:34 -08:00
libghc_dep,
Workaround GCC 7 and 8 that require experimental::filesystem GCC 7 and 8 were released before the std::filesystem specification was finalized in C++17, and use "experimental/filesystem" as their include file and "std::experimental::filesystem" as the namespace. Newer GCC's and other compilers (Clang, MSVC) are currently modern enough that no workarounds are needed for them. Therefore, this commit uses a temporary "std_filesystem.h" that normalizes these differences and provides a "std_fs" namespace. The std_prefix was selected to explicitly indicate that the file and namespace comes from std::, and not our own creation. Unfortuantely we also cannot use the commonly suggested "fs::" namespace shorthand due to the CPU core using an "fs" enum value. When GCC 7 and 8 are eventually not supported, we can mass replace "std_filesystem.h" and "std_fs::" with their C++17 equivalents, <filesystem> and std::filesystem, respectively.
2021-10-03 21:33:52 -07:00
libloguru_dep,
Integrate modified PDCurses for debugger
2022-04-30 20:09:27 -05:00
libpdcurses_dep,
Use direct file inclusion for Meson
2022-02-11 16:58:46 -05:00
libsdlcd_dep,
Workaround GCC 7 and 8 that require experimental::filesystem GCC 7 and 8 were released before the std::filesystem specification was finalized in C++17, and use "experimental/filesystem" as their include file and "std::experimental::filesystem" as the namespace. Newer GCC's and other compilers (Clang, MSVC) are currently modern enough that no workarounds are needed for them. Therefore, this commit uses a temporary "std_filesystem.h" that normalizes these differences and provides a "std_fs" namespace. The std_prefix was selected to explicitly indicate that the file and namespace comes from std::, and not our own creation. Unfortuantely we also cannot use the commonly suggested "fs::" namespace shorthand due to the CPU core using an "fs" enum value. When GCC 7 and 8 are eventually not supported, we can mass replace "std_filesystem.h" and "std_fs::" with their C++17 equivalents, <filesystem> and std::filesystem, respectively.
2021-10-03 21:33:52 -07:00
libwhereami_dep]
+ internal_deps,
Add unitial support for installation via meson Install: - compiled binary - man page - documentation (README, AUTHORS, etc) - icons (both scalable and raster icons) - desktop entry file - metainfo.xml file - license Following usual Unix conventions.
2021-02-04 16:56:23 +01:00
include_directories : incdir,
install : true)
Tests for libdos, C++17 strings for WildFileCmp This makes it possible to test functions that are within or directly depend on DOSBox executable, by adding a libdosbox object and a dependency for inclusion. Secondarily, this begins the modernization of string handling code with src/dos/drives.cpp:WildFileCmp.
2021-10-10 19:58:21 -07:00
# create a library so we can test things inside DOSBOX dep path
Remove the project's main to prevent masking gmock's main (#1476) clang/llvm ensure gmock's main() function always overrides the main function coming from the dosbox library, however sometimes with gcc/ld, gmock's main() doesn't take precedent and instead dosbox's main is run. This fixes an issue reported on Fedora and Gentoo where unit tests were popping up SDL's graphical window, and then either timing our failing.
2022-01-01 07:48:27 -08:00
libdosbox = static_library('dosbox', ['src/dosbox.cpp', version_file],
Tests for libdos, C++17 strings for WildFileCmp This makes it possible to test functions that are within or directly depend on DOSBox executable, by adding a libdosbox object and a dependency for inclusion. Secondarily, this begins the modernization of string handling code with src/dos/drives.cpp:WildFileCmp.
2021-10-10 19:58:21 -07:00
include_directories : incdir,
Add the ghc::filesystem to the build system
2021-12-30 09:30:34 -08:00
dependencies : [atomic_dep,
threads_dep,
sdl2_dep,
Add ir1 to the build system
2022-05-20 17:11:44 +10:00
libiir1_dep,
Add the ghc::filesystem to the build system
2021-12-30 09:30:34 -08:00
libghc_dep,
Use direct file inclusion for Meson
2022-02-11 16:58:46 -05:00
libloguru_dep,
libsdlcd_dep]
Add the ghc::filesystem to the build system
2021-12-30 09:30:34 -08:00
+ internal_deps)
Tests for libdos, C++17 strings for WildFileCmp This makes it possible to test functions that are within or directly depend on DOSBox executable, by adding a libdosbox object and a dependency for inclusion. Secondarily, this begins the modernization of string handling code with src/dos/drives.cpp:WildFileCmp.
2021-10-10 19:58:21 -07:00
dosbox_dep = declare_dependency(link_with : libdosbox)
# tests
#
# Some tests use relative paths; in meson 0.56.0 this can be replaced
# with meson.project_source_root().
project_source_root = meson.current_source_dir()
subdir('tests')
Add unitial support for installation via meson Install: - compiled binary - man page - documentation (README, AUTHORS, etc) - icons (both scalable and raster icons) - desktop entry file - metainfo.xml file - license Following usual Unix conventions.
2021-02-04 16:56:23 +01:00
# additional files for installation
#
data_dir = get_option('datadir')
licenses_dir = data_dir / 'licenses' / 'dosbox-staging'
doc_dir = data_dir / 'doc' / 'dosbox-staging'
install_man('docs/dosbox.1')
install_data('COPYING', install_dir : licenses_dir)
install_data('AUTHORS', 'README', 'THANKS', install_dir : doc_dir)
subdir('contrib/linux')
subdir('contrib/icons')
Move the translation files into resources
2022-03-25 15:28:51 -07:00
subdir('contrib/resources')
Reference in a new issue Copy permalink