thirdparty/ppsspp
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Change string manipulation to C++ string class

Browse source 
std::string seems to be the preferred method since you don't need to alloc
more memory then you need (the Class automagically allocates the necessary
RAM) and there is no chance of buffer overflow. But since I don't have Mac
OSX, I didn't test it (it should work, since this is standard C++).

Add Mac OSX support to Launcher{Market,Email} too and changed Linux to use
"xdg-email " instead "xdg-open mailto:" since this seems the preferred method.
This commit is contained in:
Thiago Kenji Okada 2013-11-01 15:09:36 -02:00
parent 4c8922d9e7
commit 64e9c2088f
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
base/PCMain.cpp
View file

@ -233,9 +233,8 @@ void LaunchBrowser(const char *url)
std::string command = std::string("xdg-open ") + url; std::string command = std::string("xdg-open ") + url;
system(command.c_str()); system(command.c_str());
#elif __APPLE__ #elif __APPLE__
char temp[1024]; std::string command = std::string("open ") + url;
sprintf(temp, "open %s", url); system(command.c_str());
system(temp);
#else #else
ILOG("Would have gone to %s but LaunchBrowser is not implemented on this platform", url); ILOG("Would have gone to %s but LaunchBrowser is not implemented on this platform", url);
#endif #endif
@ -248,6 +247,9 @@ void LaunchMarket(const char *url)
#elif __linux__ #elif __linux__
std::string command = std::string("xdg-open ") + url; std::string command = std::string("xdg-open ") + url;
system(command.c_str()); system(command.c_str());
#elif __APPLE__
std::string command = std::string("open ") + url;
system(command.c_str());
#else #else
ILOG("Would have gone to %s but LaunchMarket is not implemented on this platform", url); ILOG("Would have gone to %s but LaunchMarket is not implemented on this platform", url);
#endif #endif
@ -258,7 +260,10 @@ void LaunchEmail(const char *email_address)
#ifdef _WIN32 #ifdef _WIN32
ShellExecute(NULL, "open", (std::string("mailto:") + email_address).c_str(), NULL, NULL, SW_SHOWNORMAL); ShellExecute(NULL, "open", (std::string("mailto:") + email_address).c_str(), NULL, NULL, SW_SHOWNORMAL);
#elif __linux__ #elif __linux__
std::string command = std::string("xdg-open mailto:") + email_address; std::string command = std::string("xdg-email ") + email_address;
system(command.c_str());
#elif __APPLE__
std::string command = std::string("open mailto:") + email_address;
system(command.c_str()); system(command.c_str());
#else #else
ILOG("Would have opened your email client for %s but LaunchEmail is not implemented on this platform", email_address); ILOG("Would have opened your email client for %s but LaunchEmail is not implemented on this platform", email_address);