thirdparty/ppsspp
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix use-after-free in shader error reporting

Browse source
This commit is contained in:
Henrik Rydgård 2018-01-10 16:37:02 +01:00
parent d0038775e5
commit e4752a887f
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ext/native/thin3d/GLQueueRunner.cpp
View file

@ -143,7 +143,6 @@ void GLQueueRunner::RunInitSteps(const std::vector<GLRInitStep> &steps) {
step.create_shader.shader->shader = shader;
const char *code = step.create_shader.code;
glShaderSource(shader, 1, &code, nullptr);
delete[] step.create_shader.code;
glCompileShader(shader);
GLint success = 0;
glGetShaderiv(shader, GL_COMPILE_STATUS, &success);
@ -166,6 +165,7 @@ void GLQueueRunner::RunInitSteps(const std::vector<GLRInitStep> &steps) {
#endif
step.create_shader.shader->valid = false;
}
delete[] step.create_shader.code;
delete[] step.create_shader.desc;
step.create_shader.shader->valid = true;
break;