Moved ELFPlugin class definition into elf-provider.h

svn-id: r51767

backends/plugins/elf-provider.cpp

@@ -23,90 +23,48 @@
  *
  */
 
-#if defined(DYNAMIC_MODULES) && defined(ELF_LOADER_TARGET)
-
 #include "backends/plugins/elf-provider.h"
 #include "backends/plugins/dynamic-plugin.h"
 #include "common/fs.h"
 
 #include "backends/plugins/elf-loader.h"
 
-class ELFPlugin : public DynamicPlugin {
+#if defined(DYNAMIC_MODULES) && defined(ELF_LOADER_TARGET)
-protected:
-	DLObject *_dlHandle;
-	Common::String _filename;
 
-	virtual VoidFunc findSymbol(const char *symbol) {
+bool ELFPlugin::loadPlugin() {
-		void *func;
+	assert(!_dlHandle);
-		bool handleNull;
+	DLObject *obj = new DLObject(NULL);
-		if (_dlHandle == NULL) {
+	if (obj->open(_filename.c_str())) {
-			func = NULL;
+		_dlHandle = obj;
-			handleNull = true;
+	} else {
-		} else {
+		delete obj;
-			func = _dlHandle->symbol(symbol);
+		_dlHandle = NULL;
-		}
-		if (!func) {
-			if (handleNull) {
-				warning("Failed loading symbol '%s' from plugin '%s' (Handle is NULL)", symbol, _filename.c_str());
-			} else {
-				warning("Failed loading symbol '%s' from plugin '%s'", symbol, _filename.c_str());
-			}
-		}
-
-		// FIXME HACK: This is a HACK to circumvent a clash between the ISO C++
-		// standard and POSIX: ISO C++ disallows casting between function pointers
-		// and data pointers, but dlsym always returns a void pointer. For details,
-		// see e.g. <http://www.trilithium.com/johan/2004/12/problem-with-dlsym/>.
-		assert(sizeof(VoidFunc) == sizeof(func));
-		VoidFunc tmp;
-		memcpy(&tmp, &func, sizeof(VoidFunc));
-		return tmp;
 	}
 
-public:
+	if (!_dlHandle) {
-	ELFPlugin(const Common::String &filename)
+		warning("Failed loading plugin '%s'", _filename.c_str());
-		: _dlHandle(0), _filename(filename) {}
+		return false;
-
-	~ELFPlugin() {
-		if (_dlHandle)
-			unloadPlugin();
 	}
 
-	bool loadPlugin() {
+	bool ret = DynamicPlugin::loadPlugin();
-		assert(!_dlHandle);
-		DLObject *obj = new DLObject(NULL);
-		if (obj->open(_filename.c_str())) {
-			_dlHandle = obj;
-		} else {
-			delete obj;
-			_dlHandle = NULL;
-		}
 
-		if (!_dlHandle) {
+	if (ret && _dlHandle) {
-			warning("Failed loading plugin '%s'", _filename.c_str());
+		_dlHandle->discard_symtab();
-			return false;
-		}
-
-		bool ret = DynamicPlugin::loadPlugin();
-
-		if (ret && _dlHandle) {
-			_dlHandle->discard_symtab();
-		}
-
-		return ret;
 	}
 
-	void unloadPlugin() {
+	return ret;
-		DynamicPlugin::unloadPlugin();
+}
-		if (_dlHandle) {
+
-			delete _dlHandle;
+void ELFPlugin::unloadPlugin() {
-			if (!_dlHandle->close()) {
+	DynamicPlugin::unloadPlugin();
-				warning("Failed unloading plugin '%s'", _filename.c_str());
+	if (_dlHandle) {
-			}
+		delete _dlHandle;
-			_dlHandle = 0;
+		if (!_dlHandle->close()) {
+			warning("Failed unloading plugin '%s'", _filename.c_str());
 		}
+		_dlHandle = 0;
 	}
-};
+}
 
 
 Plugin* ELFPluginProvider::createPlugin(const Common::FSNode &node) const {

backends/plugins/elf-provider.h

@@ -27,9 +27,61 @@
 #define BACKENDS_PLUGINS_ELF_PROVIDER_H
 
 #include "base/plugins.h"
+#include "backends/plugins/dynamic-plugin.h"
+#include "common/fs.h"
+
+#include "backends/plugins/elf-loader.h"
 
 #if defined(DYNAMIC_MODULES) && defined(ELF_LOADER_TARGET)
 
+class ELFPlugin : public DynamicPlugin {
+protected:
+	DLObject *_dlHandle;
+	Common::String _filename;
+
+	//FIXME: The code for this method should be in elf-provider.cpp,
+	//		 but VoidFunc isn't recognized if we do that as is.
+	virtual VoidFunc findSymbol(const char *symbol) {
+		void *func;
+			bool handleNull;
+			if (_dlHandle == NULL) {
+				func = NULL;
+				handleNull = true;
+			} else {
+				func = _dlHandle->symbol(symbol);
+			}
+			if (!func) {
+				if (handleNull) {
+					warning("Failed loading symbol '%s' from plugin '%s' (Handle is NULL)", symbol, _filename.c_str());
+				} else {
+					warning("Failed loading symbol '%s' from plugin '%s'", symbol, _filename.c_str());
+				}
+			}
+
+			// FIXME HACK: This is a HACK to circumvent a clash between the ISO C++
+			// standard and POSIX: ISO C++ disallows casting between function pointers
+			// and data pointers, but dlsym always returns a void pointer. For details,
+			// see e.g. <http://www.trilithium.com/johan/2004/12/problem-with-dlsym/>.
+			assert(sizeof(VoidFunc) == sizeof(func));
+			VoidFunc tmp;
+			memcpy(&tmp, &func, sizeof(VoidFunc));
+			return tmp;;
+	}
+
+public:
+	ELFPlugin(const Common::String &filename)
+		: _dlHandle(0), _filename(filename) {}
+
+	~ELFPlugin() {
+		if (_dlHandle)
+			unloadPlugin();
+	}
+
+	bool loadPlugin();
+	void unloadPlugin();
+
+};
+
 class ELFPluginProvider : public FilePluginProvider {
 protected:
 	Plugin* createPlugin(const Common::FSNode &node) const;