thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

AUDIO: Change several fake MidiDrivers to MidiDriver_BASE subclasses

Browse source 
Many engines follow the advice in audio/midiparser.h and create a
"pseudo-MidiDriver" subclass. But MidiParser really only needs a tiny
subset of the MidiDriver capabilities, namely those found in
MidiDriver_BASE. So we try to subclass from that whenever possible; this
allows us to remove many stub methods, and enables further future
simplifications.
This commit is contained in:
Max Horn 2011-03-23 15:23:26 +01:00
parent c70c8864f1
commit 29847ea42d
35 changed files with 45 additions and 255 deletions
Download patch file Download diff file Expand all files Collapse all files

2
engines/testbed/midi.cpp
View file

@ -96,7 +96,7 @@ TestExitStatus MidiTests::playMidiMusic() {
int errCode = driver->open();
if (errCode) {
Common::String errMsg = driver->getErrorName(errCode);
Common::String errMsg = MidiDriver::getErrorName(errCode);
Testsuite::writeOnScreen(errMsg, Common::Point(0, 100));
Testsuite::logPrintf("Error! %s", errMsg.c_str());
return kTestFailed;