thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SCUMM: Fix initGM() buffer overflow (CID 1032513)

Browse source 
We're clearly using 12 bytes, not 11.
This commit is contained in:
Torbjörn Andersson 2013-07-06 14:03:31 +02:00
parent 1ed1106cb2
commit 29bc36d070
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
engines/scumm/imuse/imuse.cpp
View file

@ -1483,7 +1483,7 @@ void IMuseInternal::initMT32(MidiDriver *midi) {
}
void IMuseInternal::initGM(MidiDriver *midi) {
byte buffer[11];
byte buffer[12];
int i;
// General MIDI System On message
@ -1540,7 +1540,7 @@ void IMuseInternal::initGM(MidiDriver *midi) {
// Set Channels 1-16 Reverb to 64, which is the
// equivalent of MT-32 default Reverb Level 5
for (i = 0; i < 16; ++i)
midi->send((64 << 16) | (91 << 8) | (0xB0 | i));
midi->send((64 << 16) | (91 << 8) | (0xB0 | i));
debug(2, "GM Controller 91 Change: Channels 1-16 Reverb Level is 64");
// Set Channels 1-16 Pitch Bend Sensitivity to