thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

POSIX: Add TODO/FIXME to displayLogFile

Browse source
This commit is contained in:
Willem Jan Palenstijn 2011-06-04 16:39:15 +02:00
parent 3f603ce0ab
commit 2d87394be9
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
backends/platform/sdl/posix/posix.cpp
View file

@ -167,6 +167,10 @@ bool OSystem_POSIX::displayLogFile() {
execlp("xdg-open", "xdg-open", _logFilePath.c_str(), (char*)0);
// If we're here, that clearly failed.
// TODO: We may also want to try detecting the case where
// xdg-open is successfully executed but returns an error code.
// Try xterm+less next
execlp("xterm", "xterm", "-e", "less", _logFilePath.c_str(), (char*)0);
@ -182,6 +186,9 @@ bool OSystem_POSIX::displayLogFile() {
int status;
// Wait for viewer to close.
// (But note that xdg-open may have spawned a viewer in the background.)
// FIXME: We probably want the viewer to always open in the background.
// This may require installing a SIGCHLD handler.
pid = waitpid(pid, &status, 0);
if (pid < 0) {