MADS: Fixed handling of dirty rects to copy areas to the physical screen

engines/mads/dialogs.cpp

@@ -23,7 +23,7 @@
 #include "common/scummsys.h"
 #include "common/config-manager.h"
 #include "mads/mads.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/msurface.h"
 #include "mads/nebular/dialogs_nebular.h"
 

engines/mads/game.cpp

@@ -25,7 +25,7 @@
 #include "mads/game.h"
 #include "mads/game_data.h"
 #include "mads/events.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/msurface.h"
 #include "mads/resources.h"
 #include "mads/nebular/game_nebular.h"

engines/mads/game_data.cpp

@@ -24,7 +24,7 @@
 #include "mads/mads.h"
 #include "mads/game.h"
 #include "mads/nebular/game_nebular.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/msurface.h"
 #include "mads/resources.h"
 

engines/mads/mads.cpp

@@ -26,7 +26,7 @@
 #include "common/events.h"
 #include "engines/util.h"
 #include "mads/mads.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/msurface.h"
 #include "mads/resources.h"
 #include "mads/sound.h"

engines/mads/mads.h

@@ -35,7 +35,7 @@
 #include "mads/events.h"
 #include "mads/font.h"
 #include "mads/game.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/msurface.h"
 #include "mads/resources.h"
 #include "mads/sound.h"

engines/mads/messages.cpp

@@ -23,7 +23,7 @@
 #include "common/scummsys.h"
 #include "mads/mads.h"
 #include "mads/font.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/messages.h"
 #include "mads/scene_data.h"
 

engines/mads/module.mk

@@ -18,7 +18,6 @@ MODULE_OBJS := \
 	font.o \
 	game.o \
 	game_data.o \
-	graphics.o \
 	hotspots.o \
 	interface.o \
 	mads.o \
@@ -29,6 +28,7 @@ MODULE_OBJS := \
 	resources.o \
 	scene.o \
 	scene_data.o \
+	screen.o \
 	sequence.o \
 	sound.o \
 	sprites.o \

engines/mads/msurface.cpp

@@ -22,7 +22,7 @@
 
 #include "engines/util.h"
 #include "mads/compression.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/mads.h"
 #include "mads/msurface.h"
 #include "mads/resources.h"

engines/mads/nebular/dialogs_nebular.cpp

@@ -23,7 +23,7 @@
 #include "common/scummsys.h"
 #include "common/config-manager.h"
 #include "mads/mads.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/msurface.h"
 #include "mads/nebular/dialogs_nebular.h"
 

engines/mads/nebular/game_nebular.cpp

@@ -24,7 +24,7 @@
 #include "common/config-manager.h"
 #include "mads/mads.h"
 #include "mads/game.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/msurface.h"
 #include "mads/nebular/game_nebular.h"
 #include "mads/nebular/dialogs_nebular.h"

engines/mads/scene.cpp

@@ -438,7 +438,7 @@ void Scene::drawElements(ScreenTransition transitionType, bool surfaceFlag) {
 	_dirtyAreas.merge(1, DIRTY_AREAS_SIZE);
 
 	// Copy dirty areas to the main display surface
-	_dirtyAreas.copy(&_vm->_screen, &_backgroundSurface, _posAdjust);
+	_dirtyAreas.copy(&_backgroundSurface, &_vm->_screen, _posAdjust);
 
 	// Handle dirty areas for foreground objects
 	_spriteSlots.setDirtyAreas();
@@ -463,7 +463,7 @@ void Scene::drawElements(ScreenTransition transitionType, bool surfaceFlag) {
 		_vm->_sound->startQueuedCommands();
 	} else {
 		// Copy dirty areas to the screen
-		_dirtyAreas.copy(&_vm->_screen, &_backgroundSurface, _vm->_screen._offset);
+		_dirtyAreas.copyToScreen(_vm->_screen._offset);
 	}
 
 	warning("TODO: sub_115A2");

engines/mads/scene.h

@@ -27,7 +27,7 @@
 #include "common/array.h"
 #include "common/rect.h"
 #include "mads/assets.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/hotspots.h"
 #include "mads/messages.h"
 #include "mads/msurface.h"

engines/mads/scene_data.cpp

@@ -24,7 +24,7 @@
 #include "mads/scene_data.h"
 #include "mads/mads.h"
 #include "mads/compression.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/resources.h"
 #include "mads/nebular/nebular_scenes.h"
 
@@ -276,7 +276,20 @@ void DirtyAreas::mergeAreas(int idx1, int idx2) {
 	da1._textActive = true;
 }
 
-void DirtyAreas::copy(MSurface *dest, MSurface *src, const Common::Point &posAdjust) {
+void DirtyAreas::copy(MSurface *srcSurface, MSurface *destSurface, const Common::Point &posAdjust) {
+	for (uint i = 0; i < size(); ++i) {
+		const Common::Rect &srcBounds = (*this)[i]._bounds;
+
+		Common::Rect bounds(srcBounds.left + posAdjust.x, srcBounds.top + posAdjust.y,
+			srcBounds.right + posAdjust.x, srcBounds.bottom + posAdjust.y);
+
+		if ((*this)[i]._active && bounds.isValidRect()) {
+			srcSurface->copyTo(destSurface, bounds, Common::Point(bounds.left, bounds.top));
+		}
+	}
+}
+
+void DirtyAreas::copyToScreen(const Common::Point &posAdjust) {
 	for (uint i = 0; i < size(); ++i) {
 		const Common::Rect &srcBounds = (*this)[i]._bounds;
 
@@ -284,8 +297,7 @@ void DirtyAreas::copy(MSurface *dest, MSurface *src, const Common::Point &posAdj
 			srcBounds.right + posAdjust.x, srcBounds.bottom + posAdjust.y);
 
 		if ((*this)[i]._active && (*this)[i]._bounds.isValidRect()) {
-			src->copyTo(dest, bounds, Common::Point((*this)[i]._bounds.left,
+			_vm->_screen.copyRectToScreen(bounds);
-				(*this)[i]._bounds.top));
 		}
 	}
 }

engines/mads/scene_data.h

@@ -151,7 +151,21 @@ public:
 
 	bool intersects(int idx1, int idx2);
 	void mergeAreas(int idx1, int idx2);
-	void copy(MSurface *dest, MSurface *src, const Common::Point &posAdjust);
+
+	/**
+	 * Copy the data specified by the dirty rect list between surfaces
+	 * @param srcSurface	Source surface
+	 * @param destSurface	Dest surface
+	 * @param posAdjust		Position adjustment
+	 */
+	void copy(MSurface *srcSurface, MSurface *destSurface, const Common::Point &posAdjust);
+
+	/**
+	 * Use the lsit of dirty areas to copy areas of the screen surface to
+	 * the physical screen
+	 * @param posAdjust		Position adjustment	 */
+	void copyToScreen(const Common::Point &posAdjust);
+
 	void reset();
 };
 

engines/mads/screen.cpp

@@ -23,17 +23,32 @@
 #include "common/scummsys.h"
 #include "mads/mads.h"
 #include "mads/game.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/palette.h"
 
 namespace MADS {
 
+ScreenSurface::ScreenSurface() {
+	_dataP = nullptr;
+}
+
 void ScreenSurface::init() {
 	setSize(g_system->getWidth(), g_system->getHeight());
 }
 
+void ScreenSurface::copyRectToScreen(const Common::Point &destPos,
+		const Common::Rect &bounds) {
+	byte *buf = getBasePtr(destPos.x, destPos.y);
+	g_system->copyRectToScreen(buf, this->pitch, bounds.left, bounds.top,
+		bounds.width(), bounds.height());
+}
+
+void ScreenSurface::copyRectToScreen(const Common::Rect &bounds) {
+	copyRectToScreen(Common::Point(bounds.left, bounds.top), bounds);
+}
+
+
 void ScreenSurface::updateScreen() {
-	g_system->copyRectToScreen((const byte *)pixels, pitch, 0, 0, w, h);
 	g_system->updateScreen();
 }
 
@@ -75,8 +90,7 @@ void ScreenSurface::transition(ScreenTransition transitionType, bool surfaceFlag
 }
 
 void ScreenSurface::setPointer(MSurface *s) {
-	_pixels = s->getData();
+	_dataP = s->getData();
-	_pitch = s->w;
 }
 
 void ScreenSurface::fadeOut() {
@@ -86,6 +100,7 @@ void ScreenSurface::fadeOut() {
 void ScreenSurface::fadeIn() {
 	warning("TODO: Proper fade in");
 	_vm->_palette->setFullPalette(_vm->_palette->_mainPalette);
+	_vm->_screen.copyRectToScreen(Common::Rect(0, 0, 320, 200));
 }
 
 } // End of namespace MADS

engines/mads/screen.h

@@ -20,8 +20,8 @@
  *
  */
 
-#ifndef MADS_GRAPHICS_H
+#ifndef MADS_SCREEN_H
-#define MADS_GRAPHICS_H
+#define MADS_SCREEN_H
 
 #include "common/scummsys.h"
 #include "common/array.h"
@@ -58,13 +58,12 @@ private:
 	void fadeIn();
 public:
 	Common::Point _offset;
-	byte *_pixels;
+	byte *_dataP;
-	int _pitch;
 public:
 	/**
 	 * Constructor
 	 */
-	ScreenSurface() {}
+	ScreenSurface();
 
 	/**
 	 * Initialise the surface
@@ -73,6 +72,20 @@ public:
 
 	void setPointer(MSurface *s);
 
+	/**
+	 * Copys an area of the screen surface to a given destination position on
+	 * the ScummVM physical screen buffer
+	 * @param destPos	Destination position
+	 * @param bounds	Area of screen surface to copy
+	 */
+	void copyRectToScreen(const Common::Point &destPos, const Common::Rect &bounds);
+
+	/**
+	 * Copys an area of the screen surface to the ScmmVM physical screen buffer
+	 * @param bounds	Area of screen surface to copy
+	 */
+	void copyRectToScreen(const Common::Rect &bounds);
+
 	/**
 	 * Updates the screen with the contents of the surface
 	 */
@@ -83,4 +96,4 @@ public:
 
 } // End of namespace MADS
 
-#endif /* MADS_GRAPHICS_H */
+#endif /* MADS_SCREEN_H */

engines/mads/sprites.cpp

@@ -24,7 +24,7 @@
 #include "engines/util.h"
 #include "graphics/palette.h"
 #include "mads/mads.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/msurface.h"
 #include "mads/sprites.h"
 

engines/mads/user_interface.cpp

@@ -22,7 +22,7 @@
 
 #include "common/scummsys.h"
 #include "mads/mads.h"
-#include "mads/graphics.h"
+#include "mads/screen.h"
 #include "mads/user_interface.h"
 #include "mads/msurface.h"