thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

COMMON: Fix Valgrind warning in PEResources

Browse source 
As with NEResources, _disposeFileHandle was never set.
This commit is contained in:
Torbjörn Andersson 2021-09-06 08:37:25 +02:00 • committed by Eugene Sandulenko
parent 92a2519846
commit 4f20e40409
No known key found for this signature in database
GPG key ID: 014D387312D34F08
1 changed files with 6 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

9
common/winexe_pe.cpp
View file

@ -40,9 +40,11 @@ PEResources::~PEResources() {
void PEResources::clear() {
_sections.clear();
_resources.clear();
if (_disposeFileHandle == DisposeAfterUse::YES)
delete _exe;
_exe = nullptr;
if (_exe) {
if (_disposeFileHandle == DisposeAfterUse::YES)
delete _exe;
_exe = nullptr;
}
}
bool PEResources::loadFromEXE(SeekableReadStream *stream, DisposeAfterUse::Flag disposeFileHandle) {
@ -95,6 +97,7 @@ bool PEResources::loadFromEXE(SeekableReadStream *stream, DisposeAfterUse::Flag
}
_exe = stream;
_disposeFileHandle = disposeFileHandle;
Section &resSection = _sections[".rsrc"];
parseResourceLevel(resSection, resSection.offset, 0);