thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Removed the remaining two FIXME's - my analysis of the data indicates no issues with structure packing, and all multi-byte data accesses are wrapped using loadShort/saveShort, which is endian safe

Browse source 
svn-id: r41096
This commit is contained in:
Paul Gilbert 2009-06-01 08:46:39 +00:00
parent c730e0290d
commit 5bb449b2bf
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
engines/cruise/saveload.cpp
View file

@ -258,7 +258,6 @@ static void syncOverlays2(Common::Serializer &s) {
// save BSS
s.syncAsSint16LE(ovlData->sizeOfData4);
if (ovlData->sizeOfData4)
// FIXME: Endian and structure packing problems for this data pointer
s.syncBytes(ovlData->data4Ptr, ovlData->sizeOfData4);
// save variables
@ -344,8 +343,6 @@ void syncScript(Common::Serializer &s, scriptInstanceStruct *entry) {
s.syncAsSint16LE(ptr->varA);
if (ptr->varA) {
// FIXME: This code is not endian safe, and breaks if struct
// packing changes. Read/write the members one by one instead.
if (s.isLoading())
ptr->var6 = (byte *)mallocAndZero(ptr->varA);
s.syncBytes(ptr->var6, ptr->varA);