thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed a bunch of cppcheck warnings. Mostly about checking if a pointer is null

Browse source 
before freeing it, which isn't necessary.

svn-id: r46941
This commit is contained in:
Torbjörn Andersson 2010-01-03 19:37:43 +00:00
parent 910ffb53a0
commit 72eb9ec9ea
62 changed files with 117 additions and 210 deletions
Download patch file Download diff file Expand all files Collapse all files

5
backends/midi/timidity.cpp
View file

@ -320,13 +320,12 @@ int MidiDriver_TIMIDITY::connect_to_server(const char* hostname, unsigned short
char *MidiDriver_TIMIDITY::timidity_ctl_command(const char *fmt, ...) {
/* XXX: I don't like this static buffer!!! */
static char buff[BUFSIZ];
int status, len;
va_list ap;
if (fmt != NULL) {
/* if argumends are present, write them to control connection */
va_start(ap, fmt);
len = vsnprintf(buff, BUFSIZ-1, fmt, ap); /* leave one byte for \n */
int len = vsnprintf(buff, BUFSIZ-1, fmt, ap); /* leave one byte for \n */
va_end(ap);
/* add newline if needed */
@ -345,7 +344,7 @@ char *MidiDriver_TIMIDITY::timidity_ctl_command(const char *fmt, ...) {
}
/* report errors from server */
status = atoi(buff);
int status = atoi(buff);
if (400 <= status && status <= 499) { /* Error of data stream */
warning("TiMidity: error from server: %s", buff);
continue;