thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GUI: Use after free

Browse source
This commit is contained in:
Bertrand Augereau 2015-11-09 23:56:10 +01:00
parent 06d83f148f
commit 91e6abd305
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
gui/ThemeEngine.cpp
View file

@ -757,8 +757,6 @@ bool ThemeEngine::loadDefaultXML() {
return false; return false;
} }
free(tmpXML);
_themeName = "ScummVM Classic Theme (Builtin Version)"; _themeName = "ScummVM Classic Theme (Builtin Version)";
_themeId = "builtin"; _themeId = "builtin";
_themeFile.clear(); _themeFile.clear();
@ -766,6 +764,8 @@ bool ThemeEngine::loadDefaultXML() {
bool result = _parser->parse(); bool result = _parser->parse();
_parser->close(); _parser->close();
free(tmpXML);
return result; return result;
#else #else
warning("The built-in theme is not enabled in the current build. Please load an external theme"); warning("The built-in theme is not enabled in the current build. Please load an external theme");