thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

DIRECTOR: Add FIXME comments to Sprite::setCast

Browse source
This commit is contained in:
djsrv 2021-07-16 23:18:23 -04:00
parent 307bf94beb
commit 9dfce6ec11
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
engines/director/sprite.cpp
View file

@ -229,7 +229,8 @@ void Sprite::setCast(CastMemberID memberID) {
// WORKAROUND: In D2/D3 there can be text casts that have button
// information set in the sprite.
warning("Sprite::setCast(): Working around D2/3 button glitch");
// FIXME: We should not override the cast member's type here.
// We should only change how the sprite renders.
_cast->_type = kCastButton;
((TextCastMember *)_cast)->_buttonType = (ButtonType)(_spriteType - 8);
}
@ -253,6 +254,8 @@ void Sprite::setCast(CastMemberID memberID) {
// this happens in warlock-mac data/stambul/c up
if (_spriteType == kBitmapSprite && _cast->_type != kCastBitmap) {
warning("Sprite::setCast(): sprite type doesn't match cast type, setting cast member to null");
// FIXME: We should still set the cast number but not render
// the sprite if the types conflict.
_cast = nullptr;
_castId = CastMemberID();
}