thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

TOLTECS: Change the updateScreen() logic a bit

Browse source 
Updating the screen when getMillis() % 10 is 0 seems sub-optimal
to me. It could be true several iterations in a row (shouldn't be
harmful, since updateScreen is assumed to be cheap if the screen
hasn't changed) or we could miss it every single time. Let's
measure the time between updates instead, just to be safer.
This commit is contained in:
Torbjörn Andersson 2011-11-20 23:37:25 +01:00
parent bc4397bf3e
commit 9f5f240e90
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
engines/toltecs/script.cpp
View file

@ -183,6 +183,7 @@ void ScriptInterpreter::setMainScript(uint slotIndex) {
}
void ScriptInterpreter::runScript() {
uint32 lastScreenUpdate = 0;
while (!_vm->shouldQuit()) {
@ -217,9 +218,13 @@ void ScriptInterpreter::runScript() {
byte opcode = readByte();
execOpcode(opcode);
// Call updateScreen roughly every 10ms else the mouse cursor will be jerky
if (_vm->_system->getMillis() % 10 == 0)
// Update the screen at semi-regular intervals, else the mouse
// cursor will be jerky.
uint32 now = _vm->_system->getMillis();
if (now < lastScreenUpdate || now - lastScreenUpdate > 10) {
_vm->_system->updateScreen();
lastScreenUpdate = _vm->_system->getMillis();
}
}