thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SCI: Added a FIXME for bug #3038870, related to kParse()

Browse source 
svn-id: r52497
This commit is contained in:
Filippos Karapetis 2010-09-02 13:50:49 +00:00
parent 054a95498e
commit a816a27928
1 changed files with 9 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

9
engines/sci/engine/kparse.cpp
View file

@ -138,6 +138,15 @@ reg_t kParse(EngineState *s, int argc, reg_t *argv) {
} else { } else {
s->r_acc = make_reg(0, 0); s->r_acc = make_reg(0, 0);
// FIXME: When typing something wrong in the fanmade game Demo Quest,
// after the error dialog, the game checks for claimed to be 0 before
// showing a subsequent dialog. The following selector change causes
// it to be 1, thus causing the game to hang in an endless loop (bug
// #3038870. Thus, this seems to be wrong (since fanmade games use
// the original SCI interpreter), but we need to check against
// dissassembly. Since kParse is in the process of being dissassembled
// again, I'm leaving this FIXME in for now, so that it won't be
// forgotten :)
writeSelectorValue(segMan, event, SELECTOR(claimed), 1); writeSelectorValue(segMan, event, SELECTOR(claimed), 1);
if (error) { if (error) {
s->_segMan->strcpy(voc->parser_base, error); s->_segMan->strcpy(voc->parser_base, error);