thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Unify all string function parameters to be const Common::String &

Browse source 
Thanks to wjp for the suggestion
This commit is contained in:
Filippos Karapetis 2017-03-24 00:35:37 +02:00
parent 1c083fe000
commit a93c8c5d3e
12 changed files with 40 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

8
engines/fullpipe/utils.cpp
View file

@ -33,7 +33,7 @@
namespace Fullpipe {
bool CObject::loadFile(Common::String fname) {
bool CObject::loadFile(const Common::String &fname) {
Common::File file;
if (!file.open(fname))
@ -112,7 +112,7 @@ Common::String MfcArchive::readPascalString(bool twoByte) {
return result;
}
void MfcArchive::writePascalString(Common::String str, bool twoByte) {
void MfcArchive::writePascalString(const Common::String &str, bool twoByte) {
int len = str.size();
if (twoByte)
@ -154,7 +154,7 @@ bool MemoryObject::load(MfcArchive &file) {
return true;
}
void MemoryObject::loadFile(Common::String filename) {
void MemoryObject::loadFile(const Common::String &filename) {
debugC(5, kDebugLoading, "MemoryObject::loadFile(<%s>)", filename.c_str());
if (filename.empty())
@ -501,7 +501,7 @@ Common::String genFileName(int superId, int sceneId, const char *ext) {
}
// Translates cp-1251..utf-8
byte *transCyrillic(Common::String str) {
byte *transCyrillic(const Common::String &str) {
byte *s = (byte *)str.c_str();
static byte tmp[1024];