thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SCI: Add uninit read workarounds for QFG3, QFG4

Browse source 
Fixes bugs #13045, #13046
This commit is contained in:
sluicebox 2021-10-28 18:23:12 -05:00
parent cd834e73ec
commit ab20c9bee2
1 changed files with 3 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
engines/sci/engine/workarounds.cpp
View file

@ -354,6 +354,8 @@ const SciWorkaroundEntry uninitializedReadForParamWorkarounds[] = {
{ GID_HOYLE5, 1100, 22, -1, "HandPile", "show", NULL, 1, 1,{ WORKAROUND_FAKE, 0 } }, // when showing money piles in Poker
{ GID_LAURABOW2, -1, 90, 0, "MuseumRgn", "crowdInRoom", NULL, 3, 4,{ WORKAROUND_FAKE, 0 } }, // When actors walk around the museum. Out-of-bounds parameters are read but not used. Doesn't matter, but generates a lot of warnings.
{ GID_PHANTASMAGORIA2,-1, 63019, 0, "WynDocTextView", "cue", NULL, 2, 2,{ WORKAROUND_FAKE, 0 } }, // When dragging the slider next to an e-mail message
{ GID_QFG3, -1, 28, 0, "hero", "changeGait", NULL, 2, 2,{ WORKAROUND_FAKE, 0 } }, // When ego's walk style is adjusted throughout the game
{ GID_QFG4, -1, 28, 0, "hero", "changeGait", NULL, 1, 2,{ WORKAROUND_FAKE, 0 } }, // When ego's walk style is adjusted throughout the game (some scripts don't pass either parameter)
{ GID_SHIVERS, -1, 64918, 0, "Str", "strip", NULL, 1, 1,{ WORKAROUND_FAKE, 0 } }, // When starting a new game and entering a name
{ GID_SQ4, 35, 928, 0, "Narrator", "say", NULL, 1, 1,{ WORKAROUND_FAKE, 11 } }, // Clicking smell on sidewalk, fixes message due to missing say parameter in sidewalk1:doVerb(6) - bug #10917
SCI_WORKAROUNDENTRY_TERMINATOR
@ -538,6 +540,7 @@ const SciWorkaroundEntry uninitializedReadWorkarounds[] = {
{ GID_QFG3, 490, 490, -1, "computersMove", "changeState", NULL, 0, 0, { WORKAROUND_FAKE, 0 } }, // when finishing awari game, bug #5167
{ GID_QFG3, 490, 490, -1, "computersMove", "changeState", sig_uninitread_qfg3_2, 4, 4, { WORKAROUND_FAKE, 0 } }, // also when finishing awari game
{ GID_QFG3, -1, 32, -1, "ProjObj", "doit", NULL, 1, 1, { WORKAROUND_FAKE, 0 } }, // near the end, when throwing the spear of death or sword, bugs #5282, #11477
{ GID_QFG3, 130, 937, -1, "IconBar", "dispatchEvent", NULL, 58, 58, { WORKAROUND_FAKE, 0 } }, // pressing the Enter key on the main menu screen, bug #13045
{ GID_QFG4, -1, 15, -1, "charInitScreen", "dispatchEvent", NULL, 5, 5, { WORKAROUND_FAKE, 0 } }, // floppy version, when viewing the character screen
{ GID_QFG4, -1, 23, -1, "tellerControls", "dispatchEvent", NULL, 6, 6, { WORKAROUND_FAKE, 0 } }, // floppy version, when using keyboard controls in the conversation interface
{ GID_QFG4, -1, 50, -1, "sSearchMonster", "changeState", NULL, 2, 2, { WORKAROUND_FAKE, 0 } }, // CD version, when searching a chernovy or revenant with speech disabled