thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

AUDIO: Fix ineffective version prop on Miles AdLib

Browse source 
Setting the Miles driver version property to 3 was meant to set the pitch bend
range to 2. In the AdLib driver, the pitch bend range was set during
construction, before the version property could be set, so this did not work
properly. This is fixed by moving the MIDI data initialization from the
constructor to the open function.
This commit is contained in:
Coen Rampen 2021-11-04 22:11:17 +01:00
parent 26751bab97
commit b571a50e19
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
audio/miles_adlib.cpp
View file

@ -308,8 +308,6 @@ MidiDriver_Miles_AdLib::MidiDriver_Miles_AdLib(InstrumentEntry *instrumentTableP
circularPhysicalAssignment = true;
// this way the first circular physical FM-voice search will start at FM-voice 0
circularPhysicalAssignmentFmVoice = MILES_ADLIB_PHYSICAL_FMVOICES_COUNT_MAX;
resetData();
}
MidiDriver_Miles_AdLib::~MidiDriver_Miles_AdLib() {
@ -347,6 +345,8 @@ int MidiDriver_Miles_AdLib::open() {
_isOpen = true;
resetData();
_timerRate = getBaseTempo();
_opl->start(new Common::Functor0Mem<void, MidiDriver_Miles_AdLib>(this, &MidiDriver_Miles_AdLib::onTimer));