thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

TINYGL: Move initialisation code outside of loop

Browse source 
Readability-only change.
Clarifies that these variables will be initialised before they get
accessed in the loop.
Also, initialise update_left and update_right to true, and only clear the
one needed for given triangle.
This commit is contained in:
Vincent Pelletier 2017-05-05 03:15:22 +00:00
parent 218d3214d7
commit bcd1066540
1 changed files with 16 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

40
graphics/tinygl/ztriangle.cpp
View file

@ -124,9 +124,9 @@ void FrameBuffer::fillTriangle(ZBufferPoint *p0, ZBufferPoint *p1, ZBufferPoint
float fdx1, fdx2, fdy1, fdy2, fz0, d1, d2; float fdx1, fdx2, fdy1, fdy2, fz0, d1, d2;
unsigned int *pz1 = NULL; unsigned int *pz1 = NULL;
unsigned char *pm1 = NULL; unsigned char *pm1 = NULL;
int part, update_left, update_right; int part, update_left = 1, update_right = 1;
int nb_lines, dx1, dy1, tmp, dx2, dy2; int nb_lines, dx1, dy1, tmp, dx2, dy2, y;
int error = 0, derror = 0; int error = 0, derror = 0;
int x1 = 0, dxdy_min = 0, dxdy_max = 0; int x1 = 0, dxdy_min = 0, dxdy_max = 0;
@ -278,35 +278,27 @@ void FrameBuffer::fillTriangle(ZBufferPoint *p0, ZBufferPoint *p1, ZBufferPoint
ndtzdx = NB_INTERP * dtzdx; ndtzdx = NB_INTERP * dtzdx;
} }
if (fz0 > 0) {
l1 = p0;
l2 = p2;
pr1 = p0;
pr2 = p1;
} else {
l1 = p0;
l2 = p1;
pr1 = p0;
pr2 = p2;
}
nb_lines = p1->y - p0->y;
y = p0->y;
for (part = 0; part < 2; part++) { for (part = 0; part < 2; part++) {
int y; if (part == 1) {
if (part == 0) {
if (fz0 > 0) {
update_left = 1;
update_right = 1;
l1 = p0;
l2 = p2;
pr1 = p0;
pr2 = p1;
} else {
update_left = 1;
update_right = 1;
l1 = p0;
l2 = p1;
pr1 = p0;
pr2 = p2;
}
nb_lines = p1->y - p0->y;
y = p0->y;
} else {
// second part // second part
if (fz0 > 0) { if (fz0 > 0) {
update_left = 0; update_left = 0;
update_right = 1;
pr1 = p1; pr1 = p1;
pr2 = p2; pr2 = p2;
} else { } else {
update_left = 1;
update_right = 0; update_right = 0;
l1 = p1; l1 = p1;
l2 = p2; l2 = p2;