thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

SCI: Fix bug #3040625 - "SCI: ECOQUEST French/German: Speech balloon graphic glitch"

Browse source 
This bug is caused by the fact that the sprites in that scene and the
speech bubble share the same priority, so we compensate for that with a
workaround
This commit is contained in:
Filippos Karapetis 2012-05-11 12:54:06 +03:00
parent f6acc5d5be
commit c424c22f19
1 changed files with 13 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

13
engines/sci/graphics/view.cpp
View file

@ -720,6 +720,19 @@ void GfxView::draw(const Common::Rect &rect, const Common::Rect &clipRect, const
bitmap += (clipRect.top - rect.top) * celWidth + (clipRect.left - rect.left);
// WORKAROUND: EcoQuest French and German draw the fish and anemone sprites
// with priority 15 in scene 440. Afterwards, a dialog is shown on top of
// these sprites with priority 15 as well. This is undefined behavior
// actually, as the sprites and dialog share the same priority, so in our
// implementation the sprites get drawn incorrectly on top of the dialog.
// Perhaps this worked by mistake in SSCI because of subtle differences in
// how sprites are drawn. We compensate for this by resetting the priority
// of all sprites that have a priority of 15 in scene 440 to priority 14,
// so that the speech bubble can be drawn correctly on top of them. Fixes
// bug #3040625.
if (g_sci->getGameId() == GID_ECOQUEST && g_sci->getEngineState()->currentRoomNumber() == 440 && priority == 15)
priority = 14;
if (!_EGAmapping) {
for (y = 0; y < height; y++, bitmap += celWidth) {
for (x = 0; x < width; x++) {