thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

DEVTOOLS: Remove 'explicit' keyword from multi parameter constructors.

Browse source 
This does not make sense in C++98. For C++11 this only prevents Foo x = {...}
initialization, which we can't use anyway.
This commit is contained in:
Johannes Schickel 2015-12-12 06:25:38 +01:00
parent c9d7299e65
commit d09c3e28a6
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
devtools/create_project/xcode.h
View file

@ -86,16 +86,16 @@ private:
int _indent; int _indent;
int _order; int _order;
explicit Setting(std::string value = "", std::string comment = "", int flgs = 0, int idt = 0, int ord = -1) : _flags(flgs), _indent(idt), _order(ord) { Setting(std::string value = "", std::string comment = "", int flgs = 0, int idt = 0, int ord = -1) : _flags(flgs), _indent(idt), _order(ord) {
_entries.push_back(Entry(value, comment)); _entries.push_back(Entry(value, comment));
} }
explicit Setting(ValueList values, int flgs = 0, int idt = 0, int ord = -1) : _flags(flgs), _indent(idt), _order(ord) { Setting(ValueList values, int flgs = 0, int idt = 0, int ord = -1) : _flags(flgs), _indent(idt), _order(ord) {
for (unsigned int i = 0; i < values.size(); i++) for (unsigned int i = 0; i < values.size(); i++)
_entries.push_back(Entry(values[i], "")); _entries.push_back(Entry(values[i], ""));
} }
explicit Setting(EntryList ents, int flgs = 0, int idt = 0, int ord = -1) : _entries(ents), _flags(flgs), _indent(idt), _order(ord) {} Setting(EntryList ents, int flgs = 0, int idt = 0, int ord = -1) : _entries(ents), _flags(flgs), _indent(idt), _order(ord) {}
void addEntry(std::string value, std::string comment = "") { void addEntry(std::string value, std::string comment = "") {
_entries.push_back(Entry(value, comment)); _entries.push_back(Entry(value, comment));
@ -119,7 +119,7 @@ private:
Property() : _flags(0), _hasOrder(false) {} Property() : _flags(0), _hasOrder(false) {}
// Constructs a simple Property // Constructs a simple Property
explicit Property(std::string name, std::string value = "", std::string comment = "", int flgs = 0, int indent = 0, bool order = false) : _flags(flgs), _hasOrder(order) { Property(std::string name, std::string value = "", std::string comment = "", int flgs = 0, int indent = 0, bool order = false) : _flags(flgs), _hasOrder(order) {
_settings[name] = Setting(value, comment, _flags, indent); _settings[name] = Setting(value, comment, _flags, indent);
} }