- Updated MSVC8 project files

- Renamed base/options.cpp to base/commandLine.cpp because of conflict
  with gui/options.cpp which sit in same directory in MSVC builds
- Moved AudioCDManager singleton declaration outside of Audio namespace
- Fixed numerous MSVC warning of potentially uninitialized variables and
  int <-> bool conversions.

svn-id: r22397

backends/sdl/sdl.cpp

@@ -35,7 +35,7 @@
 #if !defined(_WIN32_WCE) && !defined(__MAEMO__)
 
 #if defined (WIN32)
-int WinMain(HINSTANCE /*hInst*/, HINSTANCE /*hPrevInst*/,  LPSTR /*lpCmdLine*/, int /*iShowCmd*/) {
+int __stdcall WinMain(HINSTANCE /*hInst*/, HINSTANCE /*hPrevInst*/,  LPSTR /*lpCmdLine*/, int /*iShowCmd*/) {
 	SDL_SetModuleHandle(GetModuleHandle(NULL));
 	return main(__argc, __argv);
 }
@@ -102,7 +102,6 @@ int main(int argc, char *argv[]) {
 }
 #endif
 
-
 void OSystem_SDL::initBackend() {
 	assert(!_inited);
 

base/commandLine.cpp

@@ -24,7 +24,7 @@
 #include "common/stdafx.h"
 
 #include "base/engine.h"
-#include "base/options.h"
+#include "base/commandLine.h"
 #include "base/plugins.h"
 #include "base/version.h"
 

base/main.cpp

@@ -32,7 +32,7 @@
 #include "common/stdafx.h"
 #include "backends/fs/fs.h"
 #include "base/engine.h"
-#include "base/options.h"
+#include "base/commandLine.h"
 #include "base/plugins.h"
 #include "base/version.h"
 #include "common/config-manager.h"

base/module.mk

@@ -3,7 +3,7 @@ MODULE := base
 MODULE_OBJS := \
 	engine.o \
 	main.o \
-	options.o \
+	commandLine.o \
 	plugins.o \
 	version.o
 

dists/msvc8/gob.vcproj

@@ -190,6 +190,14 @@
 			RelativePath="..\..\engines\gob\draw.h"
 			>
 		</File>
+		<File
+			RelativePath="..\..\engines\gob\draw_v1.cpp"
+			>
+		</File>
+		<File
+			RelativePath="..\..\engines\gob\draw_v2.cpp"
+			>
+		</File>
 		<File
 			RelativePath="..\..\engines\gob\driver_vga.cpp"
 			>
@@ -206,6 +214,14 @@
 			RelativePath="..\..\engines\gob\game.h"
 			>
 		</File>
+		<File
+			RelativePath="..\..\engines\gob\game_v1.cpp"
+			>
+		</File>
+		<File
+			RelativePath="..\..\engines\gob\game_v2.cpp"
+			>
+		</File>
 		<File
 			RelativePath="..\..\engines\gob\global.cpp"
 			>
@@ -238,6 +254,14 @@
 			RelativePath="..\..\engines\gob\init.h"
 			>
 		</File>
+		<File
+			RelativePath="..\..\engines\gob\init_v1.cpp"
+			>
+		</File>
+		<File
+			RelativePath="..\..\engines\gob\init_v2.cpp"
+			>
+		</File>
 		<File
 			RelativePath="..\..\engines\gob\inter.cpp"
 			>
@@ -358,6 +382,14 @@
 			RelativePath="..\..\engines\gob\video.h"
 			>
 		</File>
+		<File
+			RelativePath="..\..\engines\gob\video_v1.cpp"
+			>
+		</File>
+		<File
+			RelativePath="..\..\engines\gob\video_v2.cpp"
+			>
+		</File>
 	</Files>
 	<Globals>
 	</Globals>

dists/msvc8/kyra.vcproj

@@ -190,6 +190,10 @@
 			RelativePath="..\..\engines\kyra\kyra.h"
 			>
 		</File>
+		<File
+			RelativePath="..\..\engines\kyra\plugin.cpp"
+			>
+		</File>
 		<File
 			RelativePath="..\..\engines\kyra\resource.cpp"
 			>

dists/msvc8/scumm.vcproj

@@ -310,6 +310,14 @@
 		<Filter
 			Name="he"
 			>
+			<File
+				RelativePath="..\..\engines\scumm\he\animation_he.cpp"
+				>
+			</File>
+			<File
+				RelativePath="..\..\engines\scumm\he\animation_he.h"
+				>
+			</File>
 			<File
 				RelativePath="..\..\engines\scumm\he\floodfill_he.cpp"
 				>
@@ -418,6 +426,18 @@
 				RelativePath="..\..\engines\scumm\imuse\instrument.h"
 				>
 			</File>
+			<File
+				RelativePath="..\..\engines\scumm\imuse\sysex.h"
+				>
+			</File>
+			<File
+				RelativePath="..\..\engines\scumm\imuse\sysex_samnmax.cpp"
+				>
+			</File>
+			<File
+				RelativePath="..\..\engines\scumm\imuse\sysex_scumm.cpp"
+				>
+			</File>
 		</Filter>
 		<File
 			RelativePath="..\..\engines\scumm\actor.cpp"

dists/msvc8/scummvm.vcproj

@@ -70,10 +70,10 @@
 				AdditionalDependencies="winmm.lib sdl.lib zdll.lib libmad.lib vorbisfile_static.lib vorbis_static.lib ogg_static.lib libmpeg2.lib sword1_debug/sword1.lib sword2_debug/sword2.lib lure_debug/lure.lib cine_debug/cine.lib kyra_debug/kyra.lib gob_debug/gob.lib queen_debug/queen.lib saga_debug/saga.lib scumm_debug/scumm.lib simon_debug/simon.lib sky_debug/sky.lib"
 				OutputFile="$(OutDir)/scummvm.exe"
 				LinkIncremental="2"
-				IgnoreDefaultLibraryNames="libc.lib"
+				IgnoreDefaultLibraryNames="libc.lib;libcmt.lib"
 				GenerateDebugInformation="true"
 				ProgramDatabaseFile="$(OutDir)/scummvm.pdb"
-				SubSystem="1"
+				SubSystem="2"
 				TargetMachine="1"
 			/>
 			<Tool
@@ -161,7 +161,7 @@
 				SuppressStartupBanner="true"
 				IgnoreDefaultLibraryNames="libc.lib"
 				GenerateDebugInformation="false"
-				SubSystem="1"
+				SubSystem="2"
 				OptimizeReferences="2"
 				EnableCOMDATFolding="2"
 				TargetMachine="1"
@@ -198,6 +198,14 @@
 		<Filter
 			Name="base"
 			>
+			<File
+				RelativePath="..\..\base\commandLine.cpp"
+				>
+			</File>
+			<File
+				RelativePath="..\..\base\commandLine.h"
+				>
+			</File>
 			<File
 				RelativePath="..\..\base\engine.cpp"
 				>
@@ -207,17 +215,21 @@
 				>
 			</File>
 			<File
-				RelativePath="..\..\base\options.cpp"
+				RelativePath="..\..\base\game.h"
 				>
 			</File>
 			<File
-				RelativePath="..\..\base\options.h"
+				RelativePath="..\..\base\internal_version.h"
 				>
 			</File>
 			<File
 				RelativePath="..\..\base\main.cpp"
 				>
 			</File>
+			<File
+				RelativePath="..\..\base\main.h"
+				>
+			</File>
 			<File
 				RelativePath="..\..\base\plugins.cpp"
 				>
@@ -226,6 +238,10 @@
 				RelativePath="..\..\base\plugins.h"
 				>
 			</File>
+			<File
+				RelativePath="..\..\base\version.cpp"
+				>
+			</File>
 			<File
 				RelativePath="..\..\base\version.h"
 				>
@@ -275,11 +291,15 @@
 				>
 			</File>
 			<File
-				RelativePath="..\..\common\list.h"
+				RelativePath="..\..\common\hashmap.cpp"
 				>
 			</File>
 			<File
-				RelativePath="..\..\common\map.h"
+				RelativePath="..\..\common\hashmap.h"
+				>
+			</File>
+			<File
+				RelativePath="..\..\common\list.h"
 				>
 			</File>
 			<File
@@ -813,6 +833,14 @@
 				RelativePath="..\..\gui\EditTextWidget.h"
 				>
 			</File>
+			<File
+				RelativePath="..\..\gui\eval.cpp"
+				>
+			</File>
+			<File
+				RelativePath="..\..\gui\eval.h"
+				>
+			</File>
 			<File
 				RelativePath="..\..\gui\Key.cpp"
 				>
@@ -889,6 +917,10 @@
 				RelativePath="..\..\gui\TabWidget.h"
 				>
 			</File>
+			<File
+				RelativePath="..\..\gui\theme-config.cpp"
+				>
+			</File>
 			<File
 				RelativePath="..\..\gui\theme.cpp"
 				>
@@ -897,6 +929,10 @@
 				RelativePath="..\..\gui\theme.h"
 				>
 			</File>
+			<File
+				RelativePath="..\..\gui\ThemeClassic.cpp"
+				>
+			</File>
 			<File
 				RelativePath="..\..\gui\ThemeNew.cpp"
 				>

dists/msvc8/simon.vcproj

@@ -159,6 +159,14 @@
 	<References>
 	</References>
 	<Files>
+		<File
+			RelativePath="..\..\engines\simon\animation.cpp"
+			>
+		</File>
+		<File
+			RelativePath="..\..\engines\simon\animation.h"
+			>
+		</File>
 		<File
 			RelativePath="..\..\engines\simon\charset.cpp"
 			>
@@ -183,6 +191,14 @@
 			RelativePath="..\..\engines\simon\debugger.h"
 			>
 		</File>
+		<File
+			RelativePath="..\..\engines\simon\draw.cpp"
+			>
+		</File>
+		<File
+			RelativePath="..\..\engines\simon\event.cpp"
+			>
+		</File>
 		<File
 			RelativePath="..\..\engines\simon\game.cpp"
 			>
@@ -239,6 +255,14 @@
 			RelativePath="..\..\engines\simon\sound.h"
 			>
 		</File>
+		<File
+			RelativePath="..\..\engines\simon\string.cpp"
+			>
+		</File>
+		<File
+			RelativePath="..\..\engines\simon\subroutine.cpp"
+			>
+		</File>
 		<File
 			RelativePath="..\..\engines\simon\verb.cpp"
 			>
@@ -251,6 +275,10 @@
 			RelativePath="..\..\engines\simon\vga.h"
 			>
 		</File>
+		<File
+			RelativePath="..\..\engines\simon\window.cpp"
+			>
+		</File>
 	</Files>
 	<Globals>
 	</Globals>

dists/msvc8/sword2.vcproj

@@ -186,10 +186,6 @@
 			RelativePath="..\..\engines\sword2\controls.h"
 			>
 		</File>
-		<File
-			RelativePath="..\..\engines\sword2\d_draw.cpp"
-			>
-		</File>
 		<File
 			RelativePath="..\..\engines\sword2\debug.cpp"
 			>
@@ -282,10 +278,6 @@
 			RelativePath="..\..\engines\sword2\protocol.cpp"
 			>
 		</File>
-		<File
-			RelativePath="..\..\engines\sword2\rdwin.cpp"
-			>
-		</File>
 		<File
 			RelativePath="..\..\engines\sword2\render.cpp"
 			>

dists/scummvm.rc

@@ -1,6 +1,6 @@
 #include "winresrc.h"
 
-IDI_ICON               ICON    DISCARDABLE     "icons/scummvm.ico"
+IDI_ICON               ICON    DISCARDABLE     "../../icons/scummvm.ico"
 
 VS_VERSION_INFO VERSIONINFO
  FILEVERSION 0,9,0,0

dists/scummvm.rc.in

@@ -1,6 +1,6 @@
 #include "winresrc.h"
 
-IDI_ICON               ICON    DISCARDABLE     "icons/scummvm.ico"
+IDI_ICON               ICON    DISCARDABLE     "../../icons/scummvm.ico"
 
 VS_VERSION_INFO VERSIONINFO
  FILEVERSION @VER_MAJOR@,@VER_MINOR@,@VER_PATCH@,0

engines/scumm/charset.cpp

@@ -1201,7 +1201,7 @@ void CharsetRendererCommon::enableShadow(bool enable) {
 
 void CharsetRendererV3::printChar(int chr, bool ignoreCharsetMask) {
 	// Indy3 / Zak256 / Loom
-	int width, height, origWidth, origHeight;
+	int width, height, origWidth = 0, origHeight;
 	VirtScreen *vs;
 	byte *charPtr, *dst;
 	int is2byte = (chr >= 0x80 && _vm->_useCJKMode) ? 1 : 0;

engines/scumm/script.cpp

@@ -606,7 +606,7 @@ void ScummEngine::writeVar(uint var, int value) {
 			if (_game.heversion <= 73 && vm.slot[_currentScript].number == 1)
 				return;
 			assert(value == 0 || value == 1);
-			ConfMan.setBool("subtitles", value);
+			ConfMan.setBool("subtitles", (value != 0));
 		}
 		if (VAR_NOSUBTITLES != 0xFF && var == VAR_NOSUBTITLES) {
 			// Ignore default setting in HE60-71 games

engines/simon/oracle.cpp

@@ -386,7 +386,7 @@ void SimonEngine::saveUserGame(int slot) {
 		}
 		if (_keyPressed == 10 || _keyPressed == 13) {
 			if (!saveGame(readVariable(55), name))
-				_variableArray[55] = 0xFFFF;
+				_variableArray[55] = (int16)0xFFFF;
 			else
 				_variableArray[55] = 0;
 			break;

graphics/font.cpp

@@ -172,8 +172,8 @@ NewFontData* bdf_read_font(Common::SeekableReadStream &fp) {
 
 /* read bdf font header information, return 0 on error*/
 int bdf_read_header(Common::SeekableReadStream &fp, NewFontData* pf) {
-	int encoding;
+	int encoding = 0;
-	int nchars, maxwidth;
+	int nchars = 0, maxwidth;
 	int firstchar = 65535;
 	int lastchar = -1;
 	char buf[256];
@@ -308,8 +308,8 @@ int bdf_read_header(Common::SeekableReadStream &fp, NewFontData* pf) {
 int bdf_read_bitmaps(Common::SeekableReadStream &fp, NewFontData* pf) {
 	long ofs = 0;
 	int maxwidth = 0;
-	int i, k, encoding, width;
+	int i, k, encoding = 0, width = 0;
-	int bbw, bbh, bbx, bby;
+	int bbw, bbh = 0, bbx = 0, bby = 0;
 	int proportional = 0;
 	int encodetable = 0;
 	long l;
@@ -627,7 +627,7 @@ NewFont *NewFont::loadFromCache(Common::SeekableReadStream &stream) {
 		data->bits[i] = stream.readUint16BE();
 	}
 
-	bool hasOffsetTable = stream.readByte();
+	bool hasOffsetTable = (stream.readByte() != 0);
 	if (hasOffsetTable) {
 		data->offset = (unsigned long*)malloc(sizeof(unsigned long)*data->size);
 		if (!data->offset) {
@@ -641,7 +641,7 @@ NewFont *NewFont::loadFromCache(Common::SeekableReadStream &stream) {
 		}
 	}
 
-	bool hasWidthTable = stream.readByte();
+	bool hasWidthTable = (stream.readByte() != 0);
 	if (hasWidthTable) {
 		data->width = (unsigned char*)malloc(sizeof(unsigned char)*data->size);
 		if (!data->width) {

sound/audiocd.cpp

@@ -31,6 +31,8 @@
 #include "common/util.h"
 #include "common/system.h"
 
+DECLARE_SINGLETON(Audio::AudioCDManager);
+
 namespace Audio {
 
 struct TrackFormat {
@@ -61,8 +63,6 @@ static const TrackFormat TRACK_FORMATS[] = {
 };
 
 
-DECLARE_SINGLETON(AudioCDManager);
-
 AudioCDManager::AudioCDManager() {
 	memset(&_cd, 0, sizeof(_cd));
 	memset(_cachedTracks, 0, sizeof(_cachedTracks));