BACKENDS: Make OSystem::setMouseCursor take a "const void *" buffer.

This is mainly for consistency with OSystem::copyRectToScreen.
This commit is contained in:
Johannes Schickel 2012-06-16 03:10:43 +02:00
parent 58bf8090cc
commit d27d951d0b
27 changed files with 35 additions and 35 deletions

View file

@ -80,7 +80,7 @@ public:
virtual bool showMouse(bool visible) = 0; virtual bool showMouse(bool visible) = 0;
virtual void warpMouse(int x, int y) = 0; virtual void warpMouse(int x, int y) = 0;
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL) = 0; virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL) = 0;
virtual void setCursorPalette(const byte *colors, uint start, uint num) = 0; virtual void setCursorPalette(const byte *colors, uint start, uint num) = 0;
virtual void displayMessageOnOSD(const char *msg) {} virtual void displayMessageOnOSD(const char *msg) {}

View file

@ -78,7 +78,7 @@ public:
bool showMouse(bool visible) { return !visible; } bool showMouse(bool visible) { return !visible; }
void warpMouse(int x, int y) {} void warpMouse(int x, int y) {}
void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL) {} void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL) {}
void setCursorPalette(const byte *colors, uint start, uint num) {} void setCursorPalette(const byte *colors, uint start, uint num) {}
}; };

View file

@ -591,7 +591,7 @@ void OpenGLGraphicsManager::warpMouse(int x, int y) {
setInternalMousePosition(scaledX, scaledY); setInternalMousePosition(scaledX, scaledY);
} }
void OpenGLGraphicsManager::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void OpenGLGraphicsManager::setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
#ifdef USE_RGB_COLOR #ifdef USE_RGB_COLOR
if (format) if (format)
_cursorFormat = *format; _cursorFormat = *format;

View file

@ -104,7 +104,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL); virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL);
virtual void setCursorPalette(const byte *colors, uint start, uint num); virtual void setCursorPalette(const byte *colors, uint start, uint num);
virtual void displayMessageOnOSD(const char *msg); virtual void displayMessageOnOSD(const char *msg);

View file

@ -1715,7 +1715,7 @@ void SurfaceSdlGraphicsManager::warpMouse(int x, int y) {
} }
} }
void SurfaceSdlGraphicsManager::setMouseCursor(const byte *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void SurfaceSdlGraphicsManager::setMouseCursor(const void *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
#ifdef USE_RGB_COLOR #ifdef USE_RGB_COLOR
if (!format) if (!format)
_cursorFormat = Graphics::PixelFormat::createFormatCLUT8(); _cursorFormat = Graphics::PixelFormat::createFormatCLUT8();

View file

@ -131,7 +131,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL); virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL);
virtual void setCursorPalette(const byte *colors, uint start, uint num); virtual void setCursorPalette(const byte *colors, uint start, uint num);
#ifdef USE_OSD #ifdef USE_OSD

View file

@ -1129,7 +1129,7 @@ void WINCESdlGraphicsManager::copyRectToScreen(const void *buf, int pitch, int x
SDL_UnlockSurface(_screen); SDL_UnlockSurface(_screen);
} }
void WINCESdlGraphicsManager::setMouseCursor(const byte *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void WINCESdlGraphicsManager::setMouseCursor(const void *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
undrawMouse(); undrawMouse();
if (w == 0 || h == 0) if (w == 0 || h == 0)

View file

@ -73,7 +73,7 @@ public:
void internDrawMouse(); void internDrawMouse();
void undrawMouse(); void undrawMouse();
bool showMouse(bool visible); bool showMouse(bool visible);
void setMouseCursor(const byte *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format); // overloaded by CE backend void setMouseCursor(const void *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format); // overloaded by CE backend
void copyRectToOverlay(const OverlayColor *buf, int pitch, int x, int y, int w, int h); void copyRectToOverlay(const OverlayColor *buf, int pitch, int x, int y, int w, int h);
void copyRectToScreen(const void *buf, int pitch, int x, int y, int w, int h); // overloaded by CE backend (FIXME) void copyRectToScreen(const void *buf, int pitch, int x, int y, int w, int h); // overloaded by CE backend (FIXME)
Graphics::Surface *lockScreen(); Graphics::Surface *lockScreen();

View file

@ -195,7 +195,7 @@ void ModularBackend::warpMouse(int x, int y) {
_graphicsManager->warpMouse(x, y); _graphicsManager->warpMouse(x, y);
} }
void ModularBackend::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void ModularBackend::setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
_graphicsManager->setMouseCursor(buf, w, h, hotspotX, hotspotY, keycolor, dontScale, format); _graphicsManager->setMouseCursor(buf, w, h, hotspotX, hotspotY, keycolor, dontScale, format);
} }

View file

@ -100,7 +100,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL); virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL);
virtual void setCursorPalette(const byte *colors, uint start, uint num); virtual void setCursorPalette(const byte *colors, uint start, uint num);
//@} //@}

View file

@ -267,7 +267,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX,
int hotspotY, uint32 keycolor, int hotspotY, uint32 keycolor,
bool dontScale, bool dontScale,
const Graphics::PixelFormat *format); const Graphics::PixelFormat *format);

View file

@ -685,7 +685,7 @@ bool OSystem_Android::showMouse(bool visible) {
return true; return true;
} }
void OSystem_Android::setMouseCursor(const byte *buf, uint w, uint h, void OSystem_Android::setMouseCursor(const void *buf, uint w, uint h,
int hotspotX, int hotspotY, int hotspotX, int hotspotY,
uint32 keycolor, bool dontScale, uint32 keycolor, bool dontScale,
const Graphics::PixelFormat *format) { const Graphics::PixelFormat *format) {
@ -741,7 +741,7 @@ void OSystem_Android::setMouseCursor(const byte *buf, uint w, uint h,
byte *tmp = new byte[pitch * h]; byte *tmp = new byte[pitch * h];
// meh, a 16bit cursor without alpha bits... this is so silly // meh, a 16bit cursor without alpha bits... this is so silly
if (!crossBlit(tmp, buf, pitch, w * 2, w, h, if (!crossBlit(tmp, (const byte *)buf, pitch, w * 2, w, h,
_mouse_texture->getPixelFormat(), _mouse_texture->getPixelFormat(),
*format)) { *format)) {
LOGE("crossblit failed"); LOGE("crossblit failed");

View file

@ -142,7 +142,7 @@ public:
void warpMouse(int x, int y); void warpMouse(int x, int y);
// Set the bitmap that's used when drawing the cursor. // Set the bitmap that's used when drawing the cursor.
void setMouseCursor(const byte *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format); void setMouseCursor(const void *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format);
// Replace the specified range of cursor the palette with new colors. // Replace the specified range of cursor the palette with new colors.
void setCursorPalette(const byte *colors, uint start, uint num); void setCursorPalette(const byte *colors, uint start, uint num);

View file

@ -292,7 +292,7 @@ void OSystem_Dreamcast::warpMouse(int x, int y)
_ms_cur_y = y; _ms_cur_y = y;
} }
void OSystem_Dreamcast::setMouseCursor(const byte *buf, uint w, uint h, void OSystem_Dreamcast::setMouseCursor(const void *buf, uint w, uint h,
int hotspot_x, int hotspot_y, int hotspot_x, int hotspot_y,
uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format)
{ {

View file

@ -580,7 +580,7 @@ bool OSystem_DS::showMouse(bool visible) {
void OSystem_DS::warpMouse(int x, int y) { void OSystem_DS::warpMouse(int x, int y) {
} }
void OSystem_DS::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, u32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void OSystem_DS::setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, u32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
if ((w > 0) && (w < 64) && (h > 0) && (h < 64)) { if ((w > 0) && (w < 64) && (h > 0) && (h < 64)) {
memcpy(_cursorImage, buf, w * h); memcpy(_cursorImage, buf, w * h);
_cursorW = w; _cursorW = w;

View file

@ -114,7 +114,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, u32 keycolor, bool dontScale, const Graphics::PixelFormat *format); virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, u32 keycolor, bool dontScale, const Graphics::PixelFormat *format);
virtual bool pollEvent(Common::Event &event); virtual bool pollEvent(Common::Event &event);
virtual uint32 getMillis(); virtual uint32 getMillis();

View file

@ -161,7 +161,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor = 255, bool dontScale = false, const Graphics::PixelFormat *format = NULL); virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor = 255, bool dontScale = false, const Graphics::PixelFormat *format = NULL);
virtual void setCursorPalette(const byte *colors, uint start, uint num); virtual void setCursorPalette(const byte *colors, uint start, uint num);
virtual bool pollEvent(Common::Event &event); virtual bool pollEvent(Common::Event &event);

View file

@ -399,7 +399,7 @@ void OSystem_IPHONE::dirtyFullOverlayScreen() {
} }
} }
void OSystem_IPHONE::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void OSystem_IPHONE::setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
//printf("setMouseCursor(%p, %u, %u, %i, %i, %u, %d, %p)\n", (const void *)buf, w, h, hotspotX, hotspotY, keycolor, dontScale, (const void *)format); //printf("setMouseCursor(%p, %u, %u, %i, %i, %u, %d, %p)\n", (const void *)buf, w, h, hotspotX, hotspotY, keycolor, dontScale, (const void *)format);
const Graphics::PixelFormat pixelFormat = format ? *format : Graphics::PixelFormat::createFormatCLUT8(); const Graphics::PixelFormat pixelFormat = format ? *format : Graphics::PixelFormat::createFormatCLUT8();

View file

@ -182,7 +182,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format); virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format);
virtual void setCursorPalette(const byte *colors, uint start, uint num); virtual void setCursorPalette(const byte *colors, uint start, uint num);
virtual bool pollEvent(Common::Event &event); virtual bool pollEvent(Common::Event &event);

View file

@ -774,7 +774,7 @@ void OSystem_N64::warpMouse(int x, int y) {
_dirtyOffscreen = true; _dirtyOffscreen = true;
} }
void OSystem_N64::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void OSystem_N64::setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
if (!w || !h) return; if (!w || !h) return;
_mouseHotspotX = hotspotX; _mouseHotspotX = hotspotX;

View file

@ -618,8 +618,8 @@ void OSystem_PS2::warpMouse(int x, int y) {
_screen->setMouseXy(x, y); _screen->setMouseXy(x, y);
} }
void OSystem_PS2::setMouseCursor(const byte *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void OSystem_PS2::setMouseCursor(const void *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
_screen->setMouseOverlay(buf, w, h, hotspot_x, hotspot_y, keycolor); _screen->setMouseOverlay((const byte *)buf, w, h, hotspot_x, hotspot_y, keycolor);
} }
void OSystem_PS2::showOverlay(void) { void OSystem_PS2::showOverlay(void) {

View file

@ -80,7 +80,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = 0); virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspot_x, int hotspot_y, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = 0);
virtual uint32 getMillis(); virtual uint32 getMillis();
virtual void delayMillis(uint msecs); virtual void delayMillis(uint msecs);

View file

@ -303,7 +303,7 @@ void OSystem_PSP::warpMouse(int x, int y) {
_cursor.setXY(x, y); _cursor.setXY(x, y);
} }
void OSystem_PSP::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) { void OSystem_PSP::setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format) {
DEBUG_ENTER_FUNC(); DEBUG_ENTER_FUNC();
_displayManager.waitUntilRenderFinished(); _displayManager.waitUntilRenderFinished();
_pendingUpdate = false; _pendingUpdate = false;
@ -320,7 +320,7 @@ void OSystem_PSP::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX,
_cursor.setSizeAndScummvmPixelFormat(w, h, format); _cursor.setSizeAndScummvmPixelFormat(w, h, format);
_cursor.setHotspot(hotspotX, hotspotY); _cursor.setHotspot(hotspotX, hotspotY);
_cursor.clearKeyColor(); _cursor.clearKeyColor();
_cursor.copyFromArray(buf); _cursor.copyFromArray((const byte *)buf);
} }
bool OSystem_PSP::pollEvent(Common::Event &event) { bool OSystem_PSP::pollEvent(Common::Event &event) {

View file

@ -118,7 +118,7 @@ public:
// Mouse related // Mouse related
bool showMouse(bool visible); bool showMouse(bool visible);
void warpMouse(int x, int y); void warpMouse(int x, int y);
void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format); void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale, const Graphics::PixelFormat *format);
// Events and input // Events and input
bool pollEvent(Common::Event &event); bool pollEvent(Common::Event &event);

View file

@ -187,7 +187,7 @@ public:
virtual bool showMouse(bool visible); virtual bool showMouse(bool visible);
virtual void warpMouse(int x, int y); virtual void warpMouse(int x, int y);
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX,
int hotspotY, uint32 keycolor, int hotspotY, uint32 keycolor,
bool dontScale, bool dontScale,
const Graphics::PixelFormat *format); const Graphics::PixelFormat *format);

View file

@ -643,7 +643,7 @@ void OSystem_Wii::warpMouse(int x, int y) {
_mouseY = y; _mouseY = y;
} }
void OSystem_Wii::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, void OSystem_Wii::setMouseCursor(const void *buf, uint w, uint h, int hotspotX,
int hotspotY, uint32 keycolor, int hotspotY, uint32 keycolor,
bool dontScale, bool dontScale,
const Graphics::PixelFormat *format) { const Graphics::PixelFormat *format) {
@ -686,7 +686,7 @@ void OSystem_Wii::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX,
tmpBuf = true; tmpBuf = true;
if (!tmpBuf) { if (!tmpBuf) {
gfx_tex_convert(&_texMouse, buf); gfx_tex_convert(&_texMouse, (const byte *)buf);
} else { } else {
u8 bpp = _texMouse.bpp >> 3; u8 bpp = _texMouse.bpp >> 3;
byte *tmp = (byte *) malloc(tw * th * bpp); byte *tmp = (byte *) malloc(tw * th * bpp);
@ -703,7 +703,7 @@ void OSystem_Wii::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX,
#ifdef USE_RGB_COLOR #ifdef USE_RGB_COLOR
if (bpp > 1) { if (bpp > 1) {
if (!Graphics::crossBlit(tmp, buf, if (!Graphics::crossBlit(tmp, (const byte *)buf,
tw * _pfRGB3444.bytesPerPixel, tw * _pfRGB3444.bytesPerPixel,
w * _pfCursor.bytesPerPixel, w * _pfCursor.bytesPerPixel,
tw, th, _pfRGB3444, _pfCursor)) { tw, th, _pfRGB3444, _pfCursor)) {
@ -727,10 +727,10 @@ void OSystem_Wii::setMouseCursor(const byte *buf, uint w, uint h, int hotspotX,
} else { } else {
#endif #endif
byte *dst = tmp; byte *dst = tmp;
const byte *src = (const byte *)buf;
do { do {
memcpy(dst, buf, w * bpp); memcpy(dst, src, w * bpp);
buf += w * bpp; src += w * bpp;
dst += tw * bpp; dst += tw * bpp;
} while (--h); } while (--h);
#ifdef USE_RGB_COLOR #ifdef USE_RGB_COLOR

View file

@ -874,7 +874,7 @@ public:
* would be too small to notice otherwise, these are allowed to scale the cursor anyway. * would be too small to notice otherwise, these are allowed to scale the cursor anyway.
* @param format pointer to the pixel format which cursor graphic uses (0 means CLUT8) * @param format pointer to the pixel format which cursor graphic uses (0 means CLUT8)
*/ */
virtual void setMouseCursor(const byte *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL) = 0; virtual void setMouseCursor(const void *buf, uint w, uint h, int hotspotX, int hotspotY, uint32 keycolor, bool dontScale = false, const Graphics::PixelFormat *format = NULL) = 0;
/** /**
* Replace the specified range of cursor the palette with new colors. * Replace the specified range of cursor the palette with new colors.