thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ENGINES: Remove getExtraGuiOptions from MetaEngine

Browse source
This commit is contained in:
Cameron Cawley 2021-08-10 23:43:03 +01:00 • committed by Eugene Sandulenko
parent f24bffab48
commit d79f1eb55e
2 changed files with 6 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

9
engines/metaengine.cpp
View file

@ -372,15 +372,6 @@ GUI::OptionsContainerWidget *MetaEngineDetection::buildEngineOptionsWidgetStatic
return new GUI::ExtraGuiOptionsWidget(boss, name, target, engineOptions); return new GUI::ExtraGuiOptionsWidget(boss, name, target, engineOptions);
} }
GUI::OptionsContainerWidget *MetaEngine::buildEngineOptionsWidgetDynamic(GUI::GuiObject *boss, const Common::String &name, const Common::String &target) const {
const ExtraGuiOptions engineOptions = getExtraGuiOptions(target);
if (engineOptions.empty()) {
return nullptr;
}
return new GUI::ExtraGuiOptionsWidget(boss, name, target, engineOptions);
}
void MetaEngine::removeSaveState(const char *target, int slot) const { void MetaEngine::removeSaveState(const char *target, int slot) const {
if (!hasFeature(kSavesUseExtendedFormat)) if (!hasFeature(kSavesUseExtendedFormat))
return; return;

21
engines/metaengine.h
View file

@ -368,30 +368,21 @@ public:
*/ */
virtual Common::Array<Common::Keymap *> initKeymaps(const char *target) const; virtual Common::Array<Common::Keymap *> initKeymaps(const char *target) const;
/**
* Return the extra GUI options used by the target.
*/
virtual const ExtraGuiOptions getExtraGuiOptions(const Common::String &target) const {
return ExtraGuiOptions();
}
/** /**
* Return a GUI widget container for configuring the specified target options. * Return a GUI widget container for configuring the specified target options.
* *
* Engines can build custom option dialogs from here, but by default a simple widget * Engines can build custom option dialogs from here.
* allowing to configure the extra GUI options is used.
* *
* The engine that builds the Engines tab in the Edit Game dialog uses a MetaEngineDetection. * Engines that don't have an Engine tab in the Edit Game dialog, or that use
* The engine that specifies a custom dialog when a game is running uses a MetaEngine. * ExtraGuiOptions in MetaEngineDetection can return nullptr.
*
* Engines are not supposed to have an Engine tab in the Edit Game dialog
* can return nullptr.
* *
* @param boss The widget or dialog that the returned widget is a child of. * @param boss The widget or dialog that the returned widget is a child of.
* @param name The name that the returned widget must use. * @param name The name that the returned widget must use.
* @param target Name of a config manager target. * @param target Name of a config manager target.
*/ */
virtual GUI::OptionsContainerWidget *buildEngineOptionsWidgetDynamic(GUI::GuiObject *boss, const Common::String &name, const Common::String &target) const; virtual GUI::OptionsContainerWidget *buildEngineOptionsWidgetDynamic(GUI::GuiObject *boss, const Common::String &name, const Common::String &target) const {
return nullptr;
}
/** /**
* MetaEngine feature flags. * MetaEngine feature flags.