thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

GUI: Fix minor issues for code review

Browse source
This commit is contained in:
lb_ii 2021-05-31 23:45:36 +03:00 • committed by lolbot-iichan
parent 9c699358ea
commit d7afb6408a
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
engines/dialogs.cpp
View file

@ -334,11 +334,11 @@ ConfigDialog::ConfigDialog() :
// The Achievements & The Statistics tabs // The Achievements & The Statistics tabs
// //
Common::AchievementsInfo achievementsInfo = metaEngine->getAchievementsInfo(gameDomain); Common::AchievementsInfo achievementsInfo = metaEngine->getAchievementsInfo(gameDomain);
if (achievementsInfo.descriptions.size() > 0) { if (!achievementsInfo.descriptions.empty()) {
tab->addTab(_("Achievements"), "GlobalConfig_Achievements"); tab->addTab(_("Achievements"), "GlobalConfig_Achievements");
addAchievementsControls(tab, "GlobalConfig_Achievements.", achievementsInfo); addAchievementsControls(tab, "GlobalConfig_Achievements.", achievementsInfo);
} }
if (achievementsInfo.stats.size() > 0) { if (!achievementsInfo.stats.empty()) {
tab->addTab(_("Statistics"), "GameOptions_Achievements"); tab->addTab(_("Statistics"), "GameOptions_Achievements");
addStatisticsControls(tab, "GameOptions_Achievements.", achievementsInfo); addStatisticsControls(tab, "GameOptions_Achievements.", achievementsInfo);
} }

6
gui/options.cpp
View file

@ -1202,8 +1202,8 @@ void OptionsDialog::addAchievementsControls(GuiObject *boss, const Common::Strin
uint16 lineHeight = g_gui.xmlEval()->getVar("Globals.Line.Height"); uint16 lineHeight = g_gui.xmlEval()->getVar("Globals.Line.Height");
uint16 yStep = lineHeight; uint16 yStep = lineHeight;
uint16 ySmallStep = yStep/3; uint16 ySmallStep = yStep / 3;
uint16 yPos = lineHeight + yStep*3; uint16 yPos = lineHeight + yStep * 3;
uint16 progressBarWidth = 240; uint16 progressBarWidth = 240;
uint16 width = g_system->getOverlayWidth() <= 320 ? 240 : 410; uint16 width = g_system->getOverlayWidth() <= 320 ? 240 : 410;
uint16 descrDelta = g_system->getOverlayWidth() <= 320 ? 25 : 30; uint16 descrDelta = g_system->getOverlayWidth() <= 320 ? 25 : 30;
@ -1271,7 +1271,7 @@ void OptionsDialog::addStatisticsControls(GuiObject *boss, const Common::String
uint16 lineHeight = g_gui.xmlEval()->getVar("Globals.Line.Height"); uint16 lineHeight = g_gui.xmlEval()->getVar("Globals.Line.Height");
uint16 yStep = lineHeight; uint16 yStep = lineHeight;
uint16 ySmallStep = yStep/3; uint16 ySmallStep = yStep / 3;
uint16 yPos = lineHeight; uint16 yPos = lineHeight;
uint16 width = g_system->getOverlayWidth() <= 320 ? 240 : 410; uint16 width = g_system->getOverlayWidth() <= 320 ? 240 : 410;