SDL: Remove side effect of setlocale() call to get Language.
This is to fix bug #3615148 - "ALL: sscanf("%f"), atof() etc. not portable due to Locale" The side effect of setlocale("") is to change the active locale from the default of "C" to the detected system locale, but this changes the behaviour of sscanf() and several other functions in a system dependent and non-portable way. This has caused bugs in the ZVISION engine when running Zork Nemesis. The solution is to restore the default "C" locale after the call to get the language. Thanks to criezy for working out this fix.
This commit is contained in:
parent
c3df6c9c0c
commit
de8da01b0e
1 changed files with 5 additions and 0 deletions
|
@ -393,6 +393,11 @@ Common::String OSystem_SDL::getSystemLanguage() const {
|
|||
#else // WIN32
|
||||
// Activating current locale settings
|
||||
const char *locale = setlocale(LC_ALL, "");
|
||||
|
||||
// Restore default C locale to prevent issues with
|
||||
// portability of sscanf(), atof(), etc.
|
||||
// See bug #3615148
|
||||
setlocale(LC_ALL, "C");
|
||||
|
||||
// Detect the language from the locale
|
||||
if (!locale) {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue