thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

CLOUD: Fix finishSuccess() warning

Browse source
This commit is contained in:
Alexander Tkachev 2016-06-21 17:07:23 +06:00
parent fa3ea83165
commit f3a392359b
34 changed files with 58 additions and 58 deletions
Download patch file Download diff file Expand all files Collapse all files

6
backends/networking/curl/curljsonrequest.cpp
View file

@ -71,10 +71,10 @@ void CurlJsonRequest::handle() {
char *contents = getPreparedContents();
Common::JSONValue *json = Common::JSON::parse(contents);
if (json) {
finishSuccess(json); //it's JSON even if's not 200 OK? That's fine!..
finishJson(json); //it's JSON even if's not 200 OK? That's fine!..
} else {
if (_stream->httpResponseCode() == 200) //no JSON, but 200 OK? That's fine!..
finishSuccess(nullptr);
finishJson(nullptr);
else
finishError(ErrorResponse(this, false, true, contents, _stream->httpResponseCode()));
}
@ -89,7 +89,7 @@ void CurlJsonRequest::restart() {
//with no stream available next handle() will create another one
}
void CurlJsonRequest::finishSuccess(Common::JSONValue *json) {
void CurlJsonRequest::finishJson(Common::JSONValue *json) {
Request::finishSuccess();
if (_jsonCallback) (*_jsonCallback)(JsonResponse(this, json)); //potential memory leak, free it in your callbacks!
else delete json;