thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

COMMON: Get rid of write version of ConfigManager::getGameDomains.

Browse source 
This can be abused to insert Domains into the game domains without any checks.
Instead, only write iterator access is given.
This commit is contained in:
Johannes Schickel 2013-08-08 03:55:02 +02:00
parent 774d53045d
commit f7d3b06711
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
base/commandLine.cpp
View file

@ -827,9 +827,8 @@ void upgradeTargets() {
printf("Upgrading all your existing targets\n");
Common::ConfigManager::DomainMap &domains = ConfMan.getGameDomains();
Common::ConfigManager::DomainMap::iterator iter = domains.begin();
for (iter = domains.begin(); iter != domains.end(); ++iter) {
Common::ConfigManager::DomainMap::iterator iter = ConfMan.beginGameDomains();
for (; iter != ConfMan.endGameDomains(); ++iter) {
Common::ConfigManager::Domain &dom = iter->_value;
Common::String name(iter->_key);
Common::String gameid(dom.getVal("gameid"));