LAB: Get rid of stddefines

engines/lab/allocroom.cpp

@@ -28,7 +28,6 @@
  *
  */
 
-#include "lab/stddefines.h"
 #include "lab/parsetypes.h"
 
 namespace Lab {

engines/lab/diff.h

@@ -31,17 +31,18 @@
 #ifndef LAB_DIFF_H
 #define LAB_DIFF_H
 
-#include "lab/stddefines.h"
 #include "common/file.h"
 
 namespace Lab {
 
 
 struct DIFFHeader {
-	uint16 Version, x, y;
-	char depth, fps;
-	uint32 BufferSize;
-	uint16 Machine;
+	uint16 Version;    // unused
+	uint16 x, y;
+	char depth;        // unused
+	char fps;
+	uint32 BufferSize; // unused
+	uint16 Machine;    // unused
 	uint32 Flags;
 };
 

engines/lab/engine.cpp

@@ -29,7 +29,6 @@
  */
 
 #include "lab/lab.h"
-#include "lab/stddefines.h"
 #include "lab/labfun.h"
 #include "lab/diff.h"
 #include "lab/text.h"

engines/lab/graphics.cpp

@@ -29,7 +29,6 @@
  */
 
 #include "lab/lab.h"
-#include "lab/stddefines.h"
 #include "lab/diff.h"
 #include "lab/parsetypes.h"
 #include "lab/labfun.h"

engines/lab/interface.cpp

@@ -30,7 +30,6 @@
 
 #include "lab/lab.h"
 #include "lab/labfun.h"
-#include "lab/stddefines.h"
 #include "lab/interface.h"
 #include "lab/mouse.h"
 #include "common/util.h"

engines/lab/labfun.h

@@ -32,7 +32,6 @@
 #define LAB_LABFUN_H
 
 #include "common/events.h"
-#include "lab/stddefines.h"
 #include "lab/parsetypes.h"
 
 // For the Music class - TODO: Move to another header file

engines/lab/labsets.cpp

@@ -29,7 +29,6 @@
  */
 
 #include "lab/lab.h"
-#include "lab/stddefines.h"
 #include "lab/labfun.h"
 #include "lab/resource.h"
 

engines/lab/machine.cpp

@@ -29,9 +29,7 @@
  */
 
 #include "common/str.h"
-
 #include "lab/lab.h"
-#include "lab/stddefines.h"
 
 namespace Lab {
 

engines/lab/map.cpp

@@ -29,7 +29,6 @@
  */
 
 #include "lab/lab.h"
-#include "lab/stddefines.h"
 #include "lab/labfun.h"
 #include "lab/diff.h"
 #include "lab/text.h"

engines/lab/mouse.cpp

@@ -30,7 +30,6 @@
 
 #include "lab/lab.h"
 #include "lab/mouse.h"
-#include "lab/stddefines.h"
 #include "lab/interface.h"
 
 namespace Lab {

engines/lab/mouse.h

@@ -29,7 +29,6 @@
  */
 
 #include "common/events.h"
-#include "lab/stddefines.h"
 
 #ifndef LAB_MOUSE_H
 #define LAB_MOUSE_H

engines/lab/music.cpp

@@ -30,7 +30,6 @@
 
 #include "audio/mixer.h"
 
-#include "lab/stddefines.h"
 #include "lab/labfun.h"
 #include "lab/mouse.h"
 #include "lab/music.h"

engines/lab/parsefun.h

@@ -31,7 +31,6 @@
 #ifndef LAB_PARSEFUN_H
 #define LAB_PARSEFUN_H
 
-#include "lab/stddefines.h"
 #include "lab/labfun.h"
 #include "lab/parsetypes.h"
 

engines/lab/parsetypes.h

@@ -31,6 +31,8 @@
 #ifndef LAB_PARSETYPES_H
 #define LAB_PARSETYPES_H
 
+#include "common/system.h"
+
 namespace Lab {
 
 #define MAXFILELEN 31

engines/lab/processroom.cpp

@@ -31,7 +31,6 @@
 #include "gui/message.h"
 
 #include "lab/lab.h"
-#include "lab/stddefines.h"
 #include "lab/labfun.h"
 #include "lab/parsetypes.h"
 #include "lab/parsefun.h"

engines/lab/readdiff.cpp

@@ -169,10 +169,11 @@ void LabEngine::diffNextFrame() {
 		}
 
 		_music->updateMusic();
-		readBlock(&header, 4L, difffile);
-		swapULong(&header);
-		readBlock(&size, 4L, difffile);
-		swapULong(&size);
+ 		header = READ_LE_UINT32(*difffile);
+		*difffile += 4;
+
+		size = READ_LE_UINT32(*difffile);
+		*difffile += 4;
 
 		switch (header) {
 		case 8L:
@@ -239,9 +240,8 @@ void LabEngine::diffNextFrame() {
 
 
 			(*difffile) += 4;
-			readBlock(&samplespeed, 2L, difffile);
-			swapUShortPtr(&samplespeed, 1);
-			(*difffile) += 2;
+			samplespeed = READ_LE_UINT16(*difffile);
+			(*difffile) += 4;
 
 			byte *music = *difffile;
 			uint32 musicsize = size;
@@ -315,41 +315,44 @@ void playDiff() {
 	}
 
 	continuous = false;
-	readBlock(temp, 4L, difffile);
-	temp[4] = '\0';
+	uint32 signature = READ_BE_UINT32(*difffile);
+	(*difffile) += 4;
 
-	readBlock(&header, 4L, difffile);
-	swapULong(&header);
+	header = READ_LE_UINT32(*difffile);
+	(*difffile) += 4;
 
-	if (!((strcmp((char *)temp, "DIFF") == 0) && (header == 1219009121L))) {
+	if ((signature != MKTAG('D', 'I', 'F', 'F')) || (header != 1219009121L)) {
 		IsPlaying = false;
 		return;
 	}
 
-	readBlock(&header, 4L, difffile);
-	swapULong(&header);
+	header = READ_LE_UINT32(*difffile);
+	(*difffile) += 4;
 
-	readBlock(&size, 4L, difffile);
-	swapULong(&size);
+	size = READ_LE_UINT32(*difffile);
+	(*difffile) += 4;
 
 	if (header == 0) {
 		// sizeof(headerdata) != 18, but the padding might be at the end
-		readBlock(&headerdata.Version, 2, difffile);
-		readBlock(&headerdata.x, 2, difffile);
-		readBlock(&headerdata.y, 2, difffile);
-		readBlock(&headerdata.depth, 1, difffile);
-		readBlock(&headerdata.fps, 1, difffile);
-		readBlock(&headerdata.BufferSize, 4, difffile);
-		readBlock(&headerdata.Machine, 2, difffile);
-		readBlock(&headerdata.Flags, 4, difffile);
+		headerdata.Version = READ_LE_UINT16(*difffile);
+		(*difffile) += 2;
+		headerdata.x = READ_LE_UINT16(*difffile);
+		(*difffile) += 2;
+		headerdata.y = READ_LE_UINT16(*difffile);
+		(*difffile) += 2;
+		headerdata.depth = *difffile[0];
+		(*difffile)++;
+		headerdata.fps = *difffile[0];
+		(*difffile)++;
+		headerdata.BufferSize = READ_LE_UINT32(*difffile);
+		(*difffile) += 4;
+		headerdata.Machine = READ_LE_UINT16(*difffile);
+		(*difffile) += 2;
+		headerdata.Flags = READ_LE_UINT32(*difffile);
+		(*difffile) += 4;
 
 		(*difffile) += size - 18;
 
-		swapUShortPtr(&headerdata.Version, 3);
-		swapULong(&headerdata.BufferSize);
-		swapUShortPtr(&headerdata.Machine, 1);
-		swapULong(&headerdata.Flags);
-
 		continuous = CONTINUOUS & headerdata.Flags;
 		diffwidth = headerdata.x;
 		diffheight = headerdata.y;

engines/lab/savegame.cpp

@@ -34,7 +34,6 @@
 #include "graphics/thumbnail.h"
 
 #include "lab/lab.h"
-#include "lab/stddefines.h"
 #include "lab/labfun.h"
 
 namespace Lab {

engines/lab/special.cpp

@@ -40,7 +40,6 @@
 #include "lab/diff.h"
 #include "lab/text.h"
 #include "lab/mouse.h"
-#include "lab/stddefines.h"
 #include "lab/parsetypes.h"
 #include "lab/resource.h"
 

engines/lab/stddefines.h

@@ -1,51 +0,0 @@
-/* ScummVM - Graphic Adventure Engine
- *
- * ScummVM is the legal property of its developers, whose names
- * are too numerous to list here. Please refer to the COPYRIGHT
- * file distributed with this source distribution.
- *
- * This program is free software; you can redistribute it and/or
- * modify it under the terms of the GNU General Public License
- * as published by the Free Software Foundation; either version 2
- * of the License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- *
- * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
- *
- */
-
-/*
- * This code is based on Labyrinth of Time code with assistance of
- *
- * Copyright (c) 1993 Terra Nova Development
- * Copyright (c) 2004 The Wyrmkeep Entertainment Co.
- *
- */
-
-#include "common/system.h"
-#include "common/debug.h"
-#include "common/textconsole.h"
-
-#ifndef LAB_STDDEFINES_H
-#define LAB_STDDEFINES_H
-
-namespace Lab {
-
-#define swapUShort(value) (value)
-#define swapUShortPtr(ptr,count) (ptr)
-#define swapShort(value) (value)
-#define swapShortPtr(ptr,count) (ptr)
-#define swapUInt(value) (value)
-#define swapInt(value) (value)
-#define swapULong(value) (value)
-#define swapLong(value) (value)
-
-} // End of namespace Lab
-
-#endif /* LAB_STDDEFINES_H */

engines/lab/text.cpp

@@ -29,7 +29,6 @@
  */
 
 #include "lab/lab.h"
-#include "lab/stddefines.h"
 #include "lab/labfun.h"
 #include "lab/text.h"
 

engines/lab/text.h

@@ -31,9 +31,6 @@
 #ifndef LAB_TEXT_H
 #define LAB_TEXT_H
 
-
-#include "lab/stddefines.h"
-
 namespace Lab {
 
 #if defined(WIN32)

engines/lab/undiff.cpp

@@ -28,8 +28,8 @@
  *
  */
 
-#include "lab/stddefines.h"
 #include "common/endian.h"
+#include "lab/lab.h"
 
 namespace Lab {
 

engines/lab/vga.cpp

@@ -28,14 +28,12 @@
  *
  */
 
-#include "lab/lab.h"
-#include "lab/stddefines.h"
-#include "lab/mouse.h"
-
 #include "graphics/palette.h"
-
 #include "common/events.h"
 
+#include "lab/lab.h"
+#include "lab/mouse.h"
+
 namespace Lab {
 
 /*****************************************************************************/