Commit graph

21 commits

Author SHA1 Message Date
lolbot-iichan
13dbfbd8d7 WINTERMUTE: Fix slider bugs in several games
There is a bug introduced in WME Lite.

Testcase:
1. Download https://github.com/lolbot-iichan/wme_testsuite/tree/master/slider_test/packages
2. Download https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/wmelite/wmelite_10_win.zip
3a. Run game.exe -> Slider moves with the mouse while it is pressed and
released when mouse is released
3b. Run wmelite.exe -> Slider is never released
3c. Run ScummVM -> Slider is never released

Related bugs:
https://bugs.scummvm.org/ticket/6567
https://bugs.scummvm.org/ticket/9861

Reason: slider is a button object that changes it's X until "LeftRelease" event is revieved and breaks the endless loop.
Sample code: https://github.com/lolbot-iichan/wme_testsuite/blob/master/slider_test/data/interface/system/speechvolume.script
However, WME Lite does not send "LeftRelease" events to any objects, if Game object can handle such event, even is game is frozen and UI is shown.

Original code: https://github.com/lolbot-iichan/Wintermute-Engine/blob/master/src/engine_core/wme_ad/AdGame.cpp#L2218
Changed in WME Lite: https://github.com/lolbot-iichan/wmelite/blob/master/src/AdGame.cpp#L2120

This behaviour was introduced in SVN period of wmelite, I believe it was
made on purpose for handling some iOS scenarios at commit #37 mentioned
on page https://code.google.com/archive/p/wmelite/source/default/commits

My proposal is to mark iOS apps as WME_LITE and fill exact WME_1_X_X/WME_LITE versions for all known
games. WME_1_X_X can be seen by right-clicking on main executable and seems to be non-empty for almost all existing WME games.
2019-07-02 08:00:30 +03:00
Bastien Bouclet
ae6b0cfdef WINTERMUTE: Push down the AD includes 2018-05-01 12:48:05 +02:00
Tobia Tesan
f29229c0a6 WINTERMUTE: Return Common::String in getGameTargetName() 2016-03-05 20:41:19 +01:00
Tobia Tesan
dfe465e26b WINTERMUTE: Introduce WMEGameDescription
I aped what has been done with AGS: in engines/agi/detection.cpp, adding
a struct that includes ADGameDescription at the beginning.

This is also recommended in advancedDetector.h
2014-11-04 17:52:01 +01:00
Johannes Schickel
fc5ef58fff WINTERMUTE: Make GPL headers consistent in themselves. 2014-02-18 02:39:40 +01:00
Johannes Schickel
1ce54c217a WINTERMUTE: Fix end of namespace comments. 2013-08-04 00:51:09 +02:00
Einar Johan Trøan Sømåen
e296ac1d47 WINTERMUTE: Let engine know both gameid and language of target as well as targetname. 2013-07-31 04:26:28 +02:00
Einar Johan Trøan Sømåen
32ace5f9d2 WINTERMUTE: Avoid including BaseGame in BaseFader. 2013-04-18 12:13:12 +02:00
Einar Johan Trøan Sømåen
8f25b651e8 WINTERMUTE: Split the timers from BaseGame into a separate class. 2013-04-18 12:10:40 +02:00
Einar Johan Trøan Sømåen
7ee757366b WINTERMUTE: Avoid including BaseGame in BaseViewport. 2013-04-18 11:19:26 +02:00
Einar Johan Trøan Sømåen
a8f4f20f38 WINTERMUTE: Avoid including BaseGame in BaseFrame. 2013-04-18 11:13:32 +02:00
Einar Johan Trøan Sømåen
5d4d65d6d9 JANITORIAL: Fix ){ -> ) { 2013-01-24 20:15:13 +01:00
Johannes Schickel
89abab97e3 JANITORIAL: Remove trailing whitespaces.
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
2012-09-26 04:17:55 +02:00
Einar Johan Trøan Sømåen
101ad689c5 WINTERMUTE: Add language-filtering for Czech, Italian, Polish and Russian.
No detection-support is added for those languages at this point though.
2012-08-13 04:37:07 +02:00
Einar Johan Trøan Sømåen
fed19cb66a WINTERMUTE: WinterMute -> Wintermute 2012-08-13 03:42:30 +02:00
Einar Johan Trøan Sømåen
6b159d71ab WINTERMUTE: Remove g_wintermute. 2012-08-07 13:51:22 +02:00
Einar Johan Trøan Sømåen
e32b79bff1 WINTERMUTE: Save the random-seed as well. 2012-08-07 13:32:26 +02:00
Einar Johan Trøan Sømåen
80a67a70cd WINTERMUTE: Add header-guards to BaseEngine 2012-07-29 19:09:37 +02:00
Einar Johan Trøan Sømåen
2e7d21fc52 WINTERMUTE: Replace BaseRegistry with ConfMan 2012-07-29 17:53:44 +02:00
Einar Johan Trøan Sømåen
482a5fb467 WINTERMUTE: Make the BaseEngine-singleton use Common::Singleton as super-class 2012-07-29 03:41:07 +02:00
Einar Johan Trøan Sømåen
9b5cf8f1ba WINTERMUTE: Introduce a Singleton-class for holding registry/filemanager. 2012-07-29 02:34:44 +02:00