Commit graph

27 commits

Author SHA1 Message Date
Bastien Bouclet
9a4c0ae281 ENGINES: Normalize the getName() result of metaengines
Also-By: Matthew Hoops <clone2727@gmail.com>
2018-12-10 06:47:27 +01:00
Bastien Bouclet
eedb53207d AVALANCHE: Push down AD includes 2018-05-01 12:48:05 +02:00
Adrian Frühwirth
00e59a3122 ALL: Load savegame thumbnail only when necessary
This commit introduces the following changes:

1. Graphics::loadThumbnail()

   Now returns a boolean and takes a new argument skipThumbnail which
   defaults to false. In case of true, loadThumbnail() reads past the
   thumbnail data in the input stream instead of actually loading the
   thumbnail. This simplifies savegame handling where, up until now,
   many engines always read the whole savegame metadata (including
   the thumbnail) and then threw away the thumbnail when not needed
   (which is in almost all cases, the most common exception being
   MetaEngine::querySaveMetaInfos() which is responsible for loading
   savegame metadata for displaying it in the GUI launcher.

2. readSavegameHeader()

   Engines which already implement such a method (name varies) now take
   a new argument skipThumbnail (default: true) which is passed
   through to loadThumbnail(). This means that the default case for
   readSavegameHeader() is now _not_ loading the thumbnail from a
   savegame and just reading past it. In those cases, e.g.
   querySaveMetaInfos(), where we actually are interested in loading
   the thumbnail readSavegameHeader() needs to explicitely be called
   with skipThumbnail == false.

   Engines whose readSavegameHeader() (name varies) already takes an
   argument loadThumbnail have been adapted to have a similar
   prototype and semantics.
   I.e. readSaveHeader(in, loadThumbnail, header) now is
   readSaveHeader(in, header, skipThumbnail).

3. Error handling

   Engines which previously did not check the return value of
   readSavegameHeader() (name varies) now do so ensuring that possibly
   broken savegames (be it a broken thumbnail or something else) don't
   make it into the GUI launcher list in the first place.
2018-04-07 09:26:20 +02:00
Alexander Tkachev
b665fc933d ALL: Make simpleSaveNames() a MetaEngineFeature
Added it into hasFeature() of all engines which returned `true` in
simpleSaveNames() before.

As mentioned in #788, SCI is not always using simple names, so it
doesn't have such feature now.
2016-08-24 16:07:55 +06:00
Alexander Tkachev
ab1d160ec8 ALL: Add MetaEngine::simpleSaveNames()
Engines with "simple" savenames would support "Run in background" in
save/load dialog and gradual save slots unlocking. Other engines
save/load feature would be locked until save sync is over.
2016-08-24 16:07:55 +06:00
Johannes Schickel
3aecd8ef2a ENGINES: Make variable names of ADGameDescription conform to our guidelines.
gameid     -> gameId
guioptions -> guiOptions
2016-03-08 19:01:38 +01:00
Johannes Schickel
e31a4a409e AVALANCHE: Let listSaves return list sorted on slot numbers. 2016-02-25 21:39:45 +01:00
Johannes Schickel
8b2fd644c1 AVALANCHE: Only request actual save slots in listSaves. 2016-01-26 16:35:30 +01:00
Johannes Schickel
854de79c23 AVALANCHE: Make GPL headers consistent in themselves. 2014-02-18 02:39:32 +01:00
Strangerke
c63b2b2b2c AVALANCHE: Fix savegame version checks 2013-11-24 01:30:18 +01:00
Strangerke
c24ba381cb AVALANCHE: Fix CID 1109674 2013-11-03 10:51:15 +01:00
Strangerke
c36adb83e2 AVALANCHE: Fix savegames list 2013-10-07 22:38:32 +02:00
Strangerke
7b11be0a92 AVALANCHE: Fix savegame patterns 2013-10-07 22:26:33 +02:00
Strangerke
a357dc4d0c AVALANCHE: Cleaning includes - remove useless includes in cpp files 2013-10-05 01:55:41 +02:00
Strangerke
c53917ec64 AVALANCHE: Add indentation on REGISTER_PLUGIN_* lines 2013-10-04 18:12:13 +02:00
Strangerke
650613f5ca AVALANCHE: Use MKTAG for signature. This breaks prior savegames. 2013-10-04 17:30:16 +02:00
Strangerke
de12f46db5 AVALANCHE: Rename Graphics to avoid confusion, add drawBackgroundSprite(), set _background private 2013-09-29 17:54:03 +02:00
uruk
31637f1983 AVALANCHE: Cosmetic modifications. 2013-09-19 21:21:53 +02:00
Strangerke
6e08f55160 AVALANCHE: Review all for statements 2013-09-16 22:57:38 +02:00
Strangerke
f783f2c28a AVALANCHE: Silent some CppCheck warnings, rename some loop variables 2013-09-08 10:31:54 +02:00
uruk
f8796e720e AVALANCHE: Add thumbnail support and version tracking to the saving/loading system. Repair Trip::trippancy_link(). 2013-08-20 21:26:23 +02:00
uruk
aab3930779 AVALANCHE: Implement loading from the Launcher. Upgrade saveGame(), loadGame() in, add expandDate() to AvalancheEngine. Revise Avalot::setup(). Repair Lucerna::load() and triptype::init(). 2013-08-20 19:23:24 +02:00
uruk
52c07d08c0 AVALANCHE: AvalancheEngine: Revise synchronize(), saveGame(), loadGameState(). Add loadGame(). Rename generateSaveFileName() to getSaveFileName(). AvalancheMetaEngine: Add listSaves() and removeSaveState(). 2013-08-19 21:14:21 +02:00
uruk
1453413d24 AVALANCHE: Fix detection. 2013-06-20 09:40:25 +02:00
uruk
b2f62278b6 AVALANCHE: Remove some functions from detection. 2013-06-20 08:34:48 +02:00
uruk
b916ab6f02 AVALANCHE: Messing around with GameDescription. 2013-06-20 08:32:58 +02:00
uruk
d2009c014f AVALANCHE: Add detection. Some fix in console.h. 2013-06-18 20:32:43 +02:00