Commit graph

66 commits

Author SHA1 Message Date
Bastien Bouclet
9a4c0ae281 ENGINES: Normalize the getName() result of metaengines
Also-By: Matthew Hoops <clone2727@gmail.com>
2018-12-10 06:47:27 +01:00
Adrian Frühwirth
00e59a3122 ALL: Load savegame thumbnail only when necessary
This commit introduces the following changes:

1. Graphics::loadThumbnail()

   Now returns a boolean and takes a new argument skipThumbnail which
   defaults to false. In case of true, loadThumbnail() reads past the
   thumbnail data in the input stream instead of actually loading the
   thumbnail. This simplifies savegame handling where, up until now,
   many engines always read the whole savegame metadata (including
   the thumbnail) and then threw away the thumbnail when not needed
   (which is in almost all cases, the most common exception being
   MetaEngine::querySaveMetaInfos() which is responsible for loading
   savegame metadata for displaying it in the GUI launcher.

2. readSavegameHeader()

   Engines which already implement such a method (name varies) now take
   a new argument skipThumbnail (default: true) which is passed
   through to loadThumbnail(). This means that the default case for
   readSavegameHeader() is now _not_ loading the thumbnail from a
   savegame and just reading past it. In those cases, e.g.
   querySaveMetaInfos(), where we actually are interested in loading
   the thumbnail readSavegameHeader() needs to explicitely be called
   with skipThumbnail == false.

   Engines whose readSavegameHeader() (name varies) already takes an
   argument loadThumbnail have been adapted to have a similar
   prototype and semantics.
   I.e. readSaveHeader(in, loadThumbnail, header) now is
   readSaveHeader(in, header, skipThumbnail).

3. Error handling

   Engines which previously did not check the return value of
   readSavegameHeader() (name varies) now do so ensuring that possibly
   broken savegames (be it a broken thumbnail or something else) don't
   make it into the GUI launcher list in the first place.
2018-04-07 09:26:20 +02:00
Johannes Schickel
3aecd8ef2a ENGINES: Make variable names of ADGameDescription conform to our guidelines.
gameid     -> gameId
guioptions -> guiOptions
2016-03-08 19:01:38 +01:00
Johannes Schickel
0b6befdcc5 ENGINES: Make variable names of AdvancedMetaEngine conform to our guidelines.
_singleid   -> _singleId
_gameids    -> _gameIds
_guioptions -> _guiOptions
2016-03-08 19:01:13 +01:00
Johannes Schickel
a8d9478e46 CRUISE: Let listSaves return list sorted on slot numbers. 2016-02-25 21:39:45 +01:00
Johannes Schickel
6665f81c25 CRUISE: Only request actual save slots in listSaves. 2016-01-26 16:35:30 +01:00
Johannes Schickel
00b6dfe9cf CRUISE: Make GPL headers consistent in themselves. 2014-02-18 02:39:33 +01:00
Johannes Schickel
5c29233921 CRUISE: Indent REGISTER_PLUGIN_* for consistency. 2014-02-17 23:01:53 +01:00
Strangerke
233cbb13b8 CRUISE: Remove useless fields in CRUISEGameDescription 2013-06-18 23:16:17 +02:00
Matthew Hoops
0031c41db8 COMMON: Change kPlatformPC to kPlatformDOS
"PC" was very ambiguous and now it matches what we show in the GUI.

This also corrects sword2's platform to Windows.
2013-05-02 18:43:10 -04:00
Johannes Schickel
89abab97e3 JANITORIAL: Remove trailing whitespaces.
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
2012-09-26 04:17:55 +02:00
Johannes Schickel
bc3c80714b CRUISE: Slight cleanup in querySaveMetaInfos. 2012-07-03 18:39:50 +02:00
Fabio Battaglia
ef280e81a6 CRUISE: Correct Italian detection entry
Actually mark Amiga italian detection entry as Italian
2012-05-14 17:18:30 +02:00
Fabio Battaglia
623ae7f179 CRUISE: Add detection entry for Amiga Italian ver 2012-05-14 17:15:17 +02:00
Strangerke
bab4b6f729 LAUNCHER: Introduce GUIO0() in order to replace GUIO1(GUIO_NONE) 2011-11-16 22:38:58 +01:00
Eugene Sandulenko
32972a5ffb AD: Switched rest of the engines to new GUIO 2011-10-23 17:53:13 +01:00
Paul Gilbert
9bb978486b COMMON: Fix multiple engines asserting in querySaveMetaInfos for empty save slots 2011-10-01 17:50:19 +10:00
Max Horn
7c992d6598 DETECTOR: Merge ADParams into AdvancedMetaEngine 2011-06-14 18:17:01 +02:00
Max Horn
446e602840 CRUISE: Switch to alternate AdvancedMetaEngine, avoid ADParams 2011-06-10 22:15:41 +02:00
Max Horn
4827cc914a ENGINES: Change incorrect use of 'target' to 'gameid' 2011-06-10 22:15:40 +02:00
Thierry Crozat
d2a55b42c9 ENGINES: Further unify engine names 2011-05-22 12:47:35 +01:00
Thierry Crozat
3c59e37035 ENGINES: Unify engine names
This unifies the engine names in MetaEngine::getName() and the
credits. In particular drop "Engine" or "engine" from the names when
it was present and use expanded names in credits when the
MetaEngine uses it (e.g. "Beneath a Steel Sky" instead of "BASS").
2011-05-16 00:11:32 +01:00
strangerke
69b1485a22 GIT: Clean up: Suppress SVN tags, now useless 2011-05-12 01:16:22 +02:00
Ori Avtalion
9414d7a6e2 JANITORIAL: Reduce header dependencies in shared code
Some backends may break as I only compiled SDL
2011-04-28 15:08:58 +03:00
Max Horn
84184aabc0 ALL: colour -> color 2011-04-14 14:12:35 +02:00
Eugene Sandulenko
44a39ffbc6 AdvancedDetector: Add new parameter directoryGlobs.
Without this parameter mass detection gave tons of false alarms.
Use globbing for narrowing down the depth search.

svn-id: r49788
2010-06-15 10:59:23 +00:00
Eugene Sandulenko
4d517ed0e9 Extended advancedDetector with depth parameter.
Now AD can search nested directories. By default it is turned off,
but there is new parameter to ADParameters struct. Usually value
of 2 is good enough for all purposes.

svn-id: r49653
2010-06-14 14:50:23 +00:00
Max Horn
92c896d883 Patch #2973290: Semicolon cleanup
svn-id: r48359
2010-03-22 20:28:08 +00:00
Max Horn
cac0ac66e2 COMMON: Get rid of Common::StringList
svn-id: r48287
2010-03-18 15:54:40 +00:00
Fabio Battaglia
5c93ac4adc cruise: add detection entry for Amiga English US GOLD version
svn-id: r48160
2010-03-04 17:21:59 +00:00
Fabio Battaglia
24fd77eb24 Cruise detection entry for english AtariST KixxXL edition
svn-id: r48045
2010-02-13 13:21:29 +00:00
Torbjörn Andersson
72eb9ec9ea Fixed a bunch of cppcheck warnings. Mostly about checking if a pointer is null
before freeing it, which isn't necessary.

svn-id: r46941
2010-01-03 19:37:43 +00:00
Johannes Schickel
346ce3f3da Add preliminary support for German Amiga version.
svn-id: r44077
2009-09-14 12:24:23 +00:00
Paul Gilbert
de2e283492 Added code to launch the GMM save/load dialogues from the in-game Player menu, replacing the older code that just saved/loaded the game in a single slot without prompting
svn-id: r43685
2009-08-24 09:07:21 +00:00
Paul Gilbert
86fdd698ad Added detection entry for the UK 16 colour version
svn-id: r43434
2009-08-16 12:03:48 +00:00
Paul Gilbert
49a4df3c8c Added Dirty Rect handling functionality
svn-id: r43406
2009-08-15 11:50:59 +00:00
Paul Gilbert
e487347921 Added support for loading savegames from the launcher
svn-id: r41424
2009-06-10 12:16:30 +00:00
Eugene Sandulenko
1bd6f6c99f Added game GUI options to advancedDetector and updated all engines
svn-id: r41272
2009-06-06 17:56:41 +00:00
Joost Peters
5f7515162a Capitalize the C in Corpse
svn-id: r41110
2009-06-01 20:55:31 +00:00
Max Horn
fb79b18571 Changed SaveFileManager methods to take Common::String params (instead of char pointers)
svn-id: r41000
2009-05-29 14:38:22 +00:00
Paul Gilbert
17f468bb02 Removed the obsolete game Id list - it seems redundant, and stops the warning message coming up about Target 'cruise' upgraded to 'cruise'
svn-id: r40633
2009-05-17 05:14:55 +00:00
Torbjörn Andersson
e9e9725946 Added detection entry for the German 16-colour version, which was included on
the "Classic Collection" CD I just bought.

svn-id: r40330
2009-05-05 16:58:54 +00:00
Paul Gilbert
15252ad83c Added support for the global menu save/loading, and changed the savegame format to store the savegame name and thumbnail
svn-id: r39979
2009-04-18 10:16:08 +00:00
Jordi Vilalta Prat
047f116515 Renamed MetaEngine::getCopyright() to getOriginalCopyright() to better match the meaning of the returned string, as discussed some time ago in scummvm-devel
svn-id: r39132
2009-03-05 12:04:58 +00:00
Max Horn
28cf213605 Moved AdvancedDetector from common/ to engines/
svn-id: r36132
2009-01-29 22:13:01 +00:00
Max Horn
e9f0fc21e8 Fixed class indention
svn-id: r35871
2009-01-16 05:04:49 +00:00
Max Horn
4c5efaecf4 Code formatting fixes, automatically performed by astyle
svn-id: r35870
2009-01-16 02:43:41 +00:00
Travis Howell
b8fe877fa8 Add German, Italian and Spanish VGA versions of Cruise for a Corpse.
svn-id: r35669
2009-01-02 09:53:11 +00:00
Jordi Vilalta Prat
38a8aa516e Allow static and dynamic plugins to be used at the same time
svn-id: r31888
2008-05-06 03:00:26 +00:00
Max Horn
29f1e6de38 Advanced detector: replaced kADFlagAugmentPreferredTarget by its inverse, kADFlagDontAugmentPreferredTarget (since all AdvDetector engines except Kyra used kADFlagAugmentPreferredTarget, it seems reasonable to assume that as default)
svn-id: r31413
2008-04-05 22:29:08 +00:00