thirdparty/scummvm
2
0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
64893 commits 35 branches 0 tags 1.4 GiB
Commit graph

49 commits

Author SHA1 Message Date
Johannes Schickel
b9bfa3a857 TONY: Make GPL headers consistent in themselves. 2014-02-18 02:39:39 +01:00
D G Turner
ac4087856f ALL: Remove optimization unstable code on checking for null after new. 
These issues were identified by the STACK tool.

By default, the C++ new operator will throw an exception on allocation
failure, rather than returning a null pointer.

The result is that testing the returned pointer for null is redundant
and _may_ be removed by the compiler. This is thus optimization
unstable and may result in incorrect behaviour at runtime.

However, we do not use exceptions as they are not supported by all
compilers and may be disabled.

To make this stable without removing the null check, you could qualify
the new operator call with std::nothrow to indicate that this should
return a null, rather than throwing an exception.

However, using (std::nothrow) was not desirable due to the Symbian
toolchain lacking a <new> header.
A global solution to this was also not easy by redefining "new" as "new
(std::nothrow)" due to custom constructors in NDS toolchain and various
common classes.

Also, this would then need explicit checks for OOM adding to all new
usages as per C malloc which is untidy.

For now to remove this optimisation unstable code is best as it is
likely to not be present anyway, and OOM will cause a system library
exception instead, even without exceptions enabled in the application
code.
 2014-01-15 02:36:19 +00:00
Alyssa Milburn
5b6d3078c9 TONY: Add a hack to work around amigaos4 issues. 2013-08-02 00:01:11 +02:00
D G Turner
b8c1b46ae0 TONY: Cleanup whitespace formatting. 
This is mainly removal of extraneous blank lines, reformatting indents
to tab characters and other minor non-functional changes to improve
compliance with Code Formatting Conventions.
 2012-11-12 00:39:20 +00:00
Giovanni Bajo
79d7d3d708 TONY: fix volumes of sound effects. 
The game was using a logarithmic scale (through DirectSound)
so we need a log->linear conversion to feed the mixer.
 2012-10-26 20:29:04 +02:00
Strangerke
5023a5764f TONY: Fix music bug - 2 songs played simultaneously eventually 2012-10-15 07:08:24 +02:00
Alyssa Milburn
60b101f5f6 TONY: Rename yet more variables. 2012-09-08 09:59:56 +02:00
Strangerke
825e0896dc TONY: Replace C-style comments by C++-style ones. 
Also translate some more Italian comments
 2012-08-29 23:25:14 +02:00
Alyssa Milburn
a6673aaf90 TONY: Remove useless/commented music code. 2012-08-29 09:12:53 +02:00
Strangerke
d2b33ca4cc TONY: Janitorial - remove trailing spaces 2012-08-28 23:25:50 +02:00
Strangerke
56f4bc0225 TONY: Fix some for and if statements with bad coding style 2012-08-28 23:05:48 +02:00
Alyssa Milburn
ca82454d74 TONY: Reset _hEndOfBuffer when restarting sounds. 2012-08-25 14:09:02 +02:00
Paul Gilbert
bad6ec8388 TONY: Fixed problem with spoken voices being clipped when timed text mode is on. 2012-08-23 22:05:23 +10:00
Alyssa Milburn
c340739001 TONY: Replace _vm with g_vm. 2012-08-22 21:51:51 +02:00
Paul Gilbert
69ce6e35f4 TONY: Bugfix for crash when changing scene whilst music is playing 2012-06-23 16:28:03 +10:00
Paul Gilbert
46d87ef76a TONY: Bugfix for loading ambient music when restoring a savegame 2012-06-23 15:25:03 +10:00
Alyssa Milburn
1ee68078c1 TONY: Replace the FPStream code. 
This just removes the original code and replaces it with a quickly-
written trivial implementation similar to clone2727's sfx code. It
seems to at least sort of work. :-)
 2012-06-20 19:36:25 +02:00
Paul Gilbert
aa775b4497 TONY: Some bugfixes and cleanup for the music support code 2012-06-19 22:37:56 +10:00
Paul Gilbert
d2061f29be TONY: Added initialisation of FPSound fields in it's constructor 2012-06-19 22:06:30 +10:00
Paul Gilbert
9d437a26dd TONY: Fix some compiler warnings in the newly added sound code 2012-06-19 21:19:17 +10:00
Paul Gilbert
61d460a854 TONY: Implement more of the music related code from the original 2012-06-19 20:50:48 +10:00
Strangerke
e8a6f61f88 TONY: Remove useless void in function declaration 2012-06-18 08:24:33 +02:00
Strangerke
e36f36168d TONY: Doxygen-ify comments in sound files 2012-06-17 18:09:52 +02:00
Strangerke
011b15966c TONY: Translate comments in sound.cpp 2012-06-16 23:48:16 +02:00
Strangerke
ac4567dcb6 TONY: Rename sound variables 2012-06-16 19:04:19 +02:00
Strangerke
ddd1414a56 TONY: Rename sound functions and class names 2012-06-16 11:32:50 +02:00
Matthew Hoops
de440e1a71 TONY: Fix looping some sounds 2012-06-12 11:35:27 -04:00
Paul Gilbert
5b5a812d37 TONY: Implemented process to properly set hEndOfBuffer when sound effects end 2012-06-11 12:20:12 +10:00
Matthew Hoops
2da2981682 TONY: Rewind sounds before playing them 
Fixes sounds in the menu
 2012-06-10 22:03:52 -04:00
Matthew Hoops
42f4fe359c TONY: Convert FPSFX to our mixer code 
Only thing missing is the hEndOfBuffer code, but this is a good start
 2012-06-10 21:23:28 -04:00
Matthew Hoops
1668a23192 TONY: Make FPSOUND work in ScummVM 2012-06-09 18:40:43 -04:00
Matthew Hoops
05340fa4ca TONY: Remove custom sound CODEC classes 
We already have our own raw PCM and IMA ADPCM classes that we will use
 2012-06-09 18:14:18 -04:00
Matthew Hoops
9b3df4de21 TONY: Rework the way wave files are loaded 
We'll let our own sound code take care of the RIFF header
 2012-06-09 18:09:54 -04:00
Strangerke
c52aca5ac4 TONY: Rename more globals 2012-06-09 00:52:38 +02:00
Strangerke
cd15e483ed TONY: Some more renaming 2012-06-07 21:14:59 +02:00
Strangerke
94d3c8ebb2 TONY: Some more code formatting 2012-05-21 23:54:32 +02:00
Paul Gilbert
9eb66a2324 TONY: Added endian fixes for reading data 2012-05-14 20:22:52 +10:00
Strangerke
099fe1e9e6 TONY: Remove original header 2012-05-14 07:43:50 +02:00
Paul Gilbert
b01482bddb TONY: Further globals added to Globals class 2012-05-13 23:05:41 +10:00
Paul Gilbert
546f47ddce TONY: Beginnings of refactoring Globals into their own class 2012-05-13 22:34:40 +10:00
Paul Gilbert
c35b539716 TONY: Some further initialisation of object fields 2012-05-13 09:43:11 +10:00
Paul Gilbert
65ec900ceb TONY: Removed old extern, PASCAL, and EXPORT function modifiers 2012-05-12 11:01:20 +10:00
Paul Gilbert
68c1b0b0e4 TONY: Refactored Tony to use the Common coroutine scheduler 2012-05-11 23:15:59 +10:00
Paul Gilbert
5a069cdc86 TONY: Refactored out usage of nullContext in favour of proper coroutines 2012-05-09 23:15:41 +10:00
Paul Gilbert
26898dd7ad TONY: Completed bulk of initial coro refactoring 2012-05-09 00:42:27 +10:00
Paul Gilbert
23cd3b7730 TONY: Fixed many warnings identified by gcc 2012-05-04 22:28:51 +10:00
Paul Gilbert
a2982a0b20 TONY: Engine is now compiling and linking again 2012-05-03 22:49:30 +10:00
Paul Gilbert
ba2711b5e3 TONY: Implemented methods of sound.cpp (mostly stubbed out) 2012-05-03 21:43:00 +10:00
Paul Gilbert
b0eef82972 TONY: Added include files for graphics engine and all dependent classes 2012-04-30 09:27:12 +10:00